leek - npm Package Compare versions

Comparing version 0.0.21 to 0.0.22

lib/leek.js

@@ -10,3 +10,3 @@ 'use strict';
     debug       = require('debug')('leek'),
-    request;
+    https;
 
@@ -59,8 +59,7 @@ function Leek(options) {
   }
-  
-  if (request === undefined) {
-    request = RSVP.denodeify(require('request'));
+
+  if (https === undefined) {
+    https = RSVP.denodeify(require('https'));
   }
-
-  var params = provider.call(
+  var url = provider.call(
     this,
@@ -73,7 +72,10 @@ eventType,
   if (this.adapterUrls) {
-    params.url = this.adapterUrls[eventType];
+    url = this.adapterUrls[eventType];
   }
 
-  debug('request %o', params);
-  return request(params);
+  debug('http %o', url);
+
+  return https.get(url).on('error', function(e) {
+    console.log(e);
+  });
 };
@@ -80,0 +82,0 @@

lib/provider.js

 'use strict';
+
 var debug = require('debug')('leek:provider');
+var querystring = require('querystring');
 
@@ -82,3 +84,2 @@ var getAppViewObject = function() {
 
-
   debug('getTimingObject %o', payload);
@@ -117,26 +118,15 @@
 
+var gaUrl = 'https://google-analytics.com/collect?';
 var adapters = {
   appview: function() {
-    return {
-      url: 'https://ssl.google-analytics.com/collect',
-      qs: getAppViewObject.apply(this, arguments)
-    };
+    return gaUrl + querystring.stringify(getAppViewObject.apply(this, arguments));
   },
   exception: function() {
-    return {
-      url: 'https://ssl.google-analytics.com/collect',
-      qs: getExceptionObject.apply(this, arguments)
-    };
+    return gaUrl + querystring.stringify(getExceptionObject.apply(this, arguments));
   },
   timing: function() {
-    return {
-      url: 'https://ssl.google-analytics.com/collect',
-      qs: getTimingObject.apply(this, arguments)
-    };
+    return gaUrl + querystring.stringify(getTimingObject.apply(this, arguments));
   },
   event: function() {
-    return {
-      url: 'https://ssl.google-analytics.com/collect',
-      qs: getEventObject.apply(this, arguments)
-    };
+    return gaUrl + querystring.stringify(getEventObject.apply(this, arguments));
   }
@@ -143,0 +133,0 @@ };

package.json

 {
   "name": "leek",
   "description": "GA tracking",
-  "version": "0.0.21",
+  "version": "0.0.22",
   "keywords": [
@@ -6,0 +6,0 @@ "stats",

test/adapter-url-test.js

@@ -6,3 +6,3 @@ 'use strict';
     called = false,
-    params = {},
+    url    = null,
     rewire = require('rewire'),
@@ -14,7 +14,11 @@ Leek   = rewire('../lib/leek'),
   before(function() {
+    Leek.__set__('https', {
+      get: function(newUrl) {
+        called = true;
+        url = newUrl;
 
-    Leek.__set__('request', function(options) {
-      called = true;
-      params.url = options.url;
-      params.qs = options.qs;
+        return {
+          on: function() { }
+        };
+      }
     });
@@ -49,3 +53,3 @@
 
-    equal(params.url, 'http://example.com/collect-event');
+    equal(url, 'http://example.com/collect-event');
   });
@@ -61,3 +65,3 @@
 
-    equal(params.url, 'http://example.com/collect-timing');
+    equal(url, 'http://example.com/collect-timing');
   });
@@ -73,3 +77,3 @@
 
-    equal(params.url, 'http://example.com/collect-exception');
+    equal(url, 'http://example.com/collect-exception');
   });
@@ -85,4 +89,4 @@
 
-    equal(params.url, 'http://example.com/collect');
+    equal(url, 'http://example.com/collect');
   });
-});
+});

test/timing-test.js

@@ -5,8 +5,9 @@ 'use strict';
     ok     = assert.ok,
-    equal  = assert.equal,
+    include = assert.include,
     called = false,
-    params = {},
+    url    =  null,
     expected = null,
     rewire = require('rewire'),
     Leek   = rewire('../lib/leek'),
+    md5    = require('../lib/md5'),
     leek   = null;
@@ -29,6 +30,12 @@
 
-    Leek.__set__('request', function(options) {
-      called = true;
-      params.url = options.url;
-      params.qs = options.qs;
+    Leek.__set__('https', {
+      get: function(newUrl) {
+        called = true;
+
+        url = newUrl;
+
+        return {
+          on: function() { }
+        };
+      }
     });
@@ -40,3 +47,3 @@
       name:         'cli',
-      clientId:     'things',
+      clientId:     'ember-cli' + md5('things'),
       version:      '0.0.1'
@@ -60,12 +67,9 @@ });
 
-    equal(params.qs.v,   expected.v);
-    equal(params.qs.t,   expected.t);
-    equal(params.qs.aip, expected.aip);
-    equal(params.qs.tid, expected.tid);
-    equal(params.qs.an,  expected.an);
-
-    equal(params.qs.utv, expected.utv);
-    equal(params.qs.utt, expected.utt);
-    equal(params.qs.utl, expected.utl);
+    include(url, 'cid=ember-cli0898b22730d57afcd394d8e4889ece4a');
+    include(url, 'utt=200ms');
+    include(url, 't=timing');
+    include(url, 'utc=rebuild');
+    include(url, 'utl=broccoli');
+    include(url, 'utv=test');
   });
 });

New alerts

Network access

Supply chain risk

This module accesses the network.

Found 1 instance in 1 package

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Number of downloads

180526

increased by12197.41%

Worsened metrics

Total package byte prevSize

23147

decreased by-0.12%

No dependency changes