less-openui5 - npm Package Compare versions

Comparing version 0.8.2 to 0.8.3

CHANGELOG.md

@@ -5,4 +5,10 @@ # Changelog
 
-A list of unreleased changes can be found [here](https://github.com/SAP/less-openui5/compare/v0.8.2...HEAD).
+A list of unreleased changes can be found [here](https://github.com/SAP/less-openui5/compare/v0.8.3...HEAD).
 
+<a name="v0.8.3"></a>
+## [v0.8.3] - 2020-01-07
+### Bug Fixes
+- Diff algorithm exception ([#110](https://github.com/SAP/less-openui5/issues/110)) [`9628a6c`](https://github.com/SAP/less-openui5/commit/9628a6c6386b671e37a3c9680ca3b5fbd6175146)
+
+
 <a name="v0.8.2"></a>
@@ -39,2 +45,3 @@ ## [v0.8.2] - 2019-12-16
 
+[v0.8.3]: https://github.com/SAP/less-openui5/compare/v0.8.2...v0.8.3
 [v0.8.2]: https://github.com/SAP/less-openui5/compare/v0.8.1...v0.8.2
@@ -41,0 +48,0 @@ [v0.8.1]: https://github.com/SAP/less-openui5/compare/v0.8.0...v0.8.1

lib/diff.js

@@ -66,3 +66,3 @@ // Copyright 2019 SAP SE.
 		// Add all different compare nodes to stack and check for next one
-		while (oBaseNode.type !== oCompareNode.type) {
+		while (oCompareNode && oBaseNode.type !== oCompareNode.type) {
 			this.oStack.stylesheet.rules.push(oCompareNode);
@@ -73,3 +73,3 @@ iCompareNode++;
 
-		if (oBaseNode.type === "comment") {
+		if (oCompareNode && oBaseNode.type === "comment") {
 			const sBaseComment = oBaseNode.comment;
@@ -92,8 +92,8 @@ const sCompareComment = oCompareNode.comment;
 			const aBaseDeclarations = oBaseNode.declarations;
-			const aCompareDeclarations = oCompareNode.declarations;
+			const aCompareDeclarations = oCompareNode && oCompareNode.declarations;
 			for (let j = 0; j < aBaseDeclarations.length; j++) {
 				const oBaseDeclaration = aBaseDeclarations[j];
-				const oCompareDeclaration = aCompareDeclarations[j];
+				const oCompareDeclaration = aCompareDeclarations && aCompareDeclarations[j];
 
-				if (oBaseDeclaration.type === "declaration") {
+				if (oCompareDeclaration && oBaseDeclaration.type === "declaration") {
 					// TODO: Also check for different node and add to stack???
@@ -117,3 +117,3 @@ if (oBaseDeclaration.type === oCompareDeclaration.type) {
 			}
-		} else if (oBaseNode.type === "media") {
+		} else if (oCompareNode && oBaseNode.type === "media") {
 			const aMediaDiffRules = this.diffRules(oBaseNode.rules, oCompareNode.rules);
@@ -120,0 +120,0 @@

package.json

 {
   "name": "less-openui5",
-  "version": "0.8.2",
+  "version": "0.8.3",
   "description": "Build OpenUI5 themes with Less.js",
@@ -43,3 +43,3 @@ "scripts": {
   "devDependencies": {
-    "eslint": "^6.7.2",
+    "eslint": "^6.8.0",
     "eslint-config-google": "^0.14.0",
@@ -46,0 +46,0 @@ "graceful-fs": "^4.2.3",

No alert changes

Improved metrics

Total package byte prevSize

352883

increased by0.12%

No dependency changes