magicpen - npm Package Compare versions

Comparing version 5.6.0 to 5.7.0

lib/MagicPen.js

@@ -148,4 +148,9 @@ /*global window*/
 MagicPen.prototype.addStyle = function (style, handler, allowRedefinition) {
-    if (this[style] && !allowRedefinition) {
-        throw new Error('"' + style + '" style is already defined, set 3rd arg (allowRedefinition) to true to define it anyway');
+    var existingType = typeof this[style];
+    if (existingType === 'function') {
+        if (!allowRedefinition) {
+            throw new Error('"' + style + '" style is already defined, set 3rd arg (allowRedefinition) to true to define it anyway');
+        }
+    } else if (existingType !== 'undefined') {
+        throw new Error('"' + style + '" style cannot be defined, it clashes with a built-in attribute');
     }
@@ -152,0 +157,0 @@

magicpen.js

@@ -488,4 +488,9 @@ /*!
 MagicPen.prototype.addStyle = function (style, handler, allowRedefinition) {
-    if (this[style] && !allowRedefinition) {
-        throw new Error('"' + style + '" style is already defined, set 3rd arg (allowRedefinition) to true to define it anyway');
+    var existingType = typeof this[style];
+    if (existingType === 'function') {
+        if (!allowRedefinition) {
+            throw new Error('"' + style + '" style is already defined, set 3rd arg (allowRedefinition) to true to define it anyway');
+        }
+    } else if (existingType !== 'undefined') {
+        throw new Error('"' + style + '" style cannot be defined, it clashes with a built-in attribute');
     }
@@ -492,0 +497,0 @@

package.json

 {
   "name": "magicpen",
-  "version": "5.6.0",
+  "version": "5.7.0",
   "description": "Styled output in both consoles and browsers",
@@ -5,0 +5,0 @@ "main": "./lib/MagicPen.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

578622

increased by0.14%

Lines of code

4310

increased by0.35%

No dependency changes