makeup-navigation-emitter - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

index.js

@@ -168,2 +168,3 @@ 'use strict';
         this.model = model;
+        this.el = el;
 
@@ -180,18 +181,35 @@ this._keyPrevListener = onKeyPrev.bind(model);
 
-        KeyEmitter.addKeyDown(el);
-        ExitEmitter.addFocusExit(el);
+        KeyEmitter.addKeyDown(this.el);
+        ExitEmitter.addFocusExit(this.el);
 
-        el.addEventListener('arrowLeftKeyDown', this._keyPrevListener);
-        el.addEventListener('arrowRightKeyDown', this._keyNextListener);
-        el.addEventListener('arrowUpKeyDown', this._keyPrevListener);
-        el.addEventListener('arrowDownKeyDown', this._keyNextListener);
-        el.addEventListener('homeKeyDown', this._keyHomeListener);
-        el.addEventListener('endKeyDown', this._keyEndListener);
-        el.addEventListener('click', this._clickListener);
-        el.addEventListener('focusExit', this._focusExitListener);
+        this.el.addEventListener('arrowLeftKeyDown', this._keyPrevListener);
+        this.el.addEventListener('arrowRightKeyDown', this._keyNextListener);
+        this.el.addEventListener('arrowUpKeyDown', this._keyPrevListener);
+        this.el.addEventListener('arrowDownKeyDown', this._keyNextListener);
+        this.el.addEventListener('homeKeyDown', this._keyHomeListener);
+        this.el.addEventListener('endKeyDown', this._keyEndListener);
+        this.el.addEventListener('click', this._clickListener);
+        this.el.addEventListener('focusExit', this._focusExitListener);
 
-        this._observer.observe(el, { childList: true, subtree: true });
+        this._observer.observe(this.el, { childList: true, subtree: true });
     }
 
-    _createClass(NavigationEmitter, null, [{
+    _createClass(NavigationEmitter, [{
+        key: 'destroy',
+        value: function destroy() {
+            KeyEmitter.removeKeyDown(this.el);
+            ExitEmitter.removeFocusExit(this.el);
+
+            this.el.removeEventListener('arrowLeftKeyDown', this._keyPrevListener);
+            this.el.removeEventListener('arrowRightKeyDown', this._keyNextListener);
+            this.el.removeEventListener('arrowUpKeyDown', this._keyPrevListener);
+            this.el.removeEventListener('arrowDownKeyDown', this._keyNextListener);
+            this.el.removeEventListener('homeKeyDown', this._keyHomeListener);
+            this.el.removeEventListener('endKeyDown', this._keyEndListener);
+            this.el.removeEventListener('click', this._clickListener);
+            this.el.removeEventListener('focusExit', this._focusExitListener);
+
+            this._observer.disconnect();
+        }
+    }], [{
         key: 'createLinear',
@@ -198,0 +216,0 @@ value: function createLinear(el, itemSelector, selectedOptions) {

package.json

 {
   "name": "makeup-navigation-emitter",
   "description": "Emits custom events based on keyboard navigation of one or two dimensional model",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "main": "index.js",
@@ -37,17 +37,18 @@ "repository": "https://github.com/makeup-js/makeup-navigation-emitter.git",
     "coveralls": "^3",
-    "eslint": "^4",
-    "eslint-config-ebay": "~0.1",
-    "jasmine-core": "^2",
-    "karma": "^1",
+    "eslint": "^5",
+    "eslint-config-ebay": "^1",
+    "jasmine-core": "^3",
+    "karma": "^4",
+    "karma-chrome-launcher": "^2",
     "karma-coverage": "^1",
     "karma-html-reporter": "~0.2",
-    "karma-jasmine": "^1",
-    "karma-phantomjs-launcher": "^1",
+    "karma-jasmine": "^2",
     "lasso-cli": "^2",
-    "onchange": "^3",
+    "onchange": "^5",
     "parallelshell": "^3",
+    "puppeteer": "^1",
     "rimraf": "^2"
   },
   "dependencies": {
-    "custom-event-polyfill": "^0.3.0",
+    "custom-event-polyfill": "^1",
     "makeup-exit-emitter": "~0.0.4",
@@ -54,0 +55,0 @@ "makeup-key-emitter": "~0.0.3"

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

238955

increased by36.5%

Lines of code

202

increased by8.6%

Worsened metrics

Dev dependency count

18

increased by5.88%

Number of medium supply chain risk alerts

1

increased byInfinity%

Dependency changes

• + Addedcustom-event-polyfill@1.0.7(transitive)

• Updatedcustom-event-polyfill@^1