medium-editor-tc-mention - npm Package Compare versions

Comparing version 2.2.1 to 2.2.2

CHANGELOG.md

@@ -0,1 +1,11 @@
+<a name="2.2.2"></a>
+## [2.2.2](https://github.com/tomchentw/medium-editor-tc-mention/compare/v2.2.1...v2.2.2) (2016-02-17)
+
+
+### Bug Fixes
+
+* **TCMention:** use this.base.unsubscribe ([db9044c](https://github.com/tomchentw/medium-editor-tc-mention/commit/db9044c))
+
+
+
 <a name="2.2.1"></a>
@@ -2,0 +12,0 @@ ## [2.2.1](https://github.com/tomchentw/medium-editor-tc-mention/compare/v2.2.0...v2.2.1) (2016-02-17)

lib/index.js

@@ -152,22 +152,14 @@ "use strict";
   },
-  subscribeAndReturnUnsubscribeCallback: function subscribeAndReturnUnsubscribeCallback(eventName, callbackName) {
+  attachEventHandlers: function attachEventHandlers() {
     var _this = this;
 
-    var boundCallback = this[callbackName].bind(this);
-    this.subscribe(eventName, boundCallback);
-    return function () {
-      _this.unsubscribe(eventName, boundCallback);
-    };
-  },
-  attachEventHandlers: function attachEventHandlers() {
-    var _this2 = this;
-
     this.unsubscribeCallbacks = [];
 
     var subscribeCallbackName = function subscribeCallbackName(eventName, callbackName) {
-      var boundCallback = _this2[callbackName].bind(_this2);
-      _this2.subscribe(eventName, boundCallback);
+      var boundCallback = _this[callbackName].bind(_this);
+      _this.subscribe(eventName, boundCallback);
 
-      _this2.unsubscribeCallbacks.push(function () {
-        _this2.unsubscribe(eventName, boundCallback);
+      _this.unsubscribeCallbacks.push(function () {
+        // Bug: this.unsubscribe isn't exist!
+        _this.base.unsubscribe(eventName, boundCallback);
       });
@@ -197,7 +189,7 @@ };
   handleBlur: function handleBlur() {
-    var _this3 = this;
+    var _this2 = this;
 
     if (this.hideOnBlurDelay !== null && this.hideOnBlurDelay !== undefined) {
       this.hideOnBlurDelayId = setTimeout(function () {
-        _this3.hidePanel(false);
+        _this2.hidePanel(false);
       }, this.hideOnBlurDelay);
@@ -204,0 +196,0 @@ }

lib/index.min.js

@@ -1,2 +0,2 @@
-!function(t,e){if("object"==typeof exports&&"object"==typeof module)module.exports=e(require("MediumEditor"));else if("function"==typeof define&&define.amd)define(["MediumEditor"],e);else{var i=e("object"==typeof exports?require("MediumEditor"):t.MediumEditor);for(var n in i)("object"==typeof exports?exports:t)[n]=i[n]}}(this,function(t){return function(t){function e(n){if(i[n])return i[n].exports;var s=i[n]={exports:{},id:n,loaded:!1};return t[n].call(s.exports,s,s.exports,e),s.loaded=!0,s.exports}var i={};return e.m=t,e.c=i,e.p="",e(0)}([function(t,e,i){"use strict";function n(t){return t&&t.__esModule?t:{"default":t}}function s(t){return t[t.length-1]}function a(t,e){var i=t.parentNode;o["default"].util.unwrap(t,e);for(var n=i.lastChild,s=n.previousSibling;s;)3===n.nodeType&&3===s.nodeType&&(s.textContent+=n.textContent,i.removeChild(n)),n=s,s=n.previousSibling}Object.defineProperty(e,"__esModule",{value:!0}),e.TCMention=e.LEFT_ARROW_KEYCODE=void 0,e.unwrapForTextNode=a;var r=i(1),o=n(r),l=e.LEFT_ARROW_KEYCODE=37,h=e.TCMention=o["default"].Extension.extend({name:"mention",extraClassName:"",extraActiveClassName:"",extraPanelClassName:"",extraActivePanelClassName:"",extraTriggerClassNameMap:{},extraActiveTriggerClassNameMap:{},tagName:"strong",renderPanelContent:function(){},destroyPanelContent:function(){},activeTriggerList:["@"],triggerClassNameMap:{"#":"medium-editor-mention-hash","@":"medium-editor-mention-at"},activeTriggerClassNameMap:{"#":"medium-editor-mention-hash-active","@":"medium-editor-mention-at-active"},hideOnBlurDelay:300,init:function(){this.initMentionPanel(),this.attachEventHandlers()},destroy:function(){this.detachEventHandlers(),this.destroyMentionPanel()},initMentionPanel:function(){var t=this.document.createElement("div");t.classList.add("medium-editor-mention-panel"),(this.extraPanelClassName||this.extraClassName)&&t.classList.add(this.extraPanelClassName||this.extraClassName),this.getEditorOption("elementsContainer").appendChild(t),this.mentionPanel=t},destroyMentionPanel:function(){this.mentionPanel&&(this.mentionPanel.parentNode&&(this.destroyPanelContent(this.mentionPanel),this.mentionPanel.parentNode.removeChild(this.mentionPanel)),delete this.mentionPanel)},subscribeAndReturnUnsubscribeCallback:function(t,e){var i=this,n=this[e].bind(this);return this.subscribe(t,n),function(){i.unsubscribe(t,n)}},attachEventHandlers:function(){var t=this;this.unsubscribeCallbacks=[];var e=function(e,i){var n=t[i].bind(t);t.subscribe(e,n),t.unsubscribeCallbacks.push(function(){t.unsubscribe(e,n)})};null!==this.hideOnBlurDelay&&void 0!==this.hideOnBlurDelay&&(e("blur","handleBlur"),e("focus","handleFocus")),e("editableKeyup","handleKeyup")},detachEventHandlers:function(){this.hideOnBlurDelayId&&clearTimeout(this.hideOnBlurDelayId),this.unsubscribeCallbacks&&(this.unsubscribeCallbacks.forEach(function(t){return t()}),this.unsubscribeCallbacks=null)},handleBlur:function(){var t=this;null!==this.hideOnBlurDelay&&void 0!==this.hideOnBlurDelay&&(this.hideOnBlurDelayId=setTimeout(function(){t.hidePanel(!1)},this.hideOnBlurDelay))},handleFocus:function(){this.hideOnBlurDelayId&&(clearTimeout(this.hideOnBlurDelayId),this.hideOnBlurDelayId=null)},handleKeyup:function(t){var e=o["default"].util.getKeyCode(t),i=e===o["default"].util.keyCode.SPACE;this.getWordFromSelection(t.target,i?-1:0),!i&&-1!==this.activeTriggerList.indexOf(this.trigger)&&this.word.length>1?this.showPanel():this.hidePanel(e===l)},hidePanel:function(t){this.mentionPanel.classList.remove("medium-editor-mention-panel-active");var e=this.extraActivePanelClassName||this.extraActiveClassName;if(e&&this.mentionPanel.classList.remove(e),this.activeMentionAt&&(this.activeMentionAt.classList.remove(this.activeTriggerClassName),this.extraActiveTriggerClassName&&this.activeMentionAt.classList.remove(this.extraActiveTriggerClassName)),this.activeMentionAt){var i=this.activeMentionAt,n=i.parentNode,r=i.previousSibling,l=i.nextSibling,h=i.firstChild,d=t?r:l,c=void 0;d?3!==d.nodeType?(c=this.document.createTextNode(""),n.insertBefore(c,d)):c=d:(c=this.document.createTextNode(""),n.appendChild(c));var u=s(h.textContent),m=0===u.trim().length;if(m){var g=h.textContent;h.textContent=g.substr(0,g.length-1),c.textContent=""+u+c.textContent}else 0===c.textContent.length&&h.textContent.length>1&&(c.textContent=" ");t?o["default"].selection.select(this.document,c,c.length):o["default"].selection.select(this.document,c,Math.min(c.length,1)),h.textContent.length<=1&&(this.base.saveSelection(),a(this.activeMentionAt,this.document),this.base.restoreSelection()),this.activeMentionAt=null}},getWordFromSelection:function(t,e){function i(t,e){var n=l[t-1];return null===n||void 0===n?t:0===n.trim().length||0>=t||l.length<t?t:i(t+e,e)}var n=o["default"].selection.getSelectionRange(this.document),s=n.startContainer,a=n.startOffset,r=n.endContainer;if(s===r){var l=s.textContent;this.wordStart=i(a+e,-1),this.wordEnd=i(a+e,1)-1,this.word=l.slice(this.wordStart,this.wordEnd),this.trigger=this.word.slice(0,1),this.triggerClassName=this.triggerClassNameMap[this.trigger],this.activeTriggerClassName=this.activeTriggerClassNameMap[this.trigger],this.extraTriggerClassName=this.extraTriggerClassNameMap[this.trigger],this.extraActiveTriggerClassName=this.extraActiveTriggerClassNameMap[this.trigger]}},showPanel:function(){this.mentionPanel.classList.contains("medium-editor-mention-panel-active")||(this.activatePanel(),this.wrapWordInMentionAt()),this.positionPanel(),this.updatePanelContent()},activatePanel:function(){this.mentionPanel.classList.add("medium-editor-mention-panel-active"),(this.extraActivePanelClassName||this.extraActiveClassName)&&this.mentionPanel.classList.add(this.extraActivePanelClassName||this.extraActiveClassName)},wrapWordInMentionAt:function(){var t=this.document.getSelection();if(t.rangeCount){var e=t.getRangeAt(0).cloneRange();if(e.startContainer.parentNode.classList.contains(this.triggerClassName))this.activeMentionAt=e.startContainer.parentNode;else{var i=Math.min(this.wordEnd,e.startContainer.textContent.length);e.setStart(e.startContainer,this.wordStart),e.setEnd(e.startContainer,i);var n=this.document.createElement(this.tagName);n.classList.add(this.triggerClassName),this.extraTriggerClassName&&n.classList.add(this.extraTriggerClassName),this.activeMentionAt=n,e.surroundContents(n),t.removeAllRanges(),t.addRange(e),o["default"].selection.select(this.document,this.activeMentionAt.firstChild,this.word.length)}this.activeMentionAt.classList.add(this.activeTriggerClassName),this.extraActiveTriggerClassName&&this.activeMentionAt.classList.add(this.extraActiveTriggerClassName)}},positionPanel:function(){var t=this.activeMentionAt.getBoundingClientRect(),e=t.bottom,i=t.left,n=t.width,s=this.window,a=s.pageXOffset,r=s.pageYOffset;this.mentionPanel.style.top=r+e+"px",this.mentionPanel.style.left=a+i+n+"px"},updatePanelContent:function(){this.renderPanelContent(this.mentionPanel,this.word,this.handleSelectMention.bind(this))},handleSelectMention:function(t){if(t){var e=this.activeMentionAt.firstChild;e.textContent=t,o["default"].selection.select(this.document,e,t.length),this.hidePanel(!1)}else this.hidePanel(!1)}});e["default"]=h},function(e,i){e.exports=t}])});
+!function(t,e){if("object"==typeof exports&&"object"==typeof module)module.exports=e(require("MediumEditor"));else if("function"==typeof define&&define.amd)define(["MediumEditor"],e);else{var i=e("object"==typeof exports?require("MediumEditor"):t.MediumEditor);for(var n in i)("object"==typeof exports?exports:t)[n]=i[n]}}(this,function(t){return function(t){function e(n){if(i[n])return i[n].exports;var a=i[n]={exports:{},id:n,loaded:!1};return t[n].call(a.exports,a,a.exports,e),a.loaded=!0,a.exports}var i={};return e.m=t,e.c=i,e.p="",e(0)}([function(t,e,i){"use strict";function n(t){return t&&t.__esModule?t:{"default":t}}function a(t){return t[t.length-1]}function s(t,e){var i=t.parentNode;o["default"].util.unwrap(t,e);for(var n=i.lastChild,a=n.previousSibling;a;)3===n.nodeType&&3===a.nodeType&&(a.textContent+=n.textContent,i.removeChild(n)),n=a,a=n.previousSibling}Object.defineProperty(e,"__esModule",{value:!0}),e.TCMention=e.LEFT_ARROW_KEYCODE=void 0,e.unwrapForTextNode=s;var r=i(1),o=n(r),l=e.LEFT_ARROW_KEYCODE=37,h=e.TCMention=o["default"].Extension.extend({name:"mention",extraClassName:"",extraActiveClassName:"",extraPanelClassName:"",extraActivePanelClassName:"",extraTriggerClassNameMap:{},extraActiveTriggerClassNameMap:{},tagName:"strong",renderPanelContent:function(){},destroyPanelContent:function(){},activeTriggerList:["@"],triggerClassNameMap:{"#":"medium-editor-mention-hash","@":"medium-editor-mention-at"},activeTriggerClassNameMap:{"#":"medium-editor-mention-hash-active","@":"medium-editor-mention-at-active"},hideOnBlurDelay:300,init:function(){this.initMentionPanel(),this.attachEventHandlers()},destroy:function(){this.detachEventHandlers(),this.destroyMentionPanel()},initMentionPanel:function(){var t=this.document.createElement("div");t.classList.add("medium-editor-mention-panel"),(this.extraPanelClassName||this.extraClassName)&&t.classList.add(this.extraPanelClassName||this.extraClassName),this.getEditorOption("elementsContainer").appendChild(t),this.mentionPanel=t},destroyMentionPanel:function(){this.mentionPanel&&(this.mentionPanel.parentNode&&(this.destroyPanelContent(this.mentionPanel),this.mentionPanel.parentNode.removeChild(this.mentionPanel)),delete this.mentionPanel)},attachEventHandlers:function(){var t=this;this.unsubscribeCallbacks=[];var e=function(e,i){var n=t[i].bind(t);t.subscribe(e,n),t.unsubscribeCallbacks.push(function(){t.base.unsubscribe(e,n)})};null!==this.hideOnBlurDelay&&void 0!==this.hideOnBlurDelay&&(e("blur","handleBlur"),e("focus","handleFocus")),e("editableKeyup","handleKeyup")},detachEventHandlers:function(){this.hideOnBlurDelayId&&clearTimeout(this.hideOnBlurDelayId),this.unsubscribeCallbacks&&(this.unsubscribeCallbacks.forEach(function(t){return t()}),this.unsubscribeCallbacks=null)},handleBlur:function(){var t=this;null!==this.hideOnBlurDelay&&void 0!==this.hideOnBlurDelay&&(this.hideOnBlurDelayId=setTimeout(function(){t.hidePanel(!1)},this.hideOnBlurDelay))},handleFocus:function(){this.hideOnBlurDelayId&&(clearTimeout(this.hideOnBlurDelayId),this.hideOnBlurDelayId=null)},handleKeyup:function(t){var e=o["default"].util.getKeyCode(t),i=e===o["default"].util.keyCode.SPACE;this.getWordFromSelection(t.target,i?-1:0),!i&&-1!==this.activeTriggerList.indexOf(this.trigger)&&this.word.length>1?this.showPanel():this.hidePanel(e===l)},hidePanel:function(t){this.mentionPanel.classList.remove("medium-editor-mention-panel-active");var e=this.extraActivePanelClassName||this.extraActiveClassName;if(e&&this.mentionPanel.classList.remove(e),this.activeMentionAt&&(this.activeMentionAt.classList.remove(this.activeTriggerClassName),this.extraActiveTriggerClassName&&this.activeMentionAt.classList.remove(this.extraActiveTriggerClassName)),this.activeMentionAt){var i=this.activeMentionAt,n=i.parentNode,r=i.previousSibling,l=i.nextSibling,h=i.firstChild,d=t?r:l,c=void 0;d?3!==d.nodeType?(c=this.document.createTextNode(""),n.insertBefore(c,d)):c=d:(c=this.document.createTextNode(""),n.appendChild(c));var u=a(h.textContent),m=0===u.trim().length;if(m){var g=h.textContent;h.textContent=g.substr(0,g.length-1),c.textContent=""+u+c.textContent}else 0===c.textContent.length&&h.textContent.length>1&&(c.textContent=" ");t?o["default"].selection.select(this.document,c,c.length):o["default"].selection.select(this.document,c,Math.min(c.length,1)),h.textContent.length<=1&&(this.base.saveSelection(),s(this.activeMentionAt,this.document),this.base.restoreSelection()),this.activeMentionAt=null}},getWordFromSelection:function(t,e){function i(t,e){var n=l[t-1];return null===n||void 0===n?t:0===n.trim().length||0>=t||l.length<t?t:i(t+e,e)}var n=o["default"].selection.getSelectionRange(this.document),a=n.startContainer,s=n.startOffset,r=n.endContainer;if(a===r){var l=a.textContent;this.wordStart=i(s+e,-1),this.wordEnd=i(s+e,1)-1,this.word=l.slice(this.wordStart,this.wordEnd),this.trigger=this.word.slice(0,1),this.triggerClassName=this.triggerClassNameMap[this.trigger],this.activeTriggerClassName=this.activeTriggerClassNameMap[this.trigger],this.extraTriggerClassName=this.extraTriggerClassNameMap[this.trigger],this.extraActiveTriggerClassName=this.extraActiveTriggerClassNameMap[this.trigger]}},showPanel:function(){this.mentionPanel.classList.contains("medium-editor-mention-panel-active")||(this.activatePanel(),this.wrapWordInMentionAt()),this.positionPanel(),this.updatePanelContent()},activatePanel:function(){this.mentionPanel.classList.add("medium-editor-mention-panel-active"),(this.extraActivePanelClassName||this.extraActiveClassName)&&this.mentionPanel.classList.add(this.extraActivePanelClassName||this.extraActiveClassName)},wrapWordInMentionAt:function(){var t=this.document.getSelection();if(t.rangeCount){var e=t.getRangeAt(0).cloneRange();if(e.startContainer.parentNode.classList.contains(this.triggerClassName))this.activeMentionAt=e.startContainer.parentNode;else{var i=Math.min(this.wordEnd,e.startContainer.textContent.length);e.setStart(e.startContainer,this.wordStart),e.setEnd(e.startContainer,i);var n=this.document.createElement(this.tagName);n.classList.add(this.triggerClassName),this.extraTriggerClassName&&n.classList.add(this.extraTriggerClassName),this.activeMentionAt=n,e.surroundContents(n),t.removeAllRanges(),t.addRange(e),o["default"].selection.select(this.document,this.activeMentionAt.firstChild,this.word.length)}this.activeMentionAt.classList.add(this.activeTriggerClassName),this.extraActiveTriggerClassName&&this.activeMentionAt.classList.add(this.extraActiveTriggerClassName)}},positionPanel:function(){var t=this.activeMentionAt.getBoundingClientRect(),e=t.bottom,i=t.left,n=t.width,a=this.window,s=a.pageXOffset,r=a.pageYOffset;this.mentionPanel.style.top=r+e+"px",this.mentionPanel.style.left=s+i+n+"px"},updatePanelContent:function(){this.renderPanelContent(this.mentionPanel,this.word,this.handleSelectMention.bind(this))},handleSelectMention:function(t){if(t){var e=this.activeMentionAt.firstChild;e.textContent=t,o["default"].selection.select(this.document,e,t.length),this.hidePanel(!1)}else this.hidePanel(!1)}});e["default"]=h},function(e,i){e.exports=t}])});
 //# sourceMappingURL=index.min.js.map

package.json

 {
   "name": "medium-editor-tc-mention",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "description": "MediumEditor extension for mention panels like @username or #tagging",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/index.js

@@ -144,10 +144,2 @@ import {
 
-  subscribeAndReturnUnsubscribeCallback(eventName, callbackName) {
-    const boundCallback = ::this[callbackName];
-    this.subscribe(eventName, boundCallback);
-    return () => {
-      this.unsubscribe(eventName, boundCallback);
-    };
-  },
-
   attachEventHandlers() {
@@ -161,3 +153,4 @@ this.unsubscribeCallbacks = [];
       this.unsubscribeCallbacks.push(() => {
-        this.unsubscribe(eventName, boundCallback);
+        // Bug: this.unsubscribe isn't exist!
+        this.base.unsubscribe(eventName, boundCallback);
       });
@@ -164,0 +157,0 @@ };

No alert changes

Worsened metrics

Total package byte prevSize

89730

decreased by-1.14%

Lines of code

722

decreased by-1.9%

No dependency changes