metapak-sencrop - npm Package Compare versions

Comparing version 7.3.1 to 7.3.2

CHANGELOG.md

@@ -0,1 +1,10 @@
+## [7.3.2](https://github.com/sencrop/metapak-sencrop/compare/v7.3.1...v7.3.2) (2019-04-19)
+
+
+### Bug Fixes
+
+* **eslint:** correct eslint version for cra ([98d0330](https://github.com/sencrop/metapak-sencrop/commit/98d0330))
+
+
+
 ## [7.3.1](https://github.com/sencrop/metapak-sencrop/compare/v7.3.0...v7.3.1) (2019-04-10)
@@ -2,0 +11,0 @@

package.json

 {
   "name": "metapak-sencrop",
-  "version": "7.3.1",
+  "version": "7.3.2",
   "description": "A `metapak` plugin for Sencrop projects",
@@ -5,0 +5,0 @@ "main": "index.js",

src/eslint/package.js

@@ -8,23 +8,29 @@ 'use strict';
   backend: {
-    extends: 'eslint:recommended',
-    parserOptions: {
-      sourceType: 'module',
-      ecmaVersion: 9,
+    version: '^5.14.1',
+    config: {
+      extends: 'eslint:recommended',
+      parserOptions: {
+        sourceType: 'module',
+        ecmaVersion: 9,
+      },
+      env: {
+        es6: true,
+        node: true,
+        jest: true,
+        mocha: true,
+      },
+      plugins: ['prettier', 'import'],
+      rules: {
+        'prettier/prettier': 'error',
+      },
     },
-    env: {
-      es6: true,
-      node: true,
-      jest: true,
-      mocha: true,
-    },
-    plugins: ['prettier', 'import'],
-    rules: {
-      'prettier/prettier': 'error',
-    },
   },
   'create-react-app': {
-    extends: 'react-app',
-    plugins: ['prettier'],
-    rules: {
-      'prettier/prettier': 'error',
+    version: '5.12.0',
+    config: {
+      extends: 'react-app',
+      plugins: ['prettier'],
+      rules: {
+        'prettier/prettier': 'error',
+      },
     },
@@ -55,11 +61,13 @@ },
 
-  packageConf.devDependencies.eslint =
-    data.eslintConfigType === 'create-react-app' ? '5.6.0' : '^5.14.1';
+  if (data.eslintConfigType !== 'create-react-app') {
+    packageConf.devDependencies['eslint-plugin-import'] = '^2.16.0';
+  }
   packageConf.devDependencies.prettier = '^1.16.4';
+  packageConf.devDependencies['eslint-plugin-prettier'] = '^3.0.1';
   packageConf.devDependencies['lint-staged'] = '^8.1.5';
-  packageConf.devDependencies['eslint-plugin-prettier'] = '^3.0.1';
-  packageConf.devDependencies['eslint-plugin-import'] = '^2.16.0';
 
   // Add eslint config
-  packageConf.eslintConfig = ESLINT_CONFIG[data.eslintConfigType];
+  packageConf.devDependencies.eslint =
+    ESLINT_CONFIG[data.eslintConfigType].version;
+  packageConf.eslintConfig = ESLINT_CONFIG[data.eslintConfigType].config;
 
@@ -66,0 +74,0 @@ // Add husky hooks for lint staged

src/eslint/package.test.js

@@ -7,3 +7,3 @@ 'use strict';
   describe('Package transformer', () => {
-    test('should work with an empty package.json', () => {
+    test('should work with an empty package.json for backend', () => {
       expect(
@@ -10,0 +10,0 @@ packageTransformer({

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

58342

increased by0.67%

Lines of code

631

increased by1.28%

No dependency changes