minijanus - npm Package Compare versions

Comparing version 0.1.6 to 0.1.7

bundle.js

@@ -82,3 +82,5 @@ (function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.Minijanus = f()}})(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
 JanusSession.prototype.destroy = function() {
-  return this.send({ janus: "destroy" });
+  return this.send({ janus: "destroy" }).then(() => {
+    this._killKeepalive();
+  });
 };
@@ -148,6 +150,14 @@
 
-JanusSession.prototype._resetKeepalive = function() {
+JanusSession.prototype._keepalive = function() {
+  return this.send({ janus: "keepalive" });
+};
+
+JanusSession.prototype._killKeepalive = function() {
   if (this.keepaliveTimeout) {
     clearTimeout(this.keepaliveTimeout);
   }
+};
+
+JanusSession.prototype._resetKeepalive = function() {
+  this._killKeepalive();
   if (this.options.keepaliveMs) {
@@ -158,6 +168,2 @@ this.keepaliveTimeout = setTimeout(() => this._keepalive(), this.options.keepaliveMs);
 
-JanusSession.prototype._keepalive = function() {
-  return this.send({ janus: "keepalive" });
-};
-
 module.exports = {
@@ -164,0 +170,0 @@ JanusPluginHandle,

minijanus.js

@@ -81,3 +81,5 @@ /** Whether to log information about incoming and outgoing Janus signals. **/
 JanusSession.prototype.destroy = function() {
-  return this.send({ janus: "destroy" });
+  return this.send({ janus: "destroy" }).then(() => {
+    this._killKeepalive();
+  });
 };
@@ -147,6 +149,14 @@
 
-JanusSession.prototype._resetKeepalive = function() {
+JanusSession.prototype._keepalive = function() {
+  return this.send({ janus: "keepalive" });
+};
+
+JanusSession.prototype._killKeepalive = function() {
   if (this.keepaliveTimeout) {
     clearTimeout(this.keepaliveTimeout);
   }
+};
+
+JanusSession.prototype._resetKeepalive = function() {
+  this._killKeepalive();
   if (this.options.keepaliveMs) {
@@ -157,6 +167,2 @@ this.keepaliveTimeout = setTimeout(() => this._keepalive(), this.options.keepaliveMs);
 
-JanusSession.prototype._keepalive = function() {
-  return this.send({ janus: "keepalive" });
-};
-
 module.exports = {
@@ -163,0 +169,0 @@ JanusPluginHandle,

package.json

 {
   "name": "minijanus",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "description": "Really simple and minimal wrapper for talking to the Janus signalling API.",
@@ -8,3 +8,3 @@ "main": "minijanus.js",
     "type": "git",
-    "url": "git+https://github.com/mquander/minijanus.js.git"
+    "url": "git+https://github.com/mozilla/minijanus.js.git"
   },
@@ -17,5 +17,5 @@ "keywords": [
   "bugs": {
-    "url": "https://github.com/mquander/minijanus.js/issues"
+    "url": "https://github.com/mozilla/minijanus.js/issues"
   },
-  "homepage": "https://github.com/mquander/minijanus.js#readme",
+  "homepage": "https://github.com/mozilla/minijanus.js#readme",
   "devDependencies": {
@@ -22,0 +22,0 @@ "browserify": "^14.5.0",

README.md

 # minijanus.js
 
 [![npm](https://img.shields.io/npm/v/minijanus.svg)](https://www.npmjs.com/package/minijanus)
-[![Build Status](https://travis-ci.org/mquander/minijanus.js.svg?branch=master)](https://travis-ci.org/mquander/minijanus.js)
+[![Build Status](https://travis-ci.org/mquander/minijanus.js.svg?branch=master)](https://travis-ci.org/mozilla/minijanus.js)
 
@@ -6,0 +6,0 @@ A super-simplistic and -minimal wrapper for talking to the [Janus signalling API][api-docs]. Developed for use with

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

67877

increased by1.02%

Lines of code

345

increased by2.99%

No dependency changes