minijanus - npm Package Compare versions

Comparing version 0.3.0 to 0.3.1

bundle.js

@@ -112,12 +112,21 @@ (function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.Minijanus = f()}})(function(){var define,module,exports;return (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);var f=new Error("Cannot find module '"+o+"'");throw f.code="MODULE_NOT_FOUND",f}var l=n[o]={exports:{}};t[o][0].call(l.exports,function(e){var n=t[o][1][e];return s(n?n:e)},l,l.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
     var txn = this.txns[signal.transaction];
+
+    if (txn == null) {
+      // this is a response to a transaction that wasn't caused via JanusSession.send, or a plugin replied twice to a
+      // single request, or something else that isn't under our purview; that's fine
+      return;
+    }
+
     if (signal.janus === "ack" && txn.type == "message") {
-      // this is an ack of an asynchronously-processed plugin request, we should wait
-      // to resolve the promise until the actual response comes in
-    } else if (txn != null) {
-      if (txn.timeout != null) {
-        clearTimeout(txn.timeout);
-      }
-      delete this.txns[signal.transaction];
-      (this.isError(signal) ? txn.reject : txn.resolve)(signal);
+      // this is an ack of an asynchronously-processed plugin request, we should wait to resolve the promise until the
+      // actual response comes in
+      return;
     }
+
+    if (txn.timeout != null) {
+      clearTimeout(txn.timeout);
+    }
+
+    delete this.txns[signal.transaction];
+    (this.isError(signal) ? txn.reject : txn.resolve)(signal);
   }
@@ -124,0 +133,0 @@ };

minijanus.js

@@ -111,12 +111,21 @@ /** Whether to log information about incoming and outgoing Janus signals. **/
     var txn = this.txns[signal.transaction];
+
+    if (txn == null) {
+      // this is a response to a transaction that wasn't caused via JanusSession.send, or a plugin replied twice to a
+      // single request, or something else that isn't under our purview; that's fine
+      return;
+    }
+
     if (signal.janus === "ack" && txn.type == "message") {
-      // this is an ack of an asynchronously-processed plugin request, we should wait
-      // to resolve the promise until the actual response comes in
-    } else if (txn != null) {
-      if (txn.timeout != null) {
-        clearTimeout(txn.timeout);
-      }
-      delete this.txns[signal.transaction];
-      (this.isError(signal) ? txn.reject : txn.resolve)(signal);
+      // this is an ack of an asynchronously-processed plugin request, we should wait to resolve the promise until the
+      // actual response comes in
+      return;
     }
+
+    if (txn.timeout != null) {
+      clearTimeout(txn.timeout);
+    }
+
+    delete this.txns[signal.transaction];
+    (this.isError(signal) ? txn.reject : txn.resolve)(signal);
   }
@@ -123,0 +132,0 @@ };

package.json

 {
   "name": "minijanus",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "Really simple and minimal wrapper for talking to the Janus signalling API.",
@@ -5,0 +5,0 @@ "main": "minijanus.js",

tests.js

@@ -12,2 +12,3 @@ var mj = require('./minijanus.js');
 
+  session.receive({ transaction: "???" });
   session.receive({ transaction: "bigs", janus: "ack" });
@@ -14,0 +15,0 @@ session.receive({ transaction: "figs", janus: "ack" });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

69644

increased by0.92%

Lines of code

373

increased by3.04%

No dependency changes