mobiledoc-kit - npm Package Compare versions

Comparing version 0.9.6 to 0.9.7

dist/commonjs/mobiledoc-kit/editor/editor.js

@@ -107,3 +107,3 @@ 'use strict';
 /**
- * The Editor is a core component of mobiledoc-kit. After instantiating 
+ * The Editor is a core component of mobiledoc-kit. After instantiating
  * an editor, use {@link Editor#render} to display the editor on the web page.
@@ -478,11 +478,13 @@ *
     value: function _notifyRangeChange() {
-      this._resetRange();
-      this._editState.reset();
+      if (this.isEditable) {
+        this._resetRange();
+        this._editState.reset();
 
-      if (this._editState.rangeDidChange()) {
-        this._rangeDidChange();
+        if (this._editState.rangeDidChange()) {
+          this._rangeDidChange();
+        }
+        if (this._editState.inputModeDidChange()) {
+          this._inputModeDidChange();
+        }
       }
-      if (this._editState.inputModeDidChange()) {
-        this._inputModeDidChange();
-      }
     }
@@ -489,0 +491,0 @@ }, {

dist/commonjs/mobiledoc-kit/utils/browser.js

 "use strict";
 
 exports["default"] = {
-  isMac: /Mac/.test(navigator.platform)
+  isMac: window.navigator && /Mac/.test(window.navigator.platform)
 };

dist/commonjs/mobiledoc-kit/utils/key.js

@@ -67,3 +67,4 @@ 'use strict';
 function isKeyEvent(event) {
-  return !!event.charCode || !!event.keyCode || !!event.metaKey || !!event.shiftKey || !!event.ctrlKey;
+  return (/^key/.test(event.type)
+  );
 }
@@ -70,0 +71,0 @@

dist/commonjs/mobiledoc-kit/utils/selection-utils.js

@@ -130,5 +130,17 @@ 'use strict';
     if (position & Node.DOCUMENT_POSITION_CONTAINS) {
+      if (focusOffset < focusNode.childNodes.length) {
+        focusNode = focusNode.childNodes[focusOffset];
+        focusOffset = 0;
+      } else {
+        // This situation happens on IE when triple-clicking to select.
+        // Set the focus to the very last character inside the node.
+        while (focusNode.lastChild) {
+          focusNode = focusNode.lastChild;
+        }
+        focusOffset = focusNode.textContent.length;
+      }
+
       _x3 = {
-        focusNode: focusNode.childNodes[focusOffset],
-        focusOffset: 0,
+        focusNode: focusNode,
+        focusOffset: focusOffset,
         anchorNode: anchorNode, anchorOffset: anchorOffset
@@ -135,0 +147,0 @@ };

dist/commonjs/mobiledoc-kit/version.js

 'use strict';
 
-exports['default'] = '0.9.6';
+exports['default'] = '0.9.7';

package.json

 {
   "name": "mobiledoc-kit",
-  "version": "0.9.6",
+  "version": "0.9.7",
   "description": "A toolkit for building WYSIWYG editors with Mobiledoc",
@@ -56,3 +56,3 @@ "repository": "https://github.com/bustlelabs/mobiledoc-kit",
     "saucie": "^1.4.0",
-    "testem": "^1.6.0",
+    "testem": "^1.7.4",
     "tiny-lr": "^0.2.1"
@@ -59,0 +59,0 @@ },

README.md

@@ -133,2 +133,3 @@ ## Mobiledoc Kit
   movement or clicking in the document.
+* `editor.onTextInput()` - When the user adds text to the document (see [example](https://github.com/bustlelabs/mobiledoc-kit#responding-to-text-input))
 
@@ -135,0 +136,0 @@ ### Programmatic Post Editing

src/js/editor/editor.js

@@ -69,3 +69,3 @@ import Tooltip from '../views/tooltip';
 /**
- * The Editor is a core component of mobiledoc-kit. After instantiating 
+ * The Editor is a core component of mobiledoc-kit. After instantiating
  * an editor, use {@link Editor#render} to display the editor on the web page.
@@ -413,11 +413,13 @@ *
   _notifyRangeChange() {
-    this._resetRange();
-    this._editState.reset();
+    if (this.isEditable) {
+      this._resetRange();
+      this._editState.reset();
 
-    if (this._editState.rangeDidChange()) {
-      this._rangeDidChange();
+      if (this._editState.rangeDidChange()) {
+        this._rangeDidChange();
+      }
+      if (this._editState.inputModeDidChange()) {
+        this._inputModeDidChange();
+      }
     }
-    if (this._editState.inputModeDidChange()) {
-      this._inputModeDidChange();
-    }
   }
@@ -424,0 +426,0 @@

src/js/utils/browser.js

 export default {
-  isMac: /Mac/.test(navigator.platform)
+  isMac: window.navigator && /Mac/.test(window.navigator.platform)
 };

src/js/utils/key.js

@@ -54,7 +54,3 @@ import Keycodes from './keycodes';
 function isKeyEvent(event) {
-  return !!event.charCode ||
-    !!event.keyCode ||
-    !!event.metaKey ||
-    !!event.shiftKey ||
-    !!event.ctrlKey;
+  return /^key/.test(event.type);
 }
@@ -61,0 +57,0 @@

src/js/utils/selection-utils.js

@@ -102,5 +102,17 @@ import { DIRECTION } from '../utils/key';
   if (position & Node.DOCUMENT_POSITION_CONTAINS) {
+    if (focusOffset < focusNode.childNodes.length) {
+      focusNode = focusNode.childNodes[focusOffset];
+      focusOffset = 0;
+    } else {
+      // This situation happens on IE when triple-clicking to select.
+      // Set the focus to the very last character inside the node.
+      while (focusNode.lastChild) {
+        focusNode = focusNode.lastChild;
+      }
+      focusOffset = focusNode.textContent.length;
+    }
+
     return comparePosition({
-      focusNode: focusNode.childNodes[focusOffset],
-      focusOffset: 0,
+      focusNode,
+      focusOffset,
       anchorNode, anchorOffset
@@ -107,0 +119,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

2966900

increased by0.09%

Lines of code

42580

increased by0.12%

Number of lines in readme file

342

increased by0.29%

No dependency changes