mongoose-paginate-v2 - npm Package Compare versions

Comparing version 1.3.17 to 1.3.18

.eslintrc.js

@@ -0,0 +0,0 @@ module.exports = {

CHANGELOG.md

 # Changelog
 
+## v1.3.18
+
+[2021-05-17]
+
+- Fixed issue #85
+
 ## v1.3.17
@@ -4,0 +10,0 @@

CODE_OF_CONDUCT.md

@@ -0,0 +0,0 @@ # Contributor Covenant Code of Conduct

dist/index.js

@@ -89,3 +89,8 @@ "use strict";
 
-  var limit = parseInt(options.limit, 10) > 0 ? parseInt(options.limit, 10) : 0;
+  var limit = defaultOptions.limit;
+
+  if (pagination) {
+    limit = parseInt(options.limit, 10) > 0 ? parseInt(options.limit, 10) : 0;
+  }
+
   var isCallbackSpecified = typeof callback === 'function';
@@ -122,2 +127,6 @@ var findOptions = options.options;
 
+  if (!pagination) {
+    page = 1;
+  }
+
   var countPromise;
@@ -239,5 +248,5 @@
       meta[labelLimit] = 0;
-      meta[labelTotalPages] = null;
-      meta[labelPage] = null;
-      meta[labelPagingCounter] = null;
+      meta[labelTotalPages] = 1;
+      meta[labelPage] = 1;
+      meta[labelPagingCounter] = 1;
       meta[labelPrevPage] = null;
@@ -244,0 +253,0 @@ meta[labelNextPage] = null;

package.json

 {
   "name": "mongoose-paginate-v2",
-  "version": "1.3.17",
+  "version": "1.3.18",
   "description": "A cursor based custom pagination library for Mongoose with customizable labels.",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

src/index.js

@@ -79,5 +79,8 @@ /**
 
-  const limit =
-    parseInt(options.limit, 10) > 0 ? parseInt(options.limit, 10) : 0;
+  let limit = defaultOptions.limit;
 
+  if (pagination) {
+    limit = parseInt(options.limit, 10) > 0 ? parseInt(options.limit, 10) : 0;
+  }
+
   const isCallbackSpecified = typeof callback === 'function';
@@ -117,2 +120,6 @@ const findOptions = options.options;
 
+  if (!pagination) {
+    page = 1;
+  }
+
   let countPromise;
@@ -237,5 +244,5 @@
         meta[labelLimit] = 0;
-        meta[labelTotalPages] = null;
-        meta[labelPage] = null;
-        meta[labelPagingCounter] = null;
+        meta[labelTotalPages] = 1;
+        meta[labelPage] = 1;
+        meta[labelPagingCounter] = 1;
         meta[labelPrevPage] = null;
@@ -242,0 +249,0 @@ meta[labelNextPage] = null;

tests/index.js

@@ -283,4 +283,4 @@ 'use strict';
       expect(result.limit).to.equal(0);
-      expect(result.page).to.equal(null);
-      expect(result.pagingCounter).to.equal(null);
+      expect(result.page).to.equal(1);
+      expect(result.pagingCounter).to.equal(1);
       expect(result.hasPrevPage).to.equal(false);
@@ -290,3 +290,3 @@ expect(result.hasNextPage).to.equal(false);
       expect(result.nextPage).to.equal(null);
-      expect(result.totalPages).to.equal(null);
+      expect(result.totalPages).to.equal(1);
     });
@@ -544,2 +544,29 @@ });
 
+  it('pagination=false, limit/page=undefined -> return all docs', function () {
+    var query = {
+      title: {
+        $in: [/Book/i],
+      },
+    };
+
+    var options = {
+      pagination: false,
+      page: undefined,
+      limit: undefined,
+    };
+
+    return Book.paginate(query, options).then((result) => {
+      expect(result.docs).to.have.length(100);
+      expect(result.totalDocs).to.equal(100);
+      expect(result.limit).to.equal(100);
+      expect(result.page).to.equal(1);
+      expect(result.pagingCounter).to.equal(1);
+      expect(result.hasPrevPage).to.equal(false);
+      expect(result.hasNextPage).to.equal(false);
+      expect(result.prevPage).to.equal(null);
+      expect(result.nextPage).to.equal(null);
+      expect(result.totalPages).to.equal(1);
+    });
+  });
+
   after(function (done) {
@@ -546,0 +573,0 @@ mongoose.connection.db.dropDatabase(done);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

286256

increased by0.01%

Lines of code

1008

increased by3.6%

No dependency changes