mongoose-url-slugs - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

History.md

 # History
 
+## V 1.0.2 (September 19, 2017)
+* Fixed a bug which updated slug even when dependant fields were not selected.
+
 ## V 1.0.1 (September 19, 2017)
@@ -4,0 +7,0 @@ * Fixed a bug which added unnecessary numbers ([ralphnajm](https://github.com/ralphnajm))

index.js

@@ -195,2 +195,3 @@ var extend = require('extend');
       var slugFieldsModified = doc.isNew;
+      var slugFieldsSelected = true;
 
@@ -207,2 +208,3 @@ // Skip if it's an edit and the plugin is configured to not update.
           var slugField = slugFields[i];
+          if (!doc.isSelected(slugField)) slugFieldsSelected = false;
           if (doc.isModified(slugField)) slugFieldsModified = true;
@@ -215,2 +217,3 @@ var slugPart = doc.get(slugField, String);
       } else {
+        if (!doc.isSelected(slugField)) slugFieldsSelected = false;
         if (doc.isModified(slugFields)) slugFieldsModified = true;
@@ -221,3 +224,7 @@ var slugPart = doc.get(slugFields, String);
       }
-
+      
+      // Skip setting slug if slug dependant fields were not selected
+      if (!slugFieldsSelected) return next();
+      
+      
       if (!options.alwaysRecreate && !slugFieldsModified && currentSlug) return next();
@@ -224,0 +231,0 @@

package.json

@@ -9,3 +9,3 @@ {
   "description": "Create URL compatiable slugs on mongoose models, ensuring uniqueness.",
-  "version": "1.0.1",
+  "version": "1.0.2",
   "keywords": [
@@ -12,0 +12,0 @@ "mongoose slugs",

No alert changes

Improved metrics

Total package byte prevSize

21799

increased by1.98%

Lines of code

220

increased by2.33%

No dependency changes