muuri - npm Package Compare versions

Comparing version 0.9.1 to 0.9.2

package.json

 {
   "name": "muuri",
-  "version": "0.9.1",
+  "version": "0.9.2",
   "description": "Responsive, sortable, filterable and draggable layouts",
@@ -63,3 +63,3 @@ "keywords": [
     "husky": "^4.2.5",
-    "karma": "^5.1.0",
+    "karma": "^5.1.1",
     "karma-chrome-launcher": "^3.1.0",
@@ -75,8 +75,8 @@ "karma-edge-launcher": "^0.4.2",
     "prosthetic-hand": "^1.3.1",
-    "qunit": "^2.10.0",
+    "qunit": "^2.10.1",
     "rimraf": "^3.0.2",
-    "rollup": "^2.18.2",
-    "terser": "^4.8.0",
+    "rollup": "^2.23.1",
+    "terser": "^5.0.0",
     "web-animations-js": "^2.3.2"
   }
 }

src/AutoScroller/AutoScroller.js

@@ -673,2 +673,6 @@ /**
   if (this._isDestroyed) return;
+
+  // Make sure the item still exists in the auto-scroller.
+  if (!this._dragDirections[item._id]) return;
+
   this._updateDragDirection(item);
@@ -675,0 +679,0 @@ if (!this._requestOverlapCheck[item._id]) {

src/Item/ItemDrag.js

@@ -52,2 +52,5 @@ /**
 
+var IS_IOS =
+  /^(iPad|iPhone|iPod)/.test(window.navigator.platform) ||
+  (/^Mac/.test(window.navigator.platform) && window.navigator.maxTouchPoints > 1);
 var START_PREDICATE_INACTIVE = 0;
@@ -164,2 +167,3 @@ var START_PREDICATE_PENDING = 1;
   if (
+    !IS_IOS &&
     event.isFirst &&
@@ -451,2 +455,5 @@ event.srcEvent.isTrusted === true &&
 
+  // Stop auto-scroll.
+  ItemDrag.autoScroller.removeItem(this._item);
+
   // Cancel queued ticks.
@@ -499,3 +506,3 @@ var itemId = this._item._id;
   var item = this._item;
-  if (item._isActive && this._dragMoveEvent) {
+  if (this._isActive && item._isActive && this._dragMoveEvent) {
     if (force === true) {
@@ -778,2 +785,4 @@ this._handleSort();
 ItemDrag.prototype._handleSort = function () {
+  if (!this._isActive) return;
+
   var settings = this._getGrid()._settings;
@@ -1175,2 +1184,4 @@
 ItemDrag.prototype._prepareStart = function () {
+  if (!this._isActive) return;
+
   var item = this._item;
@@ -1215,2 +1226,4 @@ if (!item._isActive) return;
 ItemDrag.prototype._applyStart = function () {
+  if (!this._isActive) return;
+
   var item = this._item;
@@ -1297,4 +1310,5 @@ if (!item._isActive) return;
 ItemDrag.prototype._prepareMove = function () {
+  if (!this._isActive) return;
+
   var item = this._item;
-
   if (!item._isActive) return;
@@ -1334,2 +1348,4 @@
 ItemDrag.prototype._applyMove = function () {
+  if (!this._isActive) return;
+
   var item = this._item;
@@ -1369,5 +1385,6 @@ if (!item._isActive) return;
 ItemDrag.prototype._prepareScroll = function () {
-  var item = this._item;
+  if (!this._isActive) return;
 
   // If item is not active do nothing.
+  var item = this._item;
   if (!item._isActive) return;
@@ -1415,2 +1432,4 @@
 ItemDrag.prototype._applyScroll = function () {
+  if (!this._isActive) return;
+
   var item = this._item;
@@ -1417,0 +1436,0 @@ if (!item._isActive) return;

src/Item/ItemLayout.js

@@ -113,2 +113,9 @@ /**
 
+  // Let's make sure an ongoing animation's callback is cancelled before going
+  // further. Without this there's a chance that the animation will finish
+  // before the next tick and mess up our logic.
+  if (this._animation.isAnimating()) {
+    this._animation._animation.onfinish = null;
+  }
+
   // Kick off animation to be started in the next tick.
@@ -115,0 +122,0 @@ this._isActive = true;

src/Item/ItemVisibility.js

@@ -261,2 +261,9 @@ /**
 
+  // Let's make sure an ongoing animation's callback is cancelled before going
+  // further. Without this there's a chance that the animation will finish
+  // before the next tick and mess up our logic.
+  if (animation.isAnimating()) {
+    animation._animation.onfinish = null;
+  }
+
   // Start the animation in the next tick (to avoid layout thrashing).
@@ -263,0 +270,0 @@ addVisibilityTick(

No alert changes

Improved metrics

Total package byte prevSize

1003913

increased by0.41%

Lines of code

24501

increased by0.33%

No dependency changes