mx-connect - npm Package Compare versions

Comparing version 1.2.0 to 1.3.0

lib/mx-connect.js

@@ -8,2 +8,3 @@ 'use strict';
 const net = require('net');
+const dns = require('dns');
 
@@ -38,3 +39,4 @@ module.exports = (options, callback) => {
             preferIPv6: false,
-            blockLocalAddresses: false
+            blockLocalAddresses: false,
+            resolve: dns.resolve
         },
@@ -41,0 +43,0 @@

lib/resolve-ip.js

@@ -9,5 +9,5 @@ 'use strict';
 // we do not reject on error to avoid issues where one failing MX record kills entire sending
-function resolve4(mx) {
+function resolve4(mx, dnsResolve = dns.resolve) {
     return new Promise(resolve => {
-        dns.resolve4(mx.exchange, (err, list) => {
+        dnsResolve(mx.exchange, (err, list) => {
             if (err && err.code !== 'ENODATA' && err.code !== 'ENOTFOUND') {
@@ -23,5 +23,5 @@ mx.A = [].concat({ error: err, exchange: mx.exchange });
 
-function resolve6(mx) {
+function resolve6(mx, dnsResolve = dns.resolve) {
     return new Promise(resolve => {
-        dns.resolve6(mx.exchange, (err, list) => {
+        dnsResolve(mx.exchange, 'AAAA', (err, list) => {
             if (err && err.code !== 'ENODATA' && err.code !== 'ENOTFOUND') {
@@ -85,5 +85,5 @@ mx.AAAA = [].concat({ error: err, exchange: mx.exchange });
                 if (!net.isIP(entry.exchange)) {
-                    resolveAddresses.push(resolve4(entry));
+                    resolveAddresses.push(resolve4(entry, dnsOptions.resolve));
                     if (!dnsOptions.ignoreIPv6) {
-                        resolveAddresses.push(resolve6(entry));
+                        resolveAddresses.push(resolve6(entry, dnsOptions.resolve));
                     }
@@ -90,0 +90,0 @@ } else if (net.isIPv4(entry.exchange)) {

lib/resolve-mx.js

@@ -13,3 +13,4 @@ 'use strict';
         let dnsOptions = delivery.dnsOptions || {
-            ignoreIPv6: false
+            ignoreIPv6: false,
+            resolve: dns.resolve
         };
@@ -56,3 +57,3 @@
 
-        dns.resolveMx(domain, (err, list) => {
+        dnsOptions.resolve(domain, 'MX', (err, list) => {
             if (err && err.code !== 'ENODATA' && err.code !== 'ENOTFOUND') {
@@ -68,3 +69,3 @@ err.category = 'dns';
                 // fallback to A
-                return dns.resolve4(domain, (err, list) => {
+                return dnsOptions.resolve(domain, (err, list) => {
                     if (err && err.code !== 'ENODATA' && err.code !== 'ENOTFOUND') {
@@ -79,3 +80,3 @@ err.message = 'DNS error when resolving MX server for ' + domain + ': ' + (dnsErrors[err.code] || err.message);
                         // fallback to AAAA
-                        return dns.resolve6(domain, (err, list) => {
+                        return dnsOptions.resolve(domain, 'AAAA', (err, list) => {
                             if (err && err.code !== 'ENODATA' && err.code !== 'ENOTFOUND') {
@@ -82,0 +83,0 @@ err.message = 'DNS error when resolving MX server for ' + domain + ': ' + (dnsErrors[err.code] || err.message);

package.json

 {
     "name": "mx-connect",
-    "version": "1.2.0",
+    "version": "1.3.0",
     "description": "Establish TCP connection to a MX server",
@@ -26,11 +26,11 @@ "main": "lib/mx-connect.js",
         "eslint-config-nodemailer": "1.2.0",
-        "eslint-config-prettier": "6.11.0",
-        "grunt": "1.1.0",
-        "grunt-cli": "1.3.2",
-        "grunt-contrib-nodeunit": "2.1.0",
-        "grunt-eslint": "23.0.0"
+        "eslint-config-prettier": "8.6.0",
+        "grunt": "1.6.1",
+        "grunt-cli": "1.4.3",
+        "grunt-contrib-nodeunit": "4.0.0",
+        "grunt-eslint": "24.0.1"
     },
     "dependencies": {
-        "ipaddr.js": "1.9.1"
+        "ipaddr.js": "2.0.1"
     }
 }

README.md

@@ -57,2 +57,3 @@ # mx-connect
     -   **blockLocalAddresses** (boolean, defaults to `false`) If true then refuses to connect to IP addresses that are either in loopback, private network or attached to the server. People put every kind of stuff in MX records, you do not want to flood your loopback interface because someone thought it is a great idea to set 127.0.0.1 as the MX server
+    -   **resolve** (function, defaults to `dns.resolve`, callback-style)
 -   **mx** is a resolved MX object or an array of MX objects to skip DNS resolving. Useful if you want to connect to a specific host.
@@ -59,0 +60,0 @@ -   **exchange** is the hostname of the MX

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

55501

increased by0.54%

Lines of code

954

increased by0.32%

Number of lines in readme file

80

increased by1.27%

Worsened metrics

Number of medium supply chain risk alerts

9

increased by12.5%

Dependency changes

• + Addedipaddr.js@2.0.1(transitive)

• - Removedipaddr.js@1.9.1(transitive)

• Updatedipaddr.js@2.0.1