mysql-wrap-production - npm Package Compare versions

Comparing version 0.5.5 to 0.6.0

gruntfile.js

@@ -5,3 +5,3 @@ module.exports = function (grunt) {
             all: {
-                options: { reporter: 'dot' },
+                // options: { reporter: 'dot' },
                 src: ['test/**/*.js']
@@ -8,0 +8,0 @@ }

package.json

 {
   "name": "mysql-wrap-production",
-  "version": "0.5.5",
+  "version": "0.6.0",
   "description": "Mysql interface and helper functions, wrapping node-mysql",
@@ -5,0 +5,0 @@ "main": "src/mysql-wrap.js",

README.md

@@ -19,2 +19,13 @@ # node-mysql-wrap-production
 
+let pool = mysql.createPool(config.mysql);
+that.sql = createNodeMySQL(pool);
+
+```javascript
+var sql = createNodeMySQL(mysql.createPool({
+    host: config.mysql.host,
+    user: config.mysql.user,
+    password: config.mysql.password,
+}));
+```
+
 Pool Clusters with read write seperation is also supported
@@ -57,2 +68,4 @@ ```javascript
 
+
+
 ##Methods
@@ -59,0 +72,0 @@

src/mysql-wrap.js

@@ -218,9 +218,12 @@ 'use strict';
 
-    self.save = function (table, rowRaw) {
+    self.save = function (table, rowOrRows) {
+        let rows = _.isArray(rowOrRows) ? rowOrRows : [rowOrRows];
+
         let prepareSaveRows = function () {
-            let insertRow = prepareInsertRows(rowRaw);
+            let insertRow = prepareInsertRows(rows);
             let setValues = [];
-            let setSQL = _.map(rowRaw, function (val, key) {
-                setValues.push(key, val);
-                return '?? = ?';
+
+            let setSQL = _.map(_.first(rows), function (val, key) {
+                setValues.push(key, key);
+                return '?? = VALUES(??)';
             }).join(', ');
@@ -227,0 +230,0 @@

test/test.js

@@ -13,26 +13,12 @@ 'use strict';
         let that = this;
-        that.poolCluster = mysql.createPoolCluster({
-            canRetry: true,
-            removeNodeErrorCount: 1,
-            restoreNodeTimeout: 20000,
-            defaultSelector: 'RR'
-        });
 
-        that.poolCluster.add('MASTER', config.mysql);
-        that.poolCluster.add('SLAVE_1', _.extend(config.mysql, { port: 3307}));
+        that.stripIds = data => _.isArray(data) ?
+            _.map(data, that.stripIds) : _.omit(data, 'id');
 
-        that.sql = createNodeMySQL(that.poolCluster, {
-            replication: {
-                write: 'MASTER',
-                read: 'SLAVE_*'
-            }
+        let pool = mysql.createPool(config.mysql);
+        that.sql = createNodeMySQL(pool);
+        pool.getConnection(function (err, conn) {
+            that.masterConn = conn;
+            done();
         });
-
-        that.poolCluster.getConnection(
-            'MASTER',
-            function (err, conn) {
-                that.masterConn = conn;
-                done();
-            }
-        );
     });
@@ -58,9 +44,4 @@
                                 'VALUES ("bar")',
-                                function () {
-                                    // set timeout is necessary since it takes
-                                    // a little time for writes to master to
-                                    // propogate to the slaves
-                                    setTimeout(function () {
-                                        done();
-                                    }, 20);
+                                function (err) {
+                                    done();
                                 }
@@ -458,2 +439,25 @@ );
         });
+
+        it('should handle bulk save', function (done) {
+            let that = this;
+            let rows = [
+                { unique: 'a', field: 'edit-a' },
+                { unique: 'b', field: 'edit-b' },
+                { unique: 'd', field: 'new-field' }
+            ];
+            that.sql.save('table', rows)
+            .then(function () {
+                that.masterConn.query(
+                    'SELECT * FROM `table`',
+                    function (err, res) {
+                        chai.assert.sameDeepMembers(
+                            that.stripIds(res),
+                            that.stripIds(rows.concat([that.c]))
+                        );
+                        done();
+                    }
+                );
+            })
+            .done();
+        });
     });
@@ -460,0 +464,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

36614

increased by1.24%

Lines of code

706

increased by0.71%

Number of lines in readme file

200

increased by6.95%

No dependency changes