nats-hemera - npm Package Compare versions

Comparing version 3.3.0 to 3.4.0

lib/index.js

@@ -1596,9 +1596,35 @@ /**
   close(cb) {
-    this.shutdown((err, instance, done) => {
-      instance._onClose(err, err => {
-        if (_.isFunction(cb)) {
-          cb(err)
-        }
-        done(err)
+    const self = this
+
+    // callback style
+    if (_.isFunction(cb)) {
+      self.shutdown((err, instance, done) => {
+        instance._onClose(() => {
+          if (_.isFunction(cb)) {
+            if (err) {
+              self.log.error(err)
+              cb(err)
+            } else {
+              cb()
+            }
+          }
+          done(err)
+        })
       })
+      return
+    }
+
+    // promise style
+    return new Promise((resolve, reject) => {
+      self.shutdown((err, instance, done) => {
+        instance._onClose(() => {
+          if (err) {
+            self.log.error(err)
+            reject(err)
+          } else {
+            resolve()
+          }
+          done()
+        })
+      })
     })
@@ -1609,8 +1635,6 @@ }
    *
-   *
-   * @param {any} err
    * @param {any} cb
    * @memberof Hemera
    */
-  _onClose(err, cb) {
+  _onClose(cb) {
     const self = this
@@ -1626,10 +1650,4 @@ // remove all active subscriptions
       self._transport.close()
-
-      if (err) {
-        self.log.error(err)
-        self.emit('error', err)
-      }
-
       if (_.isFunction(cb)) {
-        cb(err)
+        cb()
       }
@@ -1636,0 +1654,0 @@ })

package.json

 {
   "name": "nats-hemera",
   "author": "Dustin Deus (https://github.com/StarpTech)",
-  "version": "3.3.0",
+  "version": "3.4.0",
   "main": "lib/index.js",
@@ -6,0 +6,0 @@ "homepage": "https://hemerajs.github.io/hemera/",

No alert changes

Improved metrics

Total package byte prevSize

74432

increased by0.59%

Lines of code

2882

increased by0.63%

No dependency changes