next-biz-date - npm Package Compare versions

Comparing version 1.0.5 to 1.0.6

package.json

 {
   "name": "next-biz-date",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "Returns the next business date (future or past based on direction as FORWARD or BACKWARDS) for a given reference date (initialDate), offset value, direction and given array of holidays",
@@ -5,0 +5,0 @@ "main": "main.js",

test/tests.js

@@ -13,3 +13,6 @@ const assert = require("assert");
 
-describe("FindBizDate", () => {
+describe("findBizDate(candidateDate, holidaysArray, direction)", () => {
+  
+  console.log("HOLIDAYS: ", holidays);
+  
   it("Should Find Biz Date based on CandidateDate", () => {
@@ -36,14 +39,12 @@
     ];
-
-    console.log("TEST:", {happyPathCases, holidays});
-
+    
     let results = [];
 
-    happyPathCases.forEach((item, i) => {
-      let candidateDate = moment(item.candidateDate);
-      let resultDate = nbd.FindBizDate(candidateDate, holidays);
+    happyPathCases.forEach((caseItem, i) => {
+      let candidateDate = moment(caseItem.candidateDate);
+      let result = nbd.FindBizDate(candidateDate, holidays);
 
-      console.log("Testing", item, resultDate);
-      assert.equal(resultDate.isSame(moment(item.expectedResult)), true);
-      results.push({candidateDate, resultDate});
+      console.log("RESULT", caseItem, {result});
+      assert.equal(result.isSame(moment(caseItem.expectedResult)), true);
+      results.push({candidateDate, result});
     });
@@ -53,22 +54,22 @@ });
 
-describe("FindNextBizDate", () => {
+describe("findNextBizDate(baseDate, holidaysArray, offset, direction)", () => {
   it("Should be able to handle offset forward cases", () => {
     let forwardCases = [
-      {initialDate: "2020-12-19", offset: 0 /* SAT 12/19  w*/, expectedDate: "2020-12-21"},
-      {initialDate: "2020-12-19", offset: 1 /* SUN 12/20  w*/, expectedDate: "2020-12-21"},
-      {initialDate: "2020-12-19", offset: 2 /* MON 12/21  b*/, expectedDate: "2020-12-21"},
-      {initialDate: "2020-12-19", offset: 3 /* TUE 12/22  b*/, expectedDate: "2020-12-22"},
-      {initialDate: "2020-12-19", offset: 4 /* WED 12/23  b*/, expectedDate: "2020-12-23"},
-      {initialDate: "2020-12-19", offset: 5 /* THU 12/24  b*/, expectedDate: "2020-12-24"},
-      {initialDate: "2020-12-19", offset: 6 /* FRI 12/25  h*/, expectedDate: "2020-12-29"},
-      {initialDate: "2020-12-19", offset: 7 /* SAT 12/26  w*/, expectedDate: "2020-12-29"},
-      {initialDate: "2020-12-19", offset: 8 /* SUN 12/27  w*/, expectedDate: "2020-12-29"},
-      {initialDate: "2020-12-19", offset: 9 /* MON 12/28  h*/, expectedDate: "2020-12-29"},
-      {initialDate: "2020-12-19", offset: 10 /*TUE 12/29  b*/, expectedDate: "2020-12-29"}
+      {baseDate: "2020-12-19", offset: 0 /* SAT 12/19  w*/, expectedResult: "2020-12-21"},
+      {baseDate: "2020-12-19", offset: 1 /* SUN 12/20  w*/, expectedResult: "2020-12-21"},
+      {baseDate: "2020-12-19", offset: 2 /* MON 12/21  b*/, expectedResult: "2020-12-21"},
+      {baseDate: "2020-12-19", offset: 3 /* TUE 12/22  b*/, expectedResult: "2020-12-22"},
+      {baseDate: "2020-12-19", offset: 4 /* WED 12/23  b*/, expectedResult: "2020-12-23"},
+      {baseDate: "2020-12-19", offset: 5 /* THU 12/24  b*/, expectedResult: "2020-12-24"},
+      {baseDate: "2020-12-19", offset: 6 /* FRI 12/25  h*/, expectedResult: "2020-12-29"},
+      {baseDate: "2020-12-19", offset: 7 /* SAT 12/26  w*/, expectedResult: "2020-12-29"},
+      {baseDate: "2020-12-19", offset: 8 /* SUN 12/27  w*/, expectedResult: "2020-12-29"},
+      {baseDate: "2020-12-19", offset: 9 /* MON 12/28  h*/, expectedResult: "2020-12-29"},
+      {baseDate: "2020-12-19", offset: 10 /*TUE 12/29  b*/, expectedResult: "2020-12-29"}
     ];
 
     forwardCases.forEach((caseItem, i) => {
-      let result = nbd.FindNextBizDate(caseItem.initialDate, holidays, caseItem.offset, "FORWARD");
-      console.log("RESULT", moment(caseItem.initialDate), caseItem.offset, moment(caseItem.expectedDate), result);
-      assert.equal(result.isSame(caseItem.expectedDate), true);
+      let result = nbd.FindNextBizDate(caseItem.baseDate, holidays, caseItem.offset, "FORWARD");
+      console.log("RESULT", caseItem, {result});
+      assert.equal(result.isSame(caseItem.expectedResult), true);
     });
@@ -79,19 +80,19 @@ });
     let backwardsCases = [
-      {initialDate: "2020-12-26", offset: 0 /*SAT 12/26  w*/, expectedDate: "2020-12-24"},
-      {initialDate: "2020-12-26", offset: 1 /*FRI 12/25  h*/, expectedDate: "2020-12-24"},
-      {initialDate: "2020-12-26", offset: 2 /*THU 12/24  b*/, expectedDate: "2020-12-24"},
-      {initialDate: "2020-12-26", offset: 3 /*WED 12/23  b*/, expectedDate: "2020-12-23"},
-      {initialDate: "2020-12-26", offset: 4 /*TUE 12/22  b*/, expectedDate: "2020-12-22"},
-      {initialDate: "2020-12-26", offset: 5 /*MON 12/21  b*/, expectedDate: "2020-12-21"},
-      {initialDate: "2020-12-26", offset: 6 /*SUN 12/20  w*/, expectedDate: "2020-12-18"},
-      {initialDate: "2020-12-26", offset: 7 /*SAT 12/19  w*/, expectedDate: "2020-12-18"},
-      {initialDate: "2020-12-26", offset: 8 /*FRI 12/18  b*/, expectedDate: "2020-12-18"},
-      {initialDate: "2020-12-26", offset: 9 /*THU 12/17  h*/, expectedDate: "2020-12-16"},
-      {initialDate: "2020-12-26", offset: 10 /*WED 12/16 b*/, expectedDate: "2020-12-16"}
+      {baseDate: "2020-12-26", offset: 0 /*SAT 12/26  w*/, expectedResult: "2020-12-24"},
+      {baseDate: "2020-12-26", offset: 1 /*FRI 12/25  h*/, expectedResult: "2020-12-24"},
+      {baseDate: "2020-12-26", offset: 2 /*THU 12/24  b*/, expectedResult: "2020-12-24"},
+      {baseDate: "2020-12-26", offset: 3 /*WED 12/23  b*/, expectedResult: "2020-12-23"},
+      {baseDate: "2020-12-26", offset: 4 /*TUE 12/22  b*/, expectedResult: "2020-12-22"},
+      {baseDate: "2020-12-26", offset: 5 /*MON 12/21  b*/, expectedResult: "2020-12-21"},
+      {baseDate: "2020-12-26", offset: 6 /*SUN 12/20  w*/, expectedResult: "2020-12-18"},
+      {baseDate: "2020-12-26", offset: 7 /*SAT 12/19  w*/, expectedResult: "2020-12-18"},
+      {baseDate: "2020-12-26", offset: 8 /*FRI 12/18  b*/, expectedResult: "2020-12-18"},
+      {baseDate: "2020-12-26", offset: 9 /*THU 12/17  h*/, expectedResult: "2020-12-16"},
+      {baseDate: "2020-12-26", offset: 10 /*WED 12/16 b*/, expectedResult: "2020-12-16"}
     ];
 
     backwardsCases.forEach((caseItem, i) => {
-      let result = nbd.FindNextBizDate(caseItem.initialDate, holidays, caseItem.offset, "BACKWARDS");
-      console.log("RESULT", moment(caseItem.initialDate), caseItem.offset, moment(caseItem.expectedDate), result);
-      assert.equal(result.isSame(caseItem.expectedDate), true);
+      let result = nbd.FindNextBizDate(caseItem.baseDate, holidays, caseItem.offset, "BACKWARDS");
+      console.log("RESULT", caseItem, {result});
+      assert.equal(result.isSame(caseItem.expectedResult), true);
     });
@@ -98,0 +99,0 @@ });

No alert changes

Worsened metrics

Total package byte prevSize

13838

decreased by-0.55%

No dependency changes