ng-test-utils - npm Package Compare versions

Comparing version 0.0.10 to 0.0.11

gulpfile.js

@@ -35,3 +35,4 @@ var gulp = require('gulp');
     .pipe(jshint())
-    .pipe(jshint.reporter('default'));
+    .pipe(jshint.reporter('default'))
+    .pipe(jshint.reporter('fail'));
 });
@@ -38,0 +39,0 @@

package.json

 {
   "name": "ng-test-utils",
-  "version": "0.0.10",
+  "version": "0.0.11",
   "description": "angular test utilities",
@@ -5,0 +5,0 @@ "main": "index.js",

Readme.md

@@ -183,4 +183,7 @@ ng-test-utils
 
-@ngConstant
+~~@ngConstant~~
 -----------
+**deprecated** - Angular constants can not be overridden, so this is pretty useless.
+Use providers for configurable application wide settings.
+
 Very similar to `@ngConstant`, but it provides a constant service. From the angular docs:
@@ -288,3 +291,3 @@
 // @ngProvider
-var myProvider = {
+var greetProvider = {
   name: "world",
@@ -298,7 +301,7 @@ $get: function(a) {
 
-var myProvider;
+var greetProvider;
 
 beforeEach(function() {
   angular.mock.module(function($provide) {
-    myProvider = {
+    greetProvider = {
       name: "world",
@@ -310,3 +313,3 @@ $get: function(a) {
 
-    $provide.provider("myProvider", myProvider);
+    $provide.provider("greet", myProvider);
   });
@@ -316,2 +319,14 @@ });
 
+Note that if your variable name has a "Provider" suffix, it will be stripped off when
+creating the name for the service. This allows you to avoid naming collisions when
+your tests need access to both the provider and the provided instance:
+
+```javascript
+// @ngProvider
+function greetProvider() { /* ... */ }
+
+// @ngInject
+var greet;
+```
+
 @ngDirective
@@ -318,0 +333,0 @@ ------------

src/index.js

@@ -18,3 +18,11 @@ 'use strict';
 var ngProvider = require('./ngProvide')(
-  'provider', /^\s*@ngProvider\s*$/, require('./silent-logger')
+  'provider',
+  /^\s*@ngProvider\s*$/,
+  require('./silent-logger'),
+  null,
+  function(name) {
+    var returnValue =  name.replace(/Provider$/, '').toString();
+    console.log(name + ' replaced with ' + returnValue);
+    return returnValue;
+  }
 );
@@ -21,0 +29,0 @@

src/ngProvide.js

@@ -14,6 +14,9 @@ 'use strict';
 
-function createInjector (type, regexp, logger, requiredProvider) {
+function identity(val) {return val;}
+
+function createInjector (type, regexp, logger, requiredProvider, rename) {
   assert(typeof type === 'string', 'type must be a string');
   assert(regexp, 'regexp required');
   requiredProvider = requiredProvider || '$provide';
+  rename = rename || identity;
 
@@ -102,5 +105,8 @@ var hasNgProvideAnnotation = hasAnnotation(regexp);
 
-      provides.push(
-        s.provide(types[i], b.literal(ids[i].name), ids[i], requiredProvider)
-      );
+      provides.push(s.provide(
+        types[i],
+        b.literal(rename(ids[i].name)),
+        ids[i],
+        requiredProvider
+      ));
     }
@@ -107,0 +113,0 @@

No alert changes

Improved metrics

Total package byte prevSize

35238

increased by2.37%

Lines of code

713

increased by2%

Number of lines in readme file

391

increased by3.99%

No dependency changes