nice-grpc - npm Package Compare versions

Comparing version 0.1.0 to 0.1.1

lib/server/createErrorStatusObject.js

@@ -5,5 +5,6 @@ "use strict";
 const grpc_js_1 = require("@grpc/grpc-js");
+const abort_controller_x_1 = require("abort-controller-x");
 const ServerError_1 = require("./ServerError");
 /** @internal */
-function createErrorStatusObject(error, trailer) {
+function createErrorStatusObject(path, error, trailer) {
     if (error instanceof ServerError_1.ServerError) {
@@ -16,4 +17,11 @@ return {
     }
+    else if (abort_controller_x_1.isAbortError(error)) {
+        return {
+            code: grpc_js_1.status.CANCELLED,
+            details: 'The operation was cancelled',
+            metadata: trailer,
+        };
+    }
     else {
-        // TODO: warning
+        process.emitWarning(`${path}: Uncaught error in server implementation method: ${error instanceof Error ? error.stack : error}`);
         return {
@@ -20,0 +28,0 @@ code: grpc_js_1.status.UNKNOWN,

lib/server/handleBidiStreamingCall.js

@@ -51,3 +51,3 @@ "use strict";
         }, err => {
-            call.destroy(createErrorStatusObject_1.createErrorStatusObject(err, context.trailer));
+            call.destroy(createErrorStatusObject_1.createErrorStatusObject(definition.path, err, context.trailer));
         });
@@ -54,0 +54,0 @@ };

lib/server/handleClientStreamingCall.js

@@ -43,3 +43,3 @@ "use strict";
         }, err => {
-            callback(createErrorStatusObject_1.createErrorStatusObject(err, context.trailer));
+            callback(createErrorStatusObject_1.createErrorStatusObject(definition.path, err, context.trailer));
         });
@@ -46,0 +46,0 @@ };

lib/server/handleServerStreamingCall.js

@@ -50,3 +50,3 @@ "use strict";
         }, err => {
-            call.destroy(createErrorStatusObject_1.createErrorStatusObject(err, context.trailer));
+            call.destroy(createErrorStatusObject_1.createErrorStatusObject(definition.path, err, context.trailer));
         });
@@ -53,0 +53,0 @@ };

lib/server/handleUnaryCall.js

@@ -42,3 +42,3 @@ "use strict";
         }, err => {
-            callback(createErrorStatusObject_1.createErrorStatusObject(err, context.trailer));
+            callback(createErrorStatusObject_1.createErrorStatusObject(definition.path, err, context.trailer));
         });
@@ -45,0 +45,0 @@ };

package.json

 {
   "name": "nice-grpc",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "A gRPC library that is nice to you",
@@ -27,3 +27,3 @@ "keywords": [
   },
-  "author": "Daniel Lytkin <[e-mail]>",
+  "author": "Daniel Lytkin <[e-mail]>",
   "license": "MIT",
@@ -30,0 +30,0 @@ "devDependencies": {

README.md

@@ -1,2 +0,2 @@
-# nice-grpc
+# nice-grpc [![npm version][npm-image]][npm-url]
 
@@ -44,5 +44,6 @@ A Node.js gRPC library that is nice to you. Built on top of
 - Modern API that uses Promises and Async Iterables for streaming.
-- Canceling client and server calls using
+- Cancelling client and server calls using
   [`AbortSignal`](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal).
-- Client and server middleware via concise API that uses Async Generators.
+- Client and server middleware support via concise API that uses Async
+  Generators.
 
@@ -52,3 +53,3 @@ ## Installation
 ```
-npm install nice-grpc google-protobuf
+npm install nice-grpc google-protobuf @grpc/grpc-js
 npm install --save-dev @types/google-protobuf
@@ -818,3 +819,4 @@ ```
 
-Support specifying timeouts for unary calls instead of absolute deadlines:
+Add support for specifying timeouts for unary calls instead of absolute
+deadlines:
 
@@ -869,1 +871,4 @@ ```ts
 ```
+
+[npm-image]: https://badge.fury.io/js/nice-grpc.svg
+[npm-url]: https://badge.fury.io/js/nice-grpc

src/server/createErrorStatusObject.ts

 import {Metadata, status, StatusObject} from '@grpc/grpc-js';
+import {isAbortError} from 'abort-controller-x';
 import {ServerError} from './ServerError';
@@ -6,2 +7,3 @@
 export function createErrorStatusObject(
+  path: string,
   error: unknown,
@@ -16,4 +18,15 @@ trailer: Metadata,
     };
+  } else if (isAbortError(error)) {
+    return {
+      code: status.CANCELLED,
+      details: 'The operation was cancelled',
+      metadata: trailer,
+    };
   } else {
-    // TODO: warning
+    process.emitWarning(
+      `${path}: Uncaught error in server implementation method: ${
+        error instanceof Error ? error.stack : error
+      }`,
+    );
+
     return {
@@ -20,0 +33,0 @@ code: status.UNKNOWN,

src/server/handleBidiStreamingCall.ts

@@ -77,3 +77,9 @@ import {handleBidiStreamingCall, MethodDefinition} from '@grpc/grpc-js';
         err => {
-          call.destroy(createErrorStatusObject(err, context.trailer) as any);
+          call.destroy(
+            createErrorStatusObject(
+              definition.path,
+              err,
+              context.trailer,
+            ) as any,
+          );
         },
@@ -80,0 +86,0 @@ );

src/server/handleClientStreamingCall.ts

@@ -72,3 +72,5 @@ import {handleClientStreamingCall, MethodDefinition} from '@grpc/grpc-js';
         err => {
-          callback(createErrorStatusObject(err, context.trailer));
+          callback(
+            createErrorStatusObject(definition.path, err, context.trailer),
+          );
         },
@@ -75,0 +77,0 @@ );

src/server/handleServerStreamingCall.ts

@@ -76,3 +76,9 @@ import {handleServerStreamingCall, MethodDefinition} from '@grpc/grpc-js';
         err => {
-          call.destroy(createErrorStatusObject(err, context.trailer) as any);
+          call.destroy(
+            createErrorStatusObject(
+              definition.path,
+              err,
+              context.trailer,
+            ) as any,
+          );
         },
@@ -79,0 +85,0 @@ );

src/server/handleUnaryCall.ts

@@ -14,6 +14,3 @@ import {handleUnaryCall, MethodDefinition} from '@grpc/grpc-js';
 ): handleUnaryCall<Request, Response> {
-  async function* unaryMethodHandler(
-    request: Request,
-    context: CallContext,
-  ) {
+  async function* unaryMethodHandler(request: Request, context: CallContext) {
     if (isAsyncIterable(request)) {
@@ -72,3 +69,5 @@ throw new Error(
         err => {
-          callback(createErrorStatusObject(err, context.trailer));
+          callback(
+            createErrorStatusObject(definition.path, err, context.trailer),
+          );
         },
@@ -75,0 +74,0 @@ );

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Native code

Supply chain risk

Contains native code (e.g., compiled binaries or shared libraries). Including native code can obscure malicious behavior.

Found 1 instance in 1 package

Improved metrics

Lines of code

2834

increased by1.18%

Number of lines in readme file

871

increased by0.58%

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

158203

decreased by-2.79%

Number of package files

115

decreased by-0.86%

No dependency changes