no-kafka - npm Package Compare versions

Comparing version 2.2.1 to 2.2.2

consumer.js

@@ -8,3 +8,3 @@ 'use strict';
 var consumer = new Kafka.SimpleConsumer({
-    idleTimeout: 100,
+    idleTimeout: 100
 });
@@ -11,0 +11,0 @@

lib/base_consumer.js

@@ -83,5 +83,5 @@ 'use strict';
     .then(function () {
-        return Promise.delay(self.options.idleTimeout).then(function () {
-            return self._fetch();
-        });
+        self._fetchTimeout = setTimeout(function () {
+            self._fetchPromise = self._fetch();
+        }, self.options.idleTimeout);
     });
@@ -275,4 +275,5 @@ };
     self._fetchPromise.cancel();
+    clearTimeout(self._fetchTimeout);
 
     return self.client.end();
 };

lib/errors.js

@@ -5,3 +5,2 @@ 'use strict';
 
-/* jshint maxlen: 350 */
 /* eslint max-len: [2, 350, 4] */
@@ -44,3 +43,3 @@
 function KafkaError(code, message) {
-    Error.captureStackTrace(this, this.constructor);
+    // Error.captureStackTrace(this, this.constructor);
 
@@ -47,0 +46,0 @@ this.name = this.constructor.name;

lib/group_consumer.js

@@ -208,5 +208,5 @@ 'use strict';
     .tap(function () {
-        return Promise.delay(self.options.heartbeatTimeout).then(function () {
-            return self._heartbeat();
-        });
+        self._heartbeatTimeout = setTimeout(function () {
+            self._heartbeatPromise = self._heartbeat();
+        }, self.options.heartbeatTimeout);
     })
@@ -234,2 +234,3 @@ .catch(function (err) {
     self._heartbeatPromise.cancel();
+    clearTimeout(self._heartbeatTimeout);
 
@@ -236,0 +237,0 @@ return self.client.leaveGroupRequest(self.options.groupId, self.memberId)

package.json

@@ -9,3 +9,3 @@ {
   },
-  "version": "2.2.1",
+  "version": "2.2.2",
   "main": "./lib/index.js",
@@ -12,0 +12,0 @@ "keywords": [

README.md

@@ -18,2 +18,3 @@ [![Build Status][badge-travis]][travis]
   * [Keyed Messages](#keyed-messages)
+  * [Batching (grouping) produce requests](#batching-grouping-produce-requests)
   * [Producer options](#producer-options)
@@ -82,2 +83,4 @@ * [Simple Consumer](#simpleconsumer)
 
+### Batching (grouping) produce requests
+
 Accumulate messages into single batch until their total size is >= 1024 bytes or 100ms timeout expires (overwrite Producer constructor options):
@@ -121,8 +124,2 @@
 
-Send message with Snappy compression:
-
-```javascript
-return producer.send(messages, { codec: Kafka.COMPRESSION_SNAPPY });
-```
-
 ### Keyed Messages
@@ -129,0 +126,0 @@

No alert changes

Improved metrics

Lines of code

4429

increased by0.02%

Worsened metrics

Total package byte prevSize

229168

decreased by-1.46%

Number of lines in readme file

518

decreased by-0.58%

No dependency changes