no-kafka - npm Package Compare versions

Comparing version 3.1.3-0 to 3.1.4

lib/group_consumer.js

@@ -296,2 +296,4 @@ 'use strict';
 
+    // should probably wait for current fetch/handlers to finish before fetching offsets and re-subscribing
+
     _.each(partitionAssignment, function (a) {
@@ -298,0 +300,0 @@ _.each(a.partitions, function (p) {

lib/protocol/admin.js

@@ -54,9 +54,7 @@ 'use strict';
             .string('clientHost')
-            .Int32BE('_metadataLength');
-        if (this.context._metadataLength) {
-            this.Int16BE('version')
-                .array('subscriptions', this.string)
-                .bytes('metadata')
-                .SyncConsumerGroupRequest_MemberAssignment('memberAssignment');
-        }
+            .skip(4) // metadata bytes length
+            .Int16BE('version')
+            .array('subscriptions', this.string)
+            .bytes('metadata')
+            .SyncConsumerGroupRequest_MemberAssignment('memberAssignment');
     }
@@ -63,0 +61,0 @@ });

package.json

@@ -9,4 +9,5 @@ {
   },
-  "version": "3.1.3-0",
+  "version": "3.1.4",
   "main": "./lib/index.js",
+  "types": "./types/index.d.ts",
   "keywords": [
@@ -23,3 +24,6 @@ "kafka"
     "nice-simple-logger": "^1.0.1",
-    "wrr-pool": "^1.0.3"
+    "wrr-pool": "^1.0.3",
+    "@types/lodash": "^4.14.55",
+    "@types/bluebird": "3.5.0",
+    "typescript": "2.2.1"
   },
@@ -29,4 +33,5 @@ "devDependencies": {
     "chai-as-promised": "^6.0.0",
-    "eslint": "^2.2.0",
+    "eslint": "^2.13.1",
     "eslint-config-magictoolbox": "^0.0.2",
+    "eslint-plugin-react": "^6.10.3",
     "istanbul": "^0.4.2",
@@ -33,0 +38,0 @@ "mocha": "^3.1.2",

README.md

@@ -340,3 +340,2 @@ [![Build Status][badge-travis]][travis]
 var strategies = {
-    strategy: 'TestStrategy',
     subscriptions: ['kafka-test-topic'],
@@ -343,0 +342,0 @@ metadata: {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Number of package files

78

increased by27.87%

Lines of code

5832

increased by17.37%

Number of low quality alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

341889

decreased by-96.83%

Dependency count

11

increased by37.5%

Dev dependency count

10

increased by11.11%

Number of lines in readme file

675

decreased by-0.15%

Dependency changes

• + Added@types/bluebird@3.5.0

• + Added@types/lodash@^4.14.55

• + Addedtypescript@2.2.1

• + Added@types/bluebird@3.5.0(transitive)

• + Added@types/lodash@4.17.13(transitive)

• + Addedtypescript@2.2.1(transitive)