node-gyp - npm Package Compare versions

Comparing version 0.4.0 to 0.4.1

bin/node-gyp.js

@@ -116,3 +116,3 @@ #!/usr/bin/env node
     }
-    if (prog.command == 'list') {
+    if (command == 'list') {
       var versions = arguments[1]
@@ -119,0 +119,0 @@ if (versions.length > 0) {

lib/install.js

@@ -109,3 +109,3 @@
 
-  function download(url,onError) {
+  function download (url, onError) {
     gyp.info('downloading:', url)
@@ -263,31 +263,37 @@ var requestOpts = {
         if (err) return done(err)
-        var res = download(nodeLibUrl32, function (err, _res) {
-          if (err || _res.statusCode !== 200) {
-             return done(err || new Error(res.statusCode + ' status code downloading 32-bit node.lib'))
+        gyp.verbose('streaming 32-bit node.lib to:', nodeLibPath32)
+
+        var req = download(nodeLibUrl32)
+        req.on('error', done)
+        req.on('response', function (res) {
+          if (res.statusCode !== 200) {
+            done(new Error(res.statusCode + ' status code downloading 32-bit node.lib'))
           }
-          gyp.verbose('streaming 32-bit node.lib to:', nodeLibPath32)
-          var ws = fs.createWriteStream(nodeLibPath32)
-          ws.on('error', cb)
-          res.pipe(ws)
-          res.on('end', function () {
-            --async || done()
-          })
         })
-        res.on('error', done)
+        req.on('end', function () {
+          --async || done()
+        })
+
+        var ws = fs.createWriteStream(nodeLibPath32)
+        ws.on('error', cb)
+        req.pipe(ws)
       })
       mkdir(dir64, function (err) {
         if (err) return done(err)
-        var res = download(nodeLibUrl64, function (err, _res) {
-          if (err || _res.statusCode !== 200) {
-             return done(err || new Error(res.statusCode + ' status code downloading 64-bit node.lib'))
+        gyp.verbose('streaming 64-bit node.lib to:', nodeLibPath64)
+
+        var req = download(nodeLibUrl64)
+        req.on('error', done)
+        req.on('response', function (res) {
+          if (res.statusCode !== 200) {
+            done(new Error(res.statusCode + ' status code downloading 64-bit node.lib'))
           }
-          gyp.verbose('streaming 64-bit node.lib to:', nodeLibPath64)
-          var ws = fs.createWriteStream(nodeLibPath64)
-          ws.on('error', cb)
-          res.pipe(ws)
-          res.on('end', function () {
-            --async || done()
-          })
         })
-        res.on('error', done)
+        req.on('end', function () {
+          --async || done()
+        })
+
+        var ws = fs.createWriteStream(nodeLibPath64)
+        ws.on('error', cb)
+        req.pipe(ws)
       })
@@ -294,0 +300,0 @@ }

package.json

 { "name": "node-gyp"
 , "description": "Node.js native addon build tool"
 , "keywords": [ "native", "addon", "module", "c", "c++", "bindings", "gyp" ]
-, "version": "0.4.0"
+, "version": "0.4.1"
 , "installVersion": 7
@@ -6,0 +6,0 @@ , "author": "Nathan Rajlich <[e-mail]> (http://tootallnate.net)"

No alert changes

Improved metrics

Lines of code

1059

increased by0.19%

Worsened metrics

Total package byte prevSize

913076

No dependency changes