node-gyp - npm Package Compare versions

Comparing version 1.0.3 to 2.0.0

lib/build.js

@@ -153,3 +153,3 @@
       ;(function verifyMsbuild () {
-        if (!msbuilds.length) return callback(notfoundErr);
+        if (!msbuilds.length) return callback(notfoundErr)
         msbuildPath = path.resolve(msbuilds.pop().path, 'msbuild.exe')
@@ -156,0 +156,0 @@ fs.stat(msbuildPath, function (err, stat) {

lib/configure.js

@@ -16,2 +16,3 @@ module.exports = exports = configure
   , cp = require('child_process')
+  , PathArray = require('path-array')
   , extend = require('util')._extend
@@ -26,3 +27,3 @@ , spawn = cp.spawn
 
-  var python = gyp.opts.python || process.env.PYTHON || 'python'
+  var python = gyp.opts.python || process.env.PYTHON || 'python2'
     , buildDir = path.resolve('build')
@@ -41,2 +42,6 @@ , configNames = [ 'config.gypi', 'common.gypi' ]
         log.verbose('`which` failed', python, err)
+        if (python === 'python2') {
+          python = 'python'
+          return checkPython()
+        }
         if (win) {
@@ -79,4 +84,4 @@ guessPython()
   function checkPythonVersion () {
-    var env = extend({}, process.env);
-    env.TERM = 'dumb';
+    var env = extend({}, process.env)
+    env.TERM = 'dumb'
 
@@ -335,3 +340,4 @@ execFile(python, ['-c', 'import platform; print(platform.python_version());'], { env: env }, function (err, stdout) {
     // make sure python uses files that came with this particular node package
-    process.env.PYTHONPATH = path.resolve(__dirname, '..', 'gyp', 'pylib')
+    var pypath = new PathArray(process.env, 'PYTHONPATH')
+    pypath.unshift(path.join(__dirname, '..', 'gyp', 'pylib'))
 
@@ -338,0 +344,0 @@ var cp = gyp.spawn(python, argv)

lib/install.js

@@ -233,2 +233,7 @@
       req.on('error', function (err) {
+        if (err.code === 'ENOTFOUND') {
+          return cb(new Error('This is most likely not a problem with node-gyp or the package itself and\n' +
+            'is related to network connectivity. In most cases you are behind a proxy or have bad \n' +
+            'network settings.'))
+        }
         badDownload = true
@@ -247,3 +252,3 @@ cb(err)
           badDownload = true
-          cb(new Error(res.statusCode + ' status code downloading tarball'))
+          cb(new Error(res.statusCode + ' response dowloading ' + tarballUrl))
           return
@@ -282,5 +287,8 @@ }
 
-        // download SHASUMS.txt
-        async++
-        downloadShasums(deref)
+        // Only download SHASUMS.txt if not using tarPath override
+        if (!tarPath) {
+          // download SHASUMS.txt
+          async++
+          downloadShasums(deref)
+        }
 
@@ -287,0 +295,0 @@ if (async === 0) {

lib/rebuild.js

@@ -6,4 +6,2 @@
 
-var log = require('npmlog')
-
 function rebuild (gyp, argv, callback) {
@@ -10,0 +8,0 @@

package.json

 {
   "name": "node-gyp",
   "description": "Node.js native addon build tool",
+  "license": "MIT",
   "keywords": [
@@ -13,3 +14,3 @@ "native",
   ],
-  "version": "1.0.3",
+  "version": "2.0.0",
   "installVersion": 9,
@@ -33,2 +34,3 @@ "author": "Nathan Rajlich <[e-mail]> (http://tootallnate.net)",
     "osenv": "0",
+    "path-array": "^1.0.0",
     "request": "2",
@@ -35,0 +37,0 @@ "rimraf": "2",

README.md

@@ -41,10 +41,19 @@ node-gyp
     * [Python][windows-python] ([`v2.7.3`][windows-python-v2.7.3] recommended, `v3.x.x` is __*not*__ supported)
+      * Make sure that you have a PYTHON environment variable, and it is set to drive:\path\to\python.exe not to a folder.
     * Windows XP/Vista/7:
       * Microsoft Visual Studio C++ 2010 ([Express][msvc2010] version works well)
-      * For 64-bit builds of node and native modules you will _**also**_ need the [Windows 7 64-bit SDK][win7sdk]
         * If the install fails, try uninstalling any C++ 2010 x64&x86 Redistributable that you have installed first.
-      * If you get errors that the 64-bit compilers are not installed you may also need the [compiler update for the Windows SDK 7.1]
+        * If you get errors that the 64-bit compilers are not installed you may also need the [compiler update for the Windows SDK 7.1]
     * Windows 7/8:
-      * Microsoft Visual Studio C++ 2012/13 for Windows Desktop ([Express][msvc2012] version works well)
+      * Microsoft Visual Studio C++ 2012 for Windows Desktop ([Express][msvc2012] version works well)
+      * Microsoft Visual Studio C++ 2013 will also work.
+    * All Windows Versions
+      * For 64-bit builds of node and native modules you will _**also**_ need the [Windows 7 64-bit SDK][win7sdk]
+      * You may need to run one of the following commands if your build complains about WindowsSDKDir not being set, and you are sure you have already installed the SDK:
 
+```
+call "C:\Program Files\Microsoft SDKs\Windows\v7.1\bin\Setenv.cmd" /Release /x86
+call "C:\Program Files\Microsoft SDKs\Windows\v7.1\bin\Setenv.cmd" /Release /x64
+```
+
 If you have multiple Python versions installed, you can identify which Python
@@ -51,0 +60,0 @@ version `node-gyp` uses by setting the '--python' variable:

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1545267

increased by10.88%

Number of package files

95

increased by11.76%

Lines of code

1349

increased by2.2%

Number of lines in readme file

190

increased by4.97%

Worsened metrics

Dependency count

14

increased by7.69%

Dependency changes

• + Addedpath-array@^1.0.0

• + Addedarray-index@1.0.0(transitive)

• + Addedd@1.0.2(transitive)

• + Addeddebug@2.6.9(transitive)

• + Addedes5-ext@0.10.64(transitive)

• + Addedes6-iterator@2.0.3(transitive)

• + Addedes6-symbol@3.1.4(transitive)

• + Addedesniff@2.0.1(transitive)

• + Addedevent-emitter@0.3.5(transitive)

• + Addedext@1.7.0(transitive)

• + Addedms@2.0.0(transitive)

• + Addednext-tick@1.1.0(transitive)

• + Addedpath-array@1.0.1(transitive)

• + Addedtype@2.7.3(transitive)