node-macaddress - npm Package Compare versions

Comparing version 0.1.0 to 0.1.1

lib/linux.js

@@ -9,4 +9,4 @@ var exec = require('child_process').exec;
         }
-        callback(null, out.trim());
+        callback(null, out.trim().toLowerCase());
     });
 };

lib/macosx.js

@@ -14,4 +14,4 @@ var exec = require('child_process').exec;
         }
-        callback(null, match[0]);
+        callback(null, match[0].toLowerCase());
     });
 };

lib/unix.js

@@ -9,3 +9,3 @@ var exec = require('child_process').exec;
         }
-        var match = /[a-f0-9]{2}(:[a-f0-9]{2}){5}/.exec(out);
+        var match = /[a-f0-9]{2}(:[a-f0-9]{2}){5}/.exec(out.toLowerCase());
         if (!match) {
@@ -15,4 +15,4 @@ callback("did not find a mac address", null);
         }
-        callback(null, match[0]);
+        callback(null, match[0].toLowerCase());
     });
 };

package.json

 {
   "name": "node-macaddress",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Get the MAC addresses (hardware addresses) of the hosts network interfaces.",
   "main": "index.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "node test.js"
   },
@@ -9,0 +9,0 @@ "repository": {

README.md

 node-macaddress
 ===============
 
+[![Build Status](https://travis-ci.org/scravy/node-macaddress.svg?branch=master)](https://travis-ci.org/scravy/node-macaddress)
+
 Retrieve MAC addresses in Linux, OS X, and Windows.
 
-A common misconception about MAC addresses is that every *host* has a MAC address,
-while a host may have multiple MAC addresses – since every network interface may
+A common misconception about MAC addresses is that every *host* had *one* MAC address,
+while a host may have *multiple* MAC addresses – since *every network interface* may
 have its own MAC address.
@@ -28,3 +30,3 @@
 ```JavaScript
-var macaddress = require('./index');
+var macaddress = require('node-macaddress');
 ```
@@ -31,0 +33,0 @@

test.js

@@ -1,5 +0,7 @@
-// vim set et sw=2 ts=2
 var macaddress = require('./index');
 
 macaddress.one(function (err, mac) {
+  if (err || !/[a-f0-9]{2}(:[a-f0-9]{2}){5}/.test(mac)) {
+    throw err || mac;
+  }
   console.log("Mac address for this host: %s", mac);  
@@ -9,2 +11,5 @@ });
 macaddress.all(function (err, all) {
+  if (err) {
+    throw err;
+  }
   console.log(JSON.stringify(all, null, 2));
@@ -11,0 +16,0 @@ });

Fixed alerts

No tests

Quality

Package does not have any tests. This is a strong signal of a poorly maintained or low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

8861

increased by4.94%

Number of package files

11

increased by10%

Lines of code

169

increased by3.05%

Number of low quality alerts

1

decreased by-50%

Number of lines in readme file

122

increased by1.67%

No dependency changes