node-red-contrib-sia-ultimate - npm Package Compare versions

Comparing version 1.0.4 to 1.0.5

CHANGELOG.md

@@ -11,2 +11,6 @@ # node-red-contrib-sia-ultimate
 <p>
+<b>Version 1.0.5</b> - December 2021<br/>
+- FIX: fix a possible crash if you have more than 1 server node with the same port.<br/>
+</p>
+<p>
 <b>Version 1.0.4</b> - December 2021<br/>
@@ -13,0 +17,0 @@ - FIX: a possible crash if the TCP/UDP port are already in use.<br/>

nodes/siaendpoint-config.js

@@ -401,14 +401,15 @@
             try {
-                servertcp = net.createServer(onClientConnectedTCP);
+                servertcp = net.createServer(onClientConnectedTCP(servertcp));
                 servertcp.listen(node.port, () => {
                     try {
                         let text = 'siaendpointConfig: SIA Server listening on IP-Adress (TCP): ' + servertcp.address().address || "" + ':' + servertcp.address().port;
-                        RED.log.info(text);    
+                        RED.log.info(text);
                     } catch (error) {
-                        RED.log.error("siaendpointConfig: Unable to listen to the TCP server: " + error.message);
+                        RED.log.error("siaendpointConfig: Unable to listen to the TCP server: " + error.message + " do you have another config node with the same port?");
+                        throw (error);
                     }
-                    
+
                 });
             } catch (error) {
-                RED.log.error("siaendpointConfig: Unable to instantiate the TCP server: " + error.message);
+                RED.log.error("siaendpointConfig: Unable to instantiate the TCP server: " + error.message + " do you have another config node with the same port?");
                 throw (error);
@@ -429,5 +430,6 @@ }
                         let text = 'siaendpointConfig: SIA Server listening on IP-Adress (UDP): ' + serverudp.address().address + ':' + serverudp.address().port;
-                        RED.log.info(text);                            
+                        RED.log.info(text);
                     } catch (error) {
                         RED.log.error("siaendpointConfig: Unable to listen to the UDP server: " + error.message);
+                        throw (error);
                     }
@@ -673,4 +675,3 @@ });
          */
-        function
-            onClientConnectedUDP(sock) {
+        function onClientConnectedUDP(sock) {
             // See https://nodejs.org/api/stream.html#stream_readable_setencoding_encoding
@@ -677,0 +678,0 @@ // sock.setEncoding(null);

package.json

 {
     "name": "node-red-contrib-sia-ultimate",
-    "version": "1.0.4",
+    "version": "1.0.5",
     "description": "Connect your SIA-DCS compatible alarm system to node-red. It works with Ajax System too.",
@@ -5,0 +5,0 @@ "author": "Supergiovane (https://github.com/Supergiovane)",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

120032

increased by0.23%

Lines of code

982

increased by0.1%

No dependency changes