node-red-contrib-ui_list - npm Package Compare versions

Comparing version 0.1.2 to 0.1.3

locales/en-US/ui_list.json

@@ -20,4 +20,7 @@ {
             "check" : "checkbox to send changed item"
+        },
+        "error": {
+            "no-group": "group not configured"
         }
     }
 }

locales/ja/ui_list.json

@@ -20,4 +20,7 @@ {
             "check" : "チェック状態が変化した要素を送信"
+        },
+        "error": {
+            "no-group": "グループが設定されていません"
         }
     }
 }

package.json

 {
     "name": "node-red-contrib-ui_list",
-    "version": "0.1.2",
+    "version": "0.1.3",
     "description": "Node-RED UI widget node for simple list",
@@ -5,0 +5,0 @@ "author" : "Hiroyasu Nishiyama",

README.md

@@ -15,2 +15,4 @@ node-red-contrib-ui_list
 
+*This node uses APIs that are supported from Node-RED 0.19 & Node-RED Dashboard 2.10.*
+
 Usage
@@ -17,0 +19,0 @@ -----

ui_list.js

@@ -24,2 +24,10 @@ /**
 
+    function checkConfig(node, conf) {
+        if (!conf || !conf.hasOwnProperty("group")) {
+            node.error(RED._("ui_list.error.no-group"));
+            return false;
+        }
+        return true;
+    }
+
     function HTML(config) {
@@ -79,30 +87,33 @@ var actionType = config.actionType;
             RED.nodes.createNode(this, config);
-            var html = HTML(config);
-            var done = ui.addWidget({
-                node: node,
-                width: config.width,
-                height: config.height,
-                format: html,
-                templateScope: "local",
-                group: config.group,
-                emitOnlyNewValues: false,
-                forwardInputMessages: false,
-                storeFrontEndInputAsState: false,
-                convertBack: function (value) {
-                    return value;
-                },
-                beforeEmit: function(msg, value) {
-                    return { msg: { items: value } };
-                },
-                beforeSend: function (msg, orig) {
-                    if (orig) {
-                        return orig.msg;
+            var done = null;
+            if (checkConfig(node, config)) {
+                var html = HTML(config);
+                done = ui.addWidget({
+                    node: node,
+                    width: config.width,
+                    height: config.height,
+                    format: html,
+                    templateScope: "local",
+                    group: config.group,
+                    emitOnlyNewValues: false,
+                    forwardInputMessages: false,
+                    storeFrontEndInputAsState: false,
+                    convertBack: function (value) {
+                        return value;
+                    },
+                    beforeEmit: function(msg, value) {
+                        return { msg: { items: value } };
+                    },
+                    beforeSend: function (msg, orig) {
+                        if (orig) {
+                            return orig.msg;
+                        }
+                    },
+                    initController: function($scope, events) {
+                        $scope.click = function(item) {
+                            $scope.send({payload: item});
+                        };
                     }
-                },
-                initController: function($scope, events) {
-                    $scope.click = function(item) {
-                        $scope.send({payload: item});
-                    };
-                }
-            });
+                });
+            }
         }
@@ -112,5 +123,9 @@ catch (e) {
         }
-        node.on("close", done);
+        node.on("close", function() {
+            if (done) {
+                done();
+            }
+        });
     }
     RED.nodes.registerType('ui_list', ListNode);
 };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

85480

increased by0.51%

Lines of code

174

increased by12.99%

Number of lines in readme file

47

increased by4.44%

No dependency changes