nodebb-plugin-newuser-approval - npm Package Compare versions

Comparing version 0.0.2 to 0.0.3

package.json

 {
   "name": "nodebb-plugin-newuser-approval",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "description": "A plugin for NodeBB to allow admins to approve new users.",
@@ -26,4 +26,4 @@ "main": "library.js",
   "nbbpm": {
-    "compatibility": "^0.6.0"
+    "compatibility": "^0.7.0"
   }
 }

public/templates/admin/plugins/script.js

 "use strict";
 
+var nonApprovedGroupName,
+    approvedGroupName;
+
+    socket.emit('admin.settings.get', {
+            hash: 'newuser-approval' }, function(err, values) { 
+                if (err) {
+                    console.log('Unable to load settings');
+                    
+                } else {
+                    nonApprovedGroupName = values.nonapprovedUserGroup;
+                    approvedGroupName = values.approvedUserGroup;
+                }
+
+    });
+
 require(['settings'], function(Settings) {
@@ -23,5 +38,3 @@ Settings.load('newuser-approval', $('.newuser-approval-settings'));
 $('#users-container').on('click', 'div[data-uid]', function() {
-    var uid = $(this).attr('data-uid'),
-        nonApprovedGroupName = $('#nonapprovedUserGroup').val(),
-        approvedGroupName = $('#approvedUserGroup').val();
+    var uid = $(this).attr('data-uid');
     socket.emit('admin.groups.join', { 
@@ -31,3 +44,3 @@ groupName: approvedGroupName,
             }, function(err, data) {
-                if (!err){
+                if (!err) {
                     socket.emit('admin.groups.leave', {
@@ -47,16 +60,26 @@ groupName: nonApprovedGroupName,
     $(window).on('action:ajaxify.end', function(event, data) {
-       var nonApprovedGroupName = $('#nonapprovedUserGroup').val();
-        socket.emit('admin.groups.get', nonApprovedGroupName, function(err, data) {
-            if (data.members.length > 0) {
-                for (var x = 0; x < data.members.length; x++) {
-                    var html = $('<div />')
-                        .attr('class', 'users-box')
-                        .append($('<div />').attr('class', 'user-image').attr('data-uid', data.members[x].uid)
-                        .attr('data-username', data.members[x].username).append($('<img />').attr('src', data.members[x].picture).attr('class', 'img-thumbnail user-selectable selection')))
-                        .append($('<a />').attr('href', '/user/'+data.members[x].username).attr( 'target', '_blank').html(data.members[x].username));
-                    $('#users-container').append(html);
-                }
-            }
+
+        socket.emit('admin.settings.get', {
+                hash: 'newuser-approval' }, function(err, values) { 
+                    if (err) {
+                        console.log('Unable to load settings');
+                        
+                    } else {
+                        socket.emit('admin.groups.get', values.nonapprovedUserGroup, function(err, data) {
+                            $('#users-container').empty();
+                            if (data.members.length > 0) {
+                                for (var x = 0; x < data.members.length; x++) {
+                                    var html = $('<div />')
+                                        .attr('class', 'users-box')
+                                        .append($('<div />').attr('class', 'user-image').attr('data-uid', data.members[x].uid)
+                                        .attr('data-username', data.members[x].username).append($('<img />').attr('src', data.members[x].picture).attr('class', 'img-thumbnail user-selectable selection')))
+                                        .append($('<a />').attr('href', '/user/'+data.members[x].username).attr( 'target', '_blank').html(data.members[x].username));
+                                    $('#users-container').append(html);
+                                }
+                            }
+                        });
+                    }
+
         });
     });
 });

No alert changes

Improved metrics

Total package byte prevSize

8588

increased by10.54%

Lines of code

143

increased by12.6%

No dependency changes