nodebb-plugin-poll - npm Package Compare versions

Comparing version 3.0.2 to 3.0.3

package.json

 {
   "name": "nodebb-plugin-poll",
-  "version": "3.0.2",
+  "version": "3.0.3",
   "description": "NodeBB Poll Plugin",
@@ -5,0 +5,0 @@ "main": "library.js",

public/js/poll/creator.js

@@ -64,15 +64,18 @@ 'use strict';
 	function composerBtnHandle(composer, textarea) {
-		require(['composer/controls'], function (controls) {
+		require(['composer/controls', 'alerts'], function (controls, alerts) {
 			var post = composer.posts[composer.active];
 			if (!post || !post.isMain || (isNaN(parseInt(post.cid, 10)) && isNaN(parseInt(post.pid, 10)))) {
-				return app.alertError('[[poll:error.not_main]]');
+				return alerts.error('[[poll:error.not_main]]');
 			}
 			if (parseInt(post.cid, 10) === 0) {
-				return app.alertError('[[error:category-not-selected]]');
+				return alerts.error('[[error:category-not-selected]]');
 			}
 
 			Poll.sockets.canCreate({ cid: post.cid, pid: post.pid }, function (err, canCreate) {
-				if (err || !canCreate) {
-					return app.alertError(err.message);
+				if (err) {
+					return alerts.error(err.message);
 				}
+				if (!canCreate) {
+					return alerts.error('[[error:no-privileges]]');
+				}
 
@@ -122,3 +125,3 @@ Poll.sockets.getConfig(null, function (err, config) {
 		if (poll.hasOwnProperty('info')) {
-			return app.alertError('Editing not implemented.');
+			return Poll.alertError('Editing not implemented');
 		}
@@ -125,0 +128,0 @@

public/js/poll/main.js

@@ -6,2 +6,8 @@ 'use strict';
 (function () {
+	window.Poll.alertError = function (message) {
+		require(['alerts'], function (alerts) {
+			alerts.error(message);
+		});
+	};
+
 	require('poll/serializer')(window.utils);
@@ -26,3 +32,3 @@ $(window).on('action:topic.loading', function () {
 				if (err) {
-					return app.alertError(err.message);
+					return Poll.alertError(err.message);
 				}
@@ -29,0 +35,0 @@ Poll.view.load(pollData);

public/js/poll/view.js

@@ -31,3 +31,3 @@ 'use strict';
 						if (err) {
-							return app.alertError(err.message);
+							return Poll.alertError(err.message);
 						}
@@ -62,3 +62,3 @@
 						if (err) {
-							return app.alertError(err.message);
+							return Poll.alertError(err.message);
 						}
@@ -83,3 +83,3 @@ view.showResultsPanel();
 					if (err) {
-						return app.alertError(err.message);
+						return Poll.alertError(err.message);
 					}
@@ -130,3 +130,3 @@ view.showResultsPanel();
 					if (err) {
-						return app.alertError(err.message);
+						return Poll.alertError(err.message);
 					}
@@ -133,0 +133,0 @@

New alerts

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

Fixed alerts

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

218502

increased by0.1%

Lines of code

2487

increased by0.32%

Worsened metrics

Number of low supply chain risk alerts

8

increased by14.29%

No dependency changes