nodebb-theme-harmony - npm Package Compare versions

Comparing version 1.2.74 to 1.2.75

package.json

 {
   "name": "nodebb-theme-harmony",
-  "version": "1.2.74",
+  "version": "1.2.75",
   "nbbpm": {
@@ -5,0 +5,0 @@ "compatibility": "^3.7.0"

public/harmony.js

@@ -257,18 +257,13 @@ 'use strict';
 		['notifications', 'chat'].forEach((type) => {
-			const countEl = document.querySelector(`[component="${type}/count"]`);
-			if (!countEl) {
+			const countEl = $(`nav.sidebar [component="${type}/count"]`).first();
+			if (!countEl.length) {
 				return;
 			}
-			const count = parseInt(countEl.innerText, 10);
+			const count = parseInt(countEl.text(), 10);
 			if (count > 1) {
-				const listEls = document.querySelectorAll(`[component="${type}/list"]`);
-				listEls.forEach((listEl) => {
-					const placeholder = listEl.querySelector('*');
-					if (placeholder) {
-						for (let x = 0; x < count - 1; x++) {
-							const cloneEl = placeholder.cloneNode(true);
-							listEl.insertBefore(cloneEl, placeholder);
-						}
-					}
-				});
+				const placeholder = $(`nav.sidebar [component="${type}/list"]`).children().first();
+				for (let x = 0; x < count - 1; x++) {
+					const cloneEl = placeholder.clone(true);
+					cloneEl.insertAfter(placeholder);
+				}
 			}
@@ -275,0 +270,0 @@ });

No alert changes

Worsened metrics

Total package byte prevSize

1335903

decreased by-0.01%

Lines of code

523

decreased by-0.95%

No dependency changes