nx - npm Package Compare versions

Comparing version 0.0.0-pr-28808-6acf6c6 to 0.0.0-pr-28808-a9a1b13

package.json

 {
   "name": "nx",
-  "version": "0.0.0-pr-28808-6acf6c6",
+  "version": "0.0.0-pr-28808-a9a1b13",
   "private": false,
@@ -83,12 +83,12 @@ "description": "The core Nx plugin contains the core functionality of Nx like the project graph, nx commands and task orchestration.",
   "optionalDependencies": {
-    "@nx/nx-darwin-x64": "0.0.0-pr-28808-6acf6c6",
-    "@nx/nx-darwin-arm64": "0.0.0-pr-28808-6acf6c6",
-    "@nx/nx-linux-x64-gnu": "0.0.0-pr-28808-6acf6c6",
-    "@nx/nx-linux-x64-musl": "0.0.0-pr-28808-6acf6c6",
-    "@nx/nx-win32-x64-msvc": "0.0.0-pr-28808-6acf6c6",
-    "@nx/nx-linux-arm64-gnu": "0.0.0-pr-28808-6acf6c6",
-    "@nx/nx-linux-arm64-musl": "0.0.0-pr-28808-6acf6c6",
-    "@nx/nx-linux-arm-gnueabihf": "0.0.0-pr-28808-6acf6c6",
-    "@nx/nx-win32-arm64-msvc": "0.0.0-pr-28808-6acf6c6",
-    "@nx/nx-freebsd-x64": "0.0.0-pr-28808-6acf6c6"
+    "@nx/nx-darwin-x64": "0.0.0-pr-28808-a9a1b13",
+    "@nx/nx-darwin-arm64": "0.0.0-pr-28808-a9a1b13",
+    "@nx/nx-linux-x64-gnu": "0.0.0-pr-28808-a9a1b13",
+    "@nx/nx-linux-x64-musl": "0.0.0-pr-28808-a9a1b13",
+    "@nx/nx-win32-x64-msvc": "0.0.0-pr-28808-a9a1b13",
+    "@nx/nx-linux-arm64-gnu": "0.0.0-pr-28808-a9a1b13",
+    "@nx/nx-linux-arm64-musl": "0.0.0-pr-28808-a9a1b13",
+    "@nx/nx-linux-arm-gnueabihf": "0.0.0-pr-28808-a9a1b13",
+    "@nx/nx-win32-arm64-msvc": "0.0.0-pr-28808-a9a1b13",
+    "@nx/nx-freebsd-x64": "0.0.0-pr-28808-a9a1b13"
   },
@@ -95,0 +95,0 @@ "nx-migrations": {

release/changelog-renderer/index.js

@@ -264,3 +264,3 @@ "use strict";
         if (authors.length > 0) {
-            markdownLines.push('', '### ' + '❤️  Thank You', '', ...authors
+            markdownLines.push('', '### ' + '❤️ Thank You', '', ...authors
                 .sort((a, b) => a.name.localeCompare(b.name))
@@ -267,0 +267,0 @@ .map((i) => {

src/daemon/tmp-dir.js

@@ -46,3 +46,3 @@ "use strict";
     hasher.update(workspace_root_1.workspaceRoot.toLowerCase());
-    const unique = hasher.digest('hex').substring(0, 20);
+    const unique = hasher.digest('hex').substring(0, 10);
     return (0, path_1.join)(tmp_1.tmpdir, unique);
@@ -49,0 +49,0 @@ }

src/project-graph/plugins/isolation/plugin-pool.js

@@ -15,3 +15,11 @@ "use strict";
 const MAX_MESSAGE_WAIT = process.env.NX_PLUGIN_NO_TIMEOUTS === 'true'
-    ? undefined
+    ? // Registering a timeout prevents the process from exiting
+        // if the call to a plugin happens to be the only thing
+        // keeping the process alive. As such, even if timeouts are disabled
+        // we need to register one. 2147483647 is the max timeout
+        // that Node.js allows, and is equivalent to 24.8 days....
+        // This does mean that the NX_PLUGIN_NO_TIMEOUTS env var
+        // would still timeout after 24.8 days, but that seems
+        // like a reasonable compromise.
+        2147483647
     : 1000 * 60 * MINUTES; // 10 minutes
@@ -39,7 +47,5 @@ const nxPluginWorkerCache = (global['nxPluginWorkerCache'] ??= new Map());
         // logger.verbose(`[plugin-worker] started worker: ${worker.pid}`);
-        const loadTimeout = MAX_MESSAGE_WAIT
-            ? setTimeout(() => {
-                rej(new Error(`Loading "${plugin}" timed out after ${MINUTES} minutes. ${PLUGIN_TIMEOUT_HINT_TEXT}`));
-            }, MAX_MESSAGE_WAIT)
-            : undefined;
+        const loadTimeout = setTimeout(() => {
+            rej(new Error(`Loading "${typeof plugin === 'string' ? plugin : plugin.plugin}" timed out after ${MINUTES} minutes. ${PLUGIN_TIMEOUT_HINT_TEXT}`));
+        }, MAX_MESSAGE_WAIT);
         socket.on('data', (0, consume_messages_from_socket_1.consumeMessagesFromSocket)(createWorkerHandler(worker, pendingPromises, (val) => {
@@ -174,7 +180,5 @@ if (loadTimeout)
         resolver = res;
-        timeout = MAX_MESSAGE_WAIT
-            ? setTimeout(() => {
-                rej(new Error(`${context.plugin} timed out after ${MINUTES} minutes during ${context.operation}. ${PLUGIN_TIMEOUT_HINT_TEXT}`));
-            }, MAX_MESSAGE_WAIT)
-            : undefined;
+        timeout = setTimeout(() => {
+            rej(new Error(`${context.plugin} timed out after ${MINUTES} minutes during ${context.operation}. ${PLUGIN_TIMEOUT_HINT_TEXT}`));
+        }, MAX_MESSAGE_WAIT);
         callback();
@@ -181,0 +185,0 @@ }).finally(() => {

src/tasks-runner/create-task-graph.js

@@ -143,3 +143,7 @@ "use strict";
             else {
-                const dummyId = this.getId(depProject.name, task.target.target + DUMMY_TASK_TARGET, undefined);
+                // Create a dummy task for task.target.project... which simulates if depProject had dependencyConfig.target
+                const dummyId = this.getId(depProject.name, task.target.project +
+                    '__' +
+                    dependencyConfig.target +
+                    DUMMY_TASK_TARGET, undefined);
                 this.dependencies[task.id].push(dummyId);
@@ -146,0 +150,0 @@ this.dependencies[dummyId] ??= [];

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

8186496

increased by0.01%

Lines of code

52905

increased by0.02%

No dependency changes