oauth - npm Package Compare versions

Comparing version 0.9.15 to 0.10.0

lib/oauth2.js

@@ -161,4 +161,9 @@ var querystring= require('querystring'),
   request.on('error', function(e) {
-    callbackCalled= true;
-    callback(e);
+    // `www.googleapis.com` does `ECONNRESET` just after data is received in `passBackControl`
+    // this prevents the callback from being called twice, first in passBackControl and second time in here
+    // see also NodeJS Stream documentation: "The 'error' event may be emitted by a Readable implementation at any time"
+    if(!callbackCalled) {
+      callbackCalled= true;
+      callback(e);
+    }
   });
@@ -165,0 +170,0 @@

package.json

@@ -1,15 +0,21 @@
-{ "name" : "oauth"
-, "description" : "Library for interacting with OAuth 1.0, 1.0A, 2 and Echo.  Provides simplified client access and allows for construction of more complex apis and OAuth providers."
-, "version" : "0.9.15"
-, "directories" : { "lib" : "./lib" }
-, "main" : "index.js"
-, "author" : "Ciaran Jessup <[e-mail]>"
-, "repository" : { "type":"git", "url":"http://github.com/ciaranj/node-oauth.git" }
-, "devDependencies": {
-    "vows": "0.5.x"
-  }
-, "scripts": {
-    "test": "make test"
-  }
-, "license": "MIT" 
+{
+    "name": "oauth",
+    "description": "Library for interacting with OAuth 1.0, 1.0A, 2 and Echo.  Provides simplified client access and allows for construction of more complex apis and OAuth providers.",
+    "version": "0.10.0",
+    "directories": {
+        "lib": "./lib"
+    },
+    "main": "index.js",
+    "author": "Ciaran Jessup <[e-mail]>",
+    "repository": {
+        "type": "git",
+        "url": "http://github.com/ciaranj/node-oauth.git"
+    },
+    "devDependencies": {
+        "vows": "0.8.x"
+    },
+    "scripts": {
+        "test": "make test"
+    },
+    "license": "MIT"
 }

Readme.md

@@ -81,2 +81,4 @@ node-oauth
 ============== 
+* 0.10.0
+    - OAuth2:   No longer allows repeated callbacks 'on error' to propagate to calling code (googleapi often did this apparently)
 * 0.9.15
@@ -192,1 +194,2 @@ - OAuth2:   Allow specification of agent
 * Philip Skinner - https://github.com/PhilipSkinner
+* Tom Ciborski - https://ciborski.com/

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

130096

increased by0.46%

Lines of code

2699

increased by0.19%

Number of lines in readme file

194

increased by1.57%

Worsened metrics

Number of package files

20

decreased by-4.76%

No dependency changes