oneday-core - npm Package Compare versions

Comparing version 1.0.18 to 1.0.19

index.js

@@ -18,5 +18,6 @@ 'use strict';
 module.exports.saveError = saveError;
-module.exports.handleValidation = handleValidation;
 module.exports.sendToQueue = sendToQueue;
 module.exports.publishToTopic = publishToTopic;
+module.exports.generateErrorResponse = generateErrorResponse;
+module.exports.generateSuccessResponse = generateSuccessResponse;
 
@@ -38,9 +39,4 @@ module.exports.getFromDb = db.getFromDb;
 //ToDo: Add response code, global and lambda request tracking numbers
-async function saveEvent(event, type) {   // Saves the incoming copy of data to a table as is
-
-    var requestId = uuid.v1();
-    if (event.requestContext.authorizer !== undefined && event.requestContext.authorizer.requestId !== undefined) {
-        requestId = event.requestContext.authorizer.requestId;
-    }
-
+async function saveEvent(event, type, requestId) {   // Saves the incoming copy of data to a table as is
+    console.log(event);
     const params = {
@@ -50,5 +46,5 @@ TableName: process.env.incomingTable,
             id: uuid.v1(),
+            requestId: requestId,
             function: type,
             event: event,
-            requestId: requestId,
             created: new Date().toISOString()
@@ -67,3 +63,3 @@ },
 //ToDo: Add global and lambda request tracking numbers
-async function saveError(message, error, data, type) {     // Saves the given error to the error table
+async function saveError(error, data, type, requestId) {     // Saves the given error to the error table
     console.error(error);
@@ -74,6 +70,7 @@ const params = {
             id: uuid.v1(),
+            requestId: requestId,
             function: type,
             data: data,
             error: error,
-            message: message,
+            message: error.message,
             created: new Date().toISOString()
@@ -91,22 +88,2 @@ }
 
-class Error {
-
-}
-
-function handleValidation(validation) {
-    if (validation.status === false) {
-        const error = new Error('Missing params: (' + validation.props.toString() + '). ');
-        error.statusCode = 400;
-        throw error;
-    }
-}
-
-async function generateErrorResponse(message, error, event, caller) {
-    await saveError(message, error, event, caller);
-    return {
-        statusCode: error.statusCode !== undefined ? error.statusCode : 500,
-        message: message
-    };
-}
-
 async function sendToQueue(body, queueName) {     // Sends a message to the given queue
@@ -151,2 +128,17 @@ try {
     }
+}
+
+async function generateErrorResponse(error, event, caller, requestId) {
+    await saveError(error, event, caller, requestId);
+    return {
+        statusCode: error.statusCode !== undefined ? error.statusCode : 500,
+        message: error.statusCode !== undefined && error.statusCode !== 500 ? error.message : 'Internal Server Error'
+    };
+}
+
+function generateSuccessResponse(body) {
+    return {
+        statusCode: 200,
+        body: body
+    };
 }

package.json

 {
   "name": "oneday-core",
-  "version": "1.0.18",
+  "version": "1.0.19",
   "description": "Basic AWS util functions to ease development.",
@@ -5,0 +5,0 @@ "main": "index.js",

No alert changes

Worsened metrics

Total package byte prevSize

17843

decreased by-0.62%

Lines of code

484

decreased by-0.82%

No dependency changes