openbim-components - npm Package Compare versions

Comparing version 0.0.35 to 0.0.36

components.d.ts

@@ -43,3 +43,2 @@ import * as THREE from "three";
     private _clock;
-    private _updateRequestCallback;
     /**
@@ -46,0 +45,0 @@ * The [Three.js renderer](https://threejs.org/docs/#api/en/renderers/WebGLRenderer)

components.js

@@ -36,3 +36,2 @@ import * as THREE from "three";
         this.meshes = [];
-        this._updateRequestCallback = -1;
         this.update = () => {
@@ -44,3 +43,5 @@ const delta = this._clock.getDelta();
             this.tools.update(delta);
-            this._updateRequestCallback = requestAnimationFrame(this.update);
+            const renderer = this.renderer.get();
+            // Works the same as requestAnimationFrame, but let us use WebXR.
+            renderer.setAnimationLoop(this.update);
         };
@@ -191,3 +192,2 @@ this._clock = new THREE.Clock();
     dispose() {
-        cancelAnimationFrame(this._updateRequestCallback);
         // TODO: Implement memory disposal for the whole library
@@ -194,0 +194,0 @@ }

core/simple-renderer.js

@@ -27,2 +27,3 @@ import * as THREE from "three";
             antialias: true,
+            alpha: true
         });
@@ -29,0 +30,0 @@ this._renderer.setPixelRatio(Math.min(window.devicePixelRatio, 2));

fragment/fragment-grouper.d.ts

@@ -0,1 +1,2 @@
+import { Fragments } from './fragment';
 export interface ItemGroupSystems {
@@ -15,3 +16,6 @@ [systemName: string]: {
     groupSystems: GroupSystems;
+    fragments: Fragments;
+    constructor(fragments: Fragments);
     add(guid: string, groupsSystems: ItemGroupSystems): void;
+    setVisibility(systemName: string, groupName: string, visible: boolean): void;
     remove(guid: string): void;
@@ -18,0 +22,0 @@ get(filter: {

fragment/fragment-grouper.js

 export class FragmentGrouper {
-    constructor() {
+    constructor(fragments) {
         this.groupSystems = {
@@ -7,2 +7,3 @@ category: {},
         };
+        this.fragments = fragments;
     }
@@ -24,2 +25,10 @@ add(guid, groupsSystems) {
     }
+    setVisibility(systemName, groupName, visible) {
+        const fragmentsMap = this.groupSystems[systemName][groupName];
+        for (const fragmentId in fragmentsMap) {
+            const fragment = this.fragments.fragments[fragmentId];
+            const ids = fragmentsMap[fragmentId];
+            fragment.setVisibility(ids, visible);
+        }
+    }
     remove(guid) {
@@ -26,0 +35,0 @@ for (const systemName in this.groupSystems) {

fragment/fragment-highlighter.js

@@ -54,3 +54,3 @@ import * as THREE from "three";
         this.updateFragmentHighlight(name, mesh.uuid);
-        return { id: mesh.uuid, fragment };
+        return { id: itemID, fragment };
     }
@@ -57,0 +57,0 @@ highlightByID(name, ids, removePrevious = true) {

fragment/fragment-ifc-importer/data-converter.js

@@ -49,3 +49,3 @@ import * as THREE from "three";
         this.processAllUniqueItems();
-        this.saveModelData(webIfc);
+        await this.saveModelData(webIfc);
         return this._model;
@@ -92,3 +92,4 @@ }
         const isInstanced = this._settings.instancedCategories.has(categoryID);
-        if (!isUnique || isInstanced) {
+        const noFloors = Object.keys(this._spatialStructure.itemsByFloor).length === 0;
+        if (!isUnique || isInstanced || noFloors) {
             this.processInstancedItems(data);
@@ -95,0 +96,0 @@ }

fragment/fragment-ifc-importer/geometry.js

@@ -96,2 +96,3 @@ import * as THREE from "three";
             opacity: color.w,
+            side: THREE.DoubleSide
         });
@@ -98,0 +99,0 @@ }

fragment/fragment.js

@@ -25,3 +25,3 @@ import { FragmentLoader } from "bim-fragment/fragment-loader";
         this.loader = new FragmentLoader();
-        this.groups = new FragmentGrouper();
+        this.groups = new FragmentGrouper(this);
         this.properties = new FragmentProperties();
@@ -28,0 +28,0 @@ this.tree = new FragmentSpatialTree(this.properties);

package.json

 {
   "name": "openbim-components",
   "main": "dist/index.js",
-  "version": "0.0.35",
+  "version": "0.0.36",
   "packageManager": "yarn@3.2.1",
@@ -6,0 +6,0 @@ "scripts": {

No alert changes

Improved metrics

Total package byte prevSize

537026

increased by0.23%

Lines of code

8460

increased by0.18%

No dependency changes