openfin-launcher - npm Package Compare versions

Comparing version 1.3.12 to 1.4.1

package.json

 {
     "name": "openfin-launcher",
-    "version": "1.3.12",
+    "version": "1.4.1",
     "description": "OpenFin launcher",
@@ -23,2 +23,4 @@ "author": "Ricardo de Pena <[e-mail]>",
     "devDependencies": {
+        "chai": "^1.10.0",
+        "grunt": "^1.0.1",
         "grunt-cli": "^0.1.13",
@@ -28,10 +30,12 @@ "grunt-contrib-jshint": "^0.10.0",
         "grunt-contrib-watch": "^0.6.1",
-        "load-grunt-tasks": "^1.0.0",
-        "time-grunt": "^1.0.0",
+        "grunt-jsbeautifier": "^0.2.7",
         "grunt-mocha-cli": "^1.11.0",
         "jshint-stylish": "^1.0.0",
-        "chai": "^1.10.0",
+        "load-grunt-tasks": "^1.0.0",
         "sinon": "^1.12.1",
-        "grunt-jsbeautifier": "^0.2.7"
+        "time-grunt": "^1.0.0"
     },
+    "optionalDependencies": {
+        "windows": "0.0.6"
+    },
     "scripts": {
@@ -38,0 +42,0 @@ "test": "grunt"

README.md

@@ -1,5 +0,5 @@
-#OpenFin-Launcher
+# OpenFin-Launcher
 [![Build Status](https://travis-ci.org/openfin/node-openfin-launcher.svg?branch=master)](https://travis-ci.org/openfin/node-openfin-launcher)
 
-OpenFin-Launcher is an Node.js module that automates the downloading and launching of The [OpenFin Runtime](http://openfin.co/). This module asumes you have an application config file. You can read up on application config options on the [OpenFin config file API docs](http://openfin.co/developers.html?url=developers/api/config/overview.html), or generate it automatically with the [openfin-config-builder](https://github.com/openfin/node-openfin-config-builder).
+OpenFin-Launcher is an Node.js module that automates the downloading and launching of The [OpenFin Runtime](http://openfin.co/). This module assumes you have an application config file. You can read up on application config options on the [OpenFin config file API docs](http://openfin.co/developers.html?url=developers/api/config/overview.html), or generate it automatically with the [openfin-config-builder](https://github.com/openfin/node-openfin-config-builder).
 
@@ -62,5 +62,5 @@ ## Dependencies
 
-##Options
+## Options
 
-####configPath
+#### configPath
 Type: `String`
@@ -79,3 +79,3 @@
 
-####rvmPath
+#### rvmPath
 Type: `String`
@@ -87,3 +87,3 @@
 
-###rvmUrl
+### rvmUrl
 Type: `String`
@@ -90,0 +90,0 @@

src/asset-utilities.js

@@ -10,3 +10,3 @@ var assetFetcher = require('./asset-fetcher');
 var home = process.env.HOME;
-var runtimeRoot = 'https://developer.openfin.co/release/runtime/';
+var runtimeRoot = process.env.RUNTIME_ROOT || 'https://developer.openfin.co/release/runtime/';
 
@@ -13,0 +13,0 @@ var OS_TYPES = {

src/expand-options.js

@@ -5,2 +5,3 @@ var os = require('os');
 
+
 var xpLocation = '\\Local Settings\\Application Data\\OpenFin';
@@ -11,2 +12,8 @@ var winEightOrGreater = '\\AppData\\Local\\OpenFin';
 
+// Resolves out environment paths (%localappdata%)
+function resolveToAbsolutePath(path) {
+    return path.replace(/%([^%]+)%/g, function(_, key) {
+        return process.env[key];
+    });
+}
 
@@ -19,4 +26,20 @@ function expand(options) {
     if (isWindows) {
+        var windows = require('windows'); //This is Windows specific module and will NOT work on other OS flavors.
+
         var isXP = isWindows && (+os.release().split('.')[0]) < 6;
         var defaultAppData = path.join(process.env['USERPROFILE'], isXP ? xpLocation : winEightOrGreater);
+
+        try {
+            var openFinRvmRegistry = windows.registry('HKCU/Software/OpenFin/RVM/Settings/Deployment');
+
+            // if a custom rvmInstallDirectory registry key is set, use its value instead of default location
+            if (openFinRvmRegistry.rvmInstallDirectory !== undefined) {
+                defaultAppData = path.normalize(resolveToAbsolutePath(openFinRvmRegistry.rvmInstallDirectory.value.toString()));
+
+                console.log("rvmInstallDirectory found.  Using RVM Location: ", defaultAppData);
+            }
+        } catch (err) {
+            console.log('deployment group policy not found, launching from:', defaultAppData);
+        }
+
         defaultOptions.rvmPath = path.resolve(defaultAppData, 'OpenFinRVM.exe');
@@ -30,5 +53,4 @@ }
     return _.defaults(_.clone(options), defaultOptions);
-
 }
 
 module.exports = expand;

src/nix-launcher.js

@@ -51,3 +51,4 @@ var spawn = require('child_process').spawn;
                     }
-                    args.unshift('--startup-url="' + combinedOpts.configPath + '" ');
+                    args.unshift('--startup-url="' + combinedOpts.configPath + '"');
+                    args.push('--version-keyword=' + config.runtime.version);
                     var of = spawn(runtimePath, args, {
@@ -54,0 +55,0 @@ encoding: 'utf8'

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 2 instances in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

25066

increased by2.92%

Lines of code

543

increased by3.43%

Worsened metrics

Dependency count

6

increased by20%

Dev dependency count

12

increased by9.09%

Number of package files

17

decreased by-5.56%

Number of low supply chain risk alerts

9

increased by28.57%

No dependency changes