ovh - npm Package Compare versions

Comparing version 0.3.5 to 0.3.6

ovh.js

@@ -312,3 +312,8 @@ //
     if (typeof(params) === 'object' && Object.keys(params).length > 0) {
-      options.headers['Content-Length'] = JSON.stringify(params).length; // Enjoy 500 on chunked requests...
+      if (httpMethod === 'PUT' || httpMethod === 'POST') {
+        options.headers['Content-Length'] = JSON.stringify(params).length;
+      }
+      else {
+        options.path += '?' + querystring.stringify(params);
+      }
     }
@@ -367,6 +372,6 @@
       req.on('socket', function (socket) {
-          socket.setTimeout(_this.options.timeout);
-          socket.on('timeout', function() {
-              req.abort();
-          });
+        socket.setTimeout(_this.options.timeout);
+        socket.on('timeout', function () {
+          req.abort();
+        });
       });
@@ -389,3 +394,5 @@ }
       url,
-      typeof(params) === 'object' && Object.keys(params).length > 0 ? JSON.stringify(params) : '',
+      (httpMethod === 'PUT' || httpMethod === 'POST') &&
+        typeof(params) === 'object' &&
+        Object.keys(params).length > 0 ? JSON.stringify(params) : '',
       timestamp
@@ -392,0 +399,0 @@ ];

package.json

 {
     "name": "ovh",
-    "version": "0.3.5",
+    "version": "0.3.6",
     "description": "An helper library to use OVH web services and REST APIs",
@@ -5,0 +5,0 @@ "homepage": "https://github.com/gierschv/node-ovh",

README.md

@@ -149,44 +149,2 @@ node-ovh
 
-Changelog
----------
-
-### 0.3.5
-
-* Ignore undefined parameters in REST API.
-* Move VPS tests, add /domains tests.
-
-### 0.3.4
-
-* Add timeout option for REST API.
-
-### 0.3.3
-
-* Fixes requests signature.
-
-### 0.3.2
-
-* Tested with node v0.10.
-
-### 0.3.1
-
-* Fix for node v0.9.8.
-
-### 0.3.0
-
-* Major update, first version supporting OVH REST API (https://api.ovh.com).
-
-### 0.2.0
-
-* Using native harmony-proxies Node.js implementation with --harmony-proxies flag
-* Moving from nodeunit to mocha
-* Node.js v0.4 and v0.6 are not supported anymore
-
-### 0.1.1
-
-* Fix bad exception catch
-
-### 0.1.0
-
-* Initial release
-
 License
@@ -193,0 +151,0 @@ -------

tests/07_REST_domain.js

@@ -50,4 +50,4 @@ //
     var rest = ovh({ domains: { type: 'REST', path: '/domains' } }, apiKeys);
-    rest.domains.call('GET', '/domains/{domain}/resolutions', { domain: auth.domainServiceName }, function (success, ips) {
-      assert.ok(success && ips.length > 0);
+    rest.domains.call('GET', '/domains/{domain}/resolutions', { domain: auth.domainServiceName }, function (success, resolutions) {
+      assert.ok(success && resolutions.length > 0);
       done();
@@ -60,4 +60,4 @@ });
     var rest = ovh({ domains: { type: 'REST', path: '/domains' } }, apiKeys);
-    rest.domains[auth.domainServiceName].resolutions.$get(function (success, ips) {
-      assert.ok(success && ips.length > 0);
+    rest.domains[auth.domainServiceName].resolutions.$get(function (success, resolutions) {
+      assert.ok(success && resolutions.length > 0);
       done();
@@ -139,3 +139,13 @@ });
     });
-  }
+  },
+  '[AUTH_TEST_DOMAIN] GET /domains/{domain}/resolutions - [object].$get() - Test with query string': function (done) {
+    "use strict";
+
+    var rest = ovh({ domains: { type: 'REST', path: '/domains' } }, apiKeys);
+    rest.domains[auth.domainServiceName].resolutions.$get({ 'subDomain': 'www', 'fieldType': 'CNAME' }, function (success, resolutions) {
+      assert.ok(success);
+      assert.equal(resolutions.length, 1);
+      done();
+    });
+  },
 };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

48577

increased by1.42%

Number of package files

16

increased by6.67%

Lines of code

976

increased by1.67%

Worsened metrics

Number of lines in readme file

165

decreased by-20.29%

No dependency changes