ovh - npm Package Compare versions

Comparing version 1.0.1 to 1.0.2

CHANGELOG.md

 # Changelog
 
+## 1.0.2
+
+* Fix noAuthenticated calls
+* Optionnal consumer key, now checked only on debug
+* Fix unicode (thanks to @naholyr #4)
+
 ## 1.0.1
@@ -4,0 +10,0 @@

ovh.js

@@ -330,2 +330,10 @@ //
 
+        if (typeof(this.consumerKey) !== 'string' &&
+            !api._api.operations[i].noAuthentication) {
+          return this.warn(
+            '[OVH] The API call ' + pathStr + ' requires an authentication' +
+            ' with a consumer key.'
+          );
+        }
+
         return true;
@@ -357,3 +365,3 @@ }
     }
-    
+
     // Time drift
@@ -376,6 +384,2 @@ if (this.apiTimeDiff === null && path !== '/auth/time') {
 
-    if (path.indexOf('/auth') < 0 && typeof(this.consumerKey) !== 'string') {
-      return callback('[OVH] No consumerKey defined');
-    }
-
     // Replace "{str}", used for $call()
@@ -418,5 +422,10 @@ if (path.indexOf('{') >= 0) {
 
+    var reqBody = null;
     if (typeof(params) === 'object' && Object.keys(params).length > 0) {
       if (httpMethod === 'PUT' || httpMethod === 'POST') {
-        options.headers['Content-Length'] = JSON.stringify(params).length;
+        // Escape unicode
+        reqBody = JSON.stringify(params).replace(/[\u0080-\uFFFF]/g, function(m) {
+          return "\\u" + ("0000" + m.charCodeAt(0).toString(16)).slice(-4);
+        });
+        options.headers['Content-Length'] = reqBody.length;
       }
@@ -428,12 +437,15 @@ else {
 
-    // Sign request
     if (path.indexOf('/auth') < 0) {
-      options.headers['X-Ovh-Consumer'] = this.consumerKey;
       options.headers['X-Ovh-Timestamp'] =
         Math.round(Date.now() / 1000) + this.apiTimeDiff;
-      options.headers['X-Ovh-Signature'] =
-        this.signRequest(
-          httpMethod, 'https://' + options.host + options.path,
-          params, options.headers['X-Ovh-Timestamp']
-        );
+
+      // Sign request
+      if (typeof(this.consumerKey) === 'string') {
+        options.headers['X-Ovh-Consumer'] = this.consumerKey;
+        options.headers['X-Ovh-Signature'] =
+          this.signRequest(
+            httpMethod, 'https://' + options.host + options.path,
+            reqBody, options.headers['X-Ovh-Timestamp']
+          );
+      }
     }
@@ -445,7 +457,4 @@
         options.method, options.path,
-        (httpMethod === 'PUT' || httpMethod === 'POST' &&
-         typeof(params) === 'object' && Object.keys(params).length > 0) ?
-          JSON.stringify(params) : ''
-        );
-
+        reqBody || ''
+      );
     }
@@ -512,5 +521,4 @@
 
-    if (httpMethod === 'PUT' || httpMethod === 'POST' &&
-        typeof(params) === 'object' && Object.keys(params).length > 0) {
-      req.write(JSON.stringify(params));
+    if (reqBody !== null) {
+      req.write(reqBody);
     }
@@ -521,3 +529,3 @@
 
-  Ovh.prototype.signRequest = function (httpMethod, url, params, timestamp) {
+  Ovh.prototype.signRequest = function (httpMethod, url, body, timestamp) {
     var s = [
@@ -528,5 +536,3 @@ this.appSecret,
       url,
-      (httpMethod === 'PUT' || httpMethod === 'POST') &&
-        typeof(params) === 'object' &&
-        Object.keys(params).length > 0 ? JSON.stringify(params) : '',
+      body || '',
       timestamp
@@ -533,0 +539,0 @@ ];

package.json

 {
     "name": "ovh",
-    "version": "1.0.1",
+    "version": "1.0.2",
     "description": "A helper library to use OVH.com REST API (v6)",
-    "homepage": "https://github.com/gierschv/node-ovh",
+    "homepage": "http://gierschv.github.io/node-ovh",
     "author": "Vincent Giersch <[e-mail]>",
@@ -7,0 +7,0 @@ "contributors": [],

README.md

@@ -34,1 +34,5 @@ node-ovh
 ```
+
+
+[![Bitdeli Badge](https://d2weczhvl823v0.cloudfront.net/gierschv/node-ovh/trend.png)](https://bitdeli.com/free "Bitdeli Badge")
+

tests/no_auth/01_REST_construct.js

@@ -43,4 +43,4 @@ //
     var rest = ovh({ appKey: 'XXX', appSecret: 'XXX', apis: [] });
-    rest.request('GET', '/me', function (err) {
-      assert.equal(err, '[OVH] No consumerKey defined');
+    rest.request('GET', '/me', function (err, message) {
+      assert.equal(err, 401);
       done();
@@ -47,0 +47,0 @@ });

tests/no_auth/02_REST_check.js

@@ -64,3 +64,20 @@ //
     });
-  }
+  },
+  'Call method without CK': function (done) {
+    "use strict";
+
+    var rest = ovh({
+      appKey: APP_KEY,
+      appSecret: APP_SECRET,
+      apis: ['me'],
+      warn: function (err) {
+        assert.equal(err, '[OVH] The API call /me requires an authentication with a consumer key.');
+        done();
+      }
+    });
+
+    rest.request('GET', '/me', function (err) {
+      assert.ok(err);
+    });
+  },
 };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No website

Quality

Package does not have a website.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

39861

increased by5.39%

Number of package files

15

increased by15.38%

Lines of code

882

increased by8.62%

Number of lines in readme file

38

increased by11.76%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

Number of low supply chain risk alerts

4

increased by100%

No dependency changes