penseur - npm Package Compare versions

Comparing version 1.0.0 to 1.1.0

lib/db.js

@@ -21,2 +21,3 @@ // Load Modules
     this._name = name;
+    this._connection = null;
 
@@ -43,2 +44,17 @@ this.tables = {};
 
+internals.Db.prototype.close = function (next) {
+
+    next = next || Hoek.ignore;
+
+    if (!this._connection) {
+        return next();
+    }
+
+    this._connection.close(function (err) {     // Explicit callback to avoid generating a promise
+
+        return next(err);
+    });
+};
+
+
 internals.Db.prototype.table = function (tables) {
@@ -45,0 +61,0 @@

package.json

 {
   "name": "penseur",
   "description": "Lightweight RethinkDB wrapper",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "author": "Eran Hammer <[e-mail]> (http://hueniverse.com)",
@@ -6,0 +6,0 @@ "repository": "git://github.com/hueniverse/penseur",

test/db.js

@@ -38,3 +38,3 @@ // Load modules
                     expect(item.value).to.equal('x');
-                    done();
+                    db.close(done);
                 });
@@ -54,3 +54,3 @@ });
                 expect(err).to.not.exist();
-                done();
+                db.close(done);
             });
@@ -66,3 +66,3 @@ });
                 expect(err).to.exist();
-                done();
+                db.close(done);
             });
@@ -72,2 +72,18 @@ });
 
+    describe('close()', function () {
+
+        it('ignores unconnected state', function (done) {
+
+            var db = new Penseur.Db('penseurtest');
+            db.close(done);
+        });
+
+        it('allows no callback', function (done) {
+
+            var db = new Penseur.Db('penseurtest');
+            db.close();
+            done();
+        });
+    });
+
     describe('table()', function () {
@@ -84,3 +100,3 @@
                 expect(db.tables.connect).to.exist();
-                done();
+                db.close(done);
             });
@@ -99,3 +115,3 @@ });
                 expect(err).to.exist();
-                done();
+                db.close(done);
             });
@@ -111,3 +127,3 @@ });
                 expect(err).to.exist();
-                done();
+                db.close(done);
             });
@@ -114,0 +130,0 @@ });

No alert changes

Improved metrics

Total package byte prevSize

28725

increased by2.56%

Lines of code

633

increased by3.43%

No dependency changes