phonegap-build - npm Package Compare versions

Comparing version 0.9.2 to 0.10.0

lib/phonegap-build/build.js

@@ -60,3 +60,3 @@ /*!
     // login and get api object
-    self.login({}, function(e, api) {
+    self.login(options, function(e, api) {
         if (e) {
@@ -63,0 +63,0 @@ callback(e);

lib/phonegap-build/login.js

@@ -7,3 +7,4 @@ /*!
     client = require('phonegap-build-api'),
-    config = require('../common/config');
+    config = require('../common/config'),
+    extend = require('../common/extend');
 
@@ -64,10 +65,6 @@ /**
         if (!e && data && data.phonegap && data.phonegap.token) {
+            var apiOptions = extend(data.phonegap, options);
+
             // login with saved account
-            var api = new client.API({
-                'protocol': 'https:',
-                'host': 'build.phonegap.com',
-                'port': '443',
-                'path': '/api/v1',
-                'token': data.phonegap.token
-            });
+            var api = new client.API(apiOptions);
 
@@ -74,0 +71,0 @@ callback(null, api);

package.json

 {
     "name": "phonegap-build",
     "description": "PhoneGap Build node library.",
-    "version": "0.9.2",
+    "version": "0.10.0",
     "homepage": "http://github.com/phonegap/node-phonegap-build",
@@ -19,3 +19,3 @@ "repository": {
     "scripts": {
-        "test": "jasmine-node --color --verbose spec"
+        "test": "jasmine-node --color spec"
     },
@@ -31,3 +31,3 @@ "engines": {
         "qrcode-terminal": "0.8.x",
-        "phonegap-build-api": "0.3.3"
+        "phonegap-build-api": "0.4.0"
     },
@@ -34,0 +34,0 @@ "devDependencies": {

README.md

@@ -33,2 +33,7 @@ # PhoneGap Build Node Module [![Build Status][travis-ci-img]][travis-ci-url] [![bitHound Score][bithound-img]][bithound-url]
   - [`options.password`] {String} is the password.
+  - [`options.protocol`] `{String}` optional server protocol. e.g. 'https:'.
+  - [`options.host`] `{String}` optional server host. e.g. 'build.phonegap.com:'.
+  - [`options.port`] `{String}` optional server port. e.g. '443'.
+  - [`options.path`] `{String}` optional server path prefix. e.g. '/api/v1'.
+  - [`options.proxy`] `{String}` specifies an optional proxy server. e.g. 'http://myproxy.com:8181'.
   - [`callback`] {Function} is called after the login.
@@ -161,2 +166,7 @@ - `e` {Error} is null on a successful login attempt.
   - `options.platforms` {Array} is a collection of platform names {String} that
+  - [`options.protocol`] `{String}` optional server protocol. e.g. 'https:'.
+  - [`options.host`] `{String}` optional server host. e.g. 'build.phonegap.com:'.
+  - [`options.port`] `{String}` optional server port. e.g. '443'.
+  - [`options.path`] `{String}` optional server path prefix. e.g. '/api/v1'.
+  - [`options.proxy`] `{String}` specifies an optional proxy server. e.g. 'http://myproxy.com:8181'.
                         specify the platforms to build.
@@ -163,0 +173,0 @@ - [`callback`] {Function} is triggered after the build is complete.

spec/phonegap-build/build.spec.js

@@ -63,2 +63,44 @@ /*
 
+    describe('optional arguments', function() {
+        it('should support options.protocol', function() {
+            options.protocol = 'http:';
+            phonegapbuild.build(options);
+            expect(
+                phonegapbuild.login.mostRecentCall.args[0].protocol
+            ).toEqual('http:');
+        });
+
+        it('should support options.host', function() {
+            options.host = 'stage.build.phonegap.com';
+            phonegapbuild.build(options);
+            expect(
+                phonegapbuild.login.mostRecentCall.args[0].host
+            ).toEqual('stage.build.phonegap.com');
+        });
+
+        it('should support options.port', function() {
+            options.port = '1337';
+            phonegapbuild.build(options);
+            expect(
+                phonegapbuild.login.mostRecentCall.args[0].port
+            ).toEqual('1337');
+        });
+
+        it('should support options.path', function() {
+            options.path = '/api/v1';
+            phonegapbuild.build(options);
+            expect(
+                phonegapbuild.login.mostRecentCall.args[0].path
+            ).toEqual('/api/v1');
+        });
+
+        it('should support options.proxy', function() {
+            options.proxy = 'my.proxy.com';
+            phonegapbuild.build(options);
+            expect(
+                phonegapbuild.login.mostRecentCall.args[0].proxy
+            ).toEqual('my.proxy.com');
+        });
+    });
+
     describe('when login is successful', function() {
@@ -65,0 +107,0 @@ beforeEach(function() {

spec/phonegap-build/login.spec.js

@@ -72,2 +72,44 @@ /*
         });
+
+        describe('optional arguments', function() {
+            it('should support options.protocol', function(done) {
+                options.protocol = 'http:';
+                phonegapbuild.login(options, function(e, api) {
+                    expect(api.protocol).toEqual('http:');
+                    done();
+                });
+            });
+
+            it('should support options.host', function(done) {
+                options.host = 'stage.build.phonegap.com';
+                phonegapbuild.login(options, function(e, api) {
+                    expect(api.host).toEqual('stage.build.phonegap.com');
+                    done();
+                });
+            });
+
+            it('should support options.port', function(done) {
+                options.port = '1337';
+                phonegapbuild.login(options, function(e, api) {
+                    expect(api.port).toEqual('1337');
+                    done();
+                });
+            });
+
+            it('should support options.path', function(done) {
+                options.path = '/api/v1';
+                phonegapbuild.login(options, function(e, api) {
+                    expect(api.path).toEqual('/api/v1');
+                    done();
+                });
+            });
+
+            it('should support options.proxy', function(done) {
+                options.proxy = 'my.proxy.com';
+                phonegapbuild.login(options, function(e, api) {
+                    expect(api.proxy).toEqual('my.proxy.com');
+                    done();
+                });
+            });
+        });
     });
@@ -74,0 +116,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1510688

increased by0.29%

Number of package files

89

increased by1.14%

Lines of code

5991

increased by1.66%

Number of lines in readme file

198

increased by5.32%

Dependency changes

• + Addedphonegap-build-api@0.4.0(transitive)

• - Removedphonegap-build-api@0.3.3(transitive)

• Updatedphonegap-build-api@0.4.0