phonegap - npm Package Compare versions

Comparing version 0.8.1 to 0.9.0

doc/cli/help.app.txt

@@ -5,3 +5,3 @@ Usage: $0 app [options]
 
-  Servers the app on a local web server.
+  Serves the application on a local web server.
 
@@ -8,0 +8,0 @@ The intended receiver is the PhoneGap App, but any

doc/cli/help.build.txt

@@ -5,17 +5,8 @@ Usage: $0 build <platform>
 
-  Build your application to a specific platform.
+  Builds your application to a specific platform.
 
-  When you have the platform SDK installed on your system,
-  then it will build the app locally. Otherwise it will
-  fallback on PhoneGap/Build.
+  Automatically detects support for the platform SDK.
+  When the SDK is supported, the build is executed locally.
+  When the SDK is unsupported, the build is executed remotely.
 
-  The platform names are:
-
-    - android
-    - blackberry
-    - ios
-    - symbian
-    - webos
-    - winphone
-
 Examples:
@@ -26,5 +17,5 @@
 
-Related:
+Also see:
 
   $0 local build <platform>
   $0 remote build <platform>

doc/cli/help.create.txt

@@ -5,3 +5,3 @@ Usage: $0 create [options] <path>
 
-  Create a new application.
+  Creates a new application at the provided path.
 
@@ -8,0 +8,0 @@ Examples:

doc/cli/help.local.build.txt

@@ -5,5 +5,5 @@ Usage: $0 local build <platform>
 
-  Build your application to a specific platform.
+  Builds your application for a specific platform.
 
-  Build will happen locally on your system. This requires that
+  Build will execute on the local system. This requires that
   the <platform> SDK environment is correctly installed.
@@ -16,10 +16,4 @@
 
-  The platform names are:
-
-    - android
-    - blackberry
-    - ios
-
 Examples:
 
   $ $0 local build android

doc/cli/help.local.run.txt

@@ -5,12 +5,6 @@ Usage: $0 local run <platform>
 
-  Build and install your application to a specific platform.
+  Builds and installs your application to a specific platform.
 
-  The platform names are:
-
-    - android
-    - blackberry
-    - ios
-
 Examples:
 
   $ $0 local run android

doc/cli/help.local.txt

@@ -5,5 +5,6 @@ Usage: $0 local [command]
 
-  Run commands on your local system.
-  This requires that you have the correct platform SDKs installed.
+  Executes the command on the local system.
 
+  This requires that platform SDK is correctly installed.
+
 Commands:
@@ -10,0 +11,0 @@

doc/cli/help.remote.build.txt

@@ -5,15 +5,6 @@ Usage: $0 remote build <platform>
 
-  Build your application to a specific platform.
+  Builds your application to a specific platform.
 
-  The platform names are:
-
-    - android
-    - blackberry
-    - ios
-    - symbian
-    - webos
-    - winphone
-
 Examples:
 
   $ $0 remote build android

doc/cli/help.remote.run.txt

@@ -5,15 +5,6 @@ Usage: $0 remote run <platform>
 
-  Build and install your application to a specific platform.
+  Builds and installs your application to a specific platform.
 
-  The platform names are:
-
-    - android
-    - blackberry
-    - ios
-    - symbian
-    - webos
-    - winphone
-
 Examples:
 
   $ $0 remote run android

doc/cli/help.remote.txt

@@ -5,3 +5,3 @@ Usage: $0 remote [command]
 
-  Run commands for cloud-based development with PhoneGap/Build.
+  Executes the command remotely using the cloud-based PhoneGap/Build service.
 
@@ -8,0 +8,0 @@ Commands:

doc/cli/help.run.txt

@@ -5,5 +5,6 @@ Usage: $0 run <platform>
 
-  Build and install your application to a specific platform.
+  Builds and installs your application to a specific platform.
 
-  Automatically detects your platform SDK and fallsback on PhoneGap/Build.
+  Automatically detects support for the platform SDK and executes the
+  run command locally or remotely.
 
@@ -15,5 +16,5 @@ Examples:
 
-Related:
+Also see:
 
   $0 local run <platform>
   $0 remote run <platform>

doc/cli/help.txt

@@ -11,2 +11,3 @@ Usage: $0 [options] [commands]
   build <platform>     build a specific platform
+  install <platform>   install a specific platform
   run <platform>       build and install a specific platform
@@ -23,2 +24,10 @@ local [command]      development on local system
 
+Platforms:
+
+  android              target Android
+  blackberry           target BlackBerry 10
+  ios                  target iOS
+  wp7                  target Windows Phone 7
+  wp8                  target Windows Phone 8
+
 Examples:
@@ -25,0 +34,0 @@

lib/cli.js

@@ -27,2 +27,3 @@ /*!
 CLI.prototype.build = require('./cli/build');
+CLI.prototype.install = require('./cli/install');
 CLI.prototype.run = require('./cli/run');
@@ -29,0 +30,0 @@ CLI.prototype.help = require('./cli/help');

lib/cli/unknown.js

@@ -21,3 +21,3 @@ /*!
     console.error(util.format(
-        "'%s' is not a %s command. See '%s --help'",
+        "'%s' is not a %s command. See '%s help'",
         argv._[0],
@@ -24,0 +24,0 @@ argv.$0,

lib/phonegap.js

@@ -33,6 +33,9 @@ /*!
     this.create = require('./phonegap/create').create(this);
+    this.install = require('./phonegap/install').create(this);
     this.run = require('./phonegap/run').create(this);
     this.local.build = require('./phonegap/local.build').create(this);
+    this.local.install = require('./phonegap/local.install').create(this);
     this.local.run = require('./phonegap/local.run').create(this);
     this.remote.build = require('./phonegap/remote.build').create(this);
+    this.remote.install = require('./phonegap/remote.install').create(this);
     this.remote.login = require('./phonegap/remote.login').create(this);
@@ -39,0 +42,0 @@ this.remote.logout = require('./phonegap/remote.logout').create(this);

lib/phonegap/local.run.js

@@ -74,14 +74,7 @@ /*!
 
-        try {
-            // FIX: cordova.emulate throws errors that cannot be caught
-            // FIX: cordova.emulate may trigger callback twice
-            cordova.emulate(options.platforms, function() {
-                callback(null);
-            });
-        }
-        catch(e) {
-            self.phonegap.emit('error', e);
+        // install the app
+        self.phonegap.local.install(options, function(e) {
             callback(e);
-        }
+        });
     });
 };

package.json

 {
     "name": "phonegap",
     "description": "PhoneGap command-line interface and node.js library.",
-    "version": "0.8.1",
+    "version": "0.9.0",
     "homepage": "http://github.com/mwbrooks/phonegap-cli",
@@ -6,0 +6,0 @@ "repository": {

spec/cli/run.spec.js

@@ -68,3 +68,3 @@ /*
 
-describe('phonegap build <platform>', function() {
+describe('phonegap run <platform>', function() {
     beforeEach(function() {
@@ -71,0 +71,0 @@ cli = new CLI();

spec/phonegap/local.run.spec.js

@@ -7,3 +7,2 @@ /*
     project = require('../../lib/phonegap/util/project'),
-    cordova = require('cordova'),
     phonegap,
@@ -24,3 +23,3 @@ options;
         spyOn(phonegap.local, 'build');
-        spyOn(cordova, 'emulate');
+        spyOn(phonegap.local, 'install');
         spyOn(project, 'cd').andReturn(true);
@@ -73,6 +72,6 @@ });
 
-        it('should run the app', function() {
+        it('should install the app', function() {
             phonegap.local.run(options);
-            expect(cordova.emulate).toHaveBeenCalledWith(
-                options.platforms,
+            expect(phonegap.local.install).toHaveBeenCalledWith(
+                options,
                 jasmine.any(Function)
@@ -82,6 +81,6 @@ );
 
-        describe('successful run', function() {
+        describe('successful install', function() {
             beforeEach(function() {
-                cordova.emulate.andCallFake(function(platforms, callback) {
-                    callback();
+                phonegap.local.install.andCallFake(function(options, callback) {
+                    callback(null);
                 });
@@ -98,6 +97,8 @@ });
 
-        describe('failed run', function() {
+        describe('failed install', function() {
             beforeEach(function() {
-                cordova.emulate.andCallFake(function(platforms, callback) {
-                    throw new Error('Ganon stole the binary');
+                phonegap.local.install.andCallFake(function(options, callback) {
+                    var e = new Error('Ganon stole the binary');
+                    phonegap.emit('error', e);
+                    callback(e);
                 });
@@ -104,0 +105,0 @@ });

spec/phonegap/run.spec.js

@@ -15,3 +15,3 @@ /*
 
-describe('phonegap.build(options, [callback])', function() {
+describe('phonegap.run(options, [callback])', function() {
     beforeEach(function() {
@@ -18,0 +18,0 @@ phonegap = new PhoneGap();

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

195203

increased by11.65%

Number of package files

100

increased by12.36%

Lines of code

5231

increased by12.93%

No dependency changes