phosphor-splitpanel - npm Package Compare versions

Comparing version 0.9.0 to 0.9.1

lib/index.d.ts

@@ -241,2 +241,6 @@ import { Message } from 'phosphor-messaging';
     /**
+     * The change handler for the [[orientationProperty]].
+     */
+    private _onOrientationChanged(old, value);
+    /**
      * The handler for the child property changed signal.
@@ -243,0 +247,0 @@ */

lib/index.js

@@ -304,3 +304,5 @@ /*-----------------------------------------------------------------------------
     SplitPanel.prototype.onLayoutRequest = function (msg) {
-        this._setupGeometry();
+        if (this.isAttached) {
+            this._setupGeometry();
+        }
     };
@@ -414,3 +416,3 @@ /**
         var height = offsetHeight - box.verticalSum;
-        // Distribute the layout space and layout the widget items.
+        // Distribute the layout space and layout the items.
         var handleSize = this.handleSize;
@@ -562,2 +564,10 @@ if (this.orientation === Orientation.Horizontal) {
     /**
+     * The change handler for the [[orientationProperty]].
+     */
+    SplitPanel.prototype._onOrientationChanged = function (old, value) {
+        this.toggleClass(exports.HORIZONTAL_CLASS, value === Orientation.Horizontal);
+        this.toggleClass(exports.VERTICAL_CLASS, value === Orientation.Vertical);
+        phosphor_messaging_1.postMessage(this, phosphor_widget_1.MSG_LAYOUT_REQUEST);
+    };
+    /**
      * The handler for the child property changed signal.
@@ -588,3 +598,3 @@ */
         value: Orientation.Horizontal,
-        changed: onOrientationChanged,
+        changed: function (owner, old, value) { return owner._onOrientationChanged(old, value); },
     });
@@ -602,3 +612,3 @@ /**
         coerce: function (owner, value) { return Math.max(0, value | 0); },
-        changed: onHandleSizeChanged,
+        changed: function (owner) { return phosphor_messaging_1.postMessage(owner, phosphor_widget_1.MSG_LAYOUT_REQUEST); },
     });
@@ -622,16 +632,2 @@ /**
 /**
- * The change handler for the [[orientationProperty]].
- */
-function onOrientationChanged(owner, old, value) {
-    owner.toggleClass(exports.HORIZONTAL_CLASS, value === Orientation.Horizontal);
-    owner.toggleClass(exports.VERTICAL_CLASS, value === Orientation.Vertical);
-    phosphor_messaging_1.postMessage(owner, phosphor_widget_1.MSG_LAYOUT_REQUEST);
-}
-/**
- * The change handler for the `handleSize` property.
- */
-function onHandleSizeChanged(owner, old, value) {
-    phosphor_messaging_1.postMessage(owner, phosphor_widget_1.MSG_LAYOUT_REQUEST);
-}
-/**
  * A class which manages a handle node for a split panel.
@@ -638,0 +634,0 @@ */

package.json

 {
   "name": "phosphor-splitpanel",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "description": "A Phosphor layout widget which arranges its children into resizable sections.",
@@ -18,2 +18,3 @@ "main": "lib/index.js",
   "devDependencies": {
+    "browserify": "^11.0.1",
     "browserify-css": "^0.6.1",
@@ -43,3 +44,3 @@ "browserify-istanbul": "^0.2.1",
     "build:css": "node scripts/copycss.js",
-    "build:example": "tsc --project example && browserify example/index.js -t browserify-css -o example/bundle.js",
+    "build:example": "tsc --project example && browserify -g browserify-css example/index.js -o example/bundle.js",
     "build": "npm run build:src && npm run build:test && npm run build:css",
@@ -46,0 +47,0 @@ "docs": "rimraf docs/api && typedoc --options scripts/tdoptions.json",

README.md

@@ -102,3 +102,3 @@ phosphor-splitpanel
 npm install --save-dev browserify browserify-css
-browserify myapp.js -t browserify-css -o mybundle.js
+browserify -g browserify-css myapp.js -o mybundle.js
 ```
@@ -105,0 +105,0 @@

No alert changes

Worsened metrics

Total package byte prevSize

47243

decreased by-2.49%

Dev dependency count

18

increased by5.88%

No dependency changes