poolee - npm Package Compare versions

Comparing version 0.4.6 to 0.4.7

lib/endpoint.js

@@ -22,2 +22,3 @@ var Stream = require('stream')
 	//   keepAlive: use an alternate Agent that does keep-alive properly (boolean) default false
+	//   agentOptions: {} an object for passing options directly to the Http Agent
 	// }
@@ -43,10 +44,10 @@ function Endpoint(protocol, ip, port, options) {
 			if (protocol === http) {
-				this.agent = new KeepAlive()
+				this.agent = new KeepAlive(options.agentOptions)
 			}
 			else {
-				this.agent = new KeepAlive.Secure()
+				this.agent = new KeepAlive.Secure(options.agentOptions)
 			}
 		}
 		else {
-			this.agent = new protocol.Agent()
+			this.agent = new protocol.Agent(options.agentOptions)
 		}
@@ -53,0 +54,0 @@ this.agent.maxSockets = options.maxSockets || 20

lib/pool.js

@@ -19,2 +19,3 @@ module.exports = function (inherits, EventEmitter, Endpoint, RequestSet) {
 	//    maxRetries: number (default = 5)
+	//    agentOptions: {} an object for passing options directly to the Http Agent
 	// }
@@ -21,0 +22,0 @@ function Pool(http, nodes, options) {

package.json

 {
     "name": "poolee",
-    "version": "0.4.6",
+    "version": "0.4.7",
     "description": "HTTP pool and load balancer",
@@ -5,0 +5,0 @@ "homepage": "http://github.com/dannycoates/poolee",

readme.md

@@ -73,2 +73,3 @@ # poolee
   , name: undefined        // optional string
+  , agentOptions: undefined// an object for passing options directly to the Http Agent
   }
@@ -127,2 +128,7 @@ )
 
+###### agentOptions
+
+These options are passed directly to the underlying Agents used in the pool. This
+is nice for passing options like `cert` and `key` that are required for client certificates.
+
 ###### ping
@@ -129,0 +135,0 @@

test/endpoint_test.js

@@ -5,2 +5,3 @@ var assert = require("assert")
 var http = require('http')
+var https = require('https')
 var Stream = require('stream')
@@ -15,2 +16,25 @@
 
+	it("passes nothing to the Agent constructor when no agentOptions are given", function () {
+		var e = new Endpoint(http, '127.0.0.1', 6969, { bogus: true })
+		assert.equal(e.agent.options.bogus, undefined)
+	})
+
+	it("passes agentOptions to the underlying Agent (no keep-alive)", function () {
+		var e = new Endpoint(http, '127.0.0.1', 6969, { agentOptions: { cert: 'foo', key: 'bar'}})
+		assert.equal(e.agent.options.cert, 'foo')
+		assert.equal(e.agent.options.key, 'bar')
+	})
+
+	it("passes agentOptions to the underlying Agent (keep-alive)", function () {
+		var e = new Endpoint(http, '127.0.0.1', 6969, {keepAlive: true, agentOptions: { cert: 'foo', key: 'bar'}})
+		assert.equal(e.agent.options.cert, 'foo')
+		assert.equal(e.agent.options.key, 'bar')
+	})
+
+	it("passes agentOptions to the underlying Agent (keep-alive secure)", function () {
+		var e = new Endpoint(https, '127.0.0.1', 6969, {keepAlive: true, agentOptions: { cert: 'foo', key: 'bar'}})
+		assert.equal(e.agent.options.cert, 'foo')
+		assert.equal(e.agent.options.key, 'bar')
+	})
+
 	//
@@ -17,0 +41,0 @@ // unhealthy

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Non-existent author

Supply chain risk

The package was published by an npm account that no longer exists.

Found 1 instance in 1 package

Network access

Supply chain risk

This module accesses the network.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

52995

increased by4.75%

Lines of code

1489

increased by3.91%

Number of lines in readme file

239

increased by2.58%

Worsened metrics

Number of high supply chain risk alerts

1

increased byInfinity%

Number of medium supply chain risk alerts

4

increased by100%

No dependency changes