preact-render-to-string - npm Package Compare versions

Comparing version 3.0.4 to 3.0.5

dist/index.js

@@ -161,3 +161,3 @@ (function (global, factory) {
 				var hooked = opts.attributeHook && opts.attributeHook(name, v, context, opts);
-				if (hooked) {
+				if (hooked || hooked === '') {
 					s += hooked;
@@ -164,0 +164,0 @@ continue;

dist/jsx.js

@@ -173,3 +173,3 @@ (function (global, factory) {
   			var hooked = opts.attributeHook && opts.attributeHook(name, v, context, opts);
-  			if (hooked) {
+  			if (hooked || hooked === '') {
   				s += hooked;
@@ -631,2 +631,4 @@ continue;
   function attributeHook(name, value, context, opts) {
+  	if (value == null) return '';
+
   	var indentChar = typeof opts.pretty === 'string' ? opts.pretty : '\t';
@@ -633,0 +635,0 @@ if (typeof value !== 'string') {

package.json

 {
   "name": "preact-render-to-string",
   "amdName": "preactRenderToString",
-  "version": "3.0.4",
+  "version": "3.0.5",
   "description": "Render JSX to an HTML string, with support for Preact components.",
@@ -6,0 +6,0 @@ "main": "dist/index.js",

src/index.js

@@ -111,3 +111,3 @@ import { objectKeys, encodeEntities, falsey, memoize, indent, isLargeString, styleObjToCss, assign, getNodeProps } from './util';
 			let hooked = opts.attributeHook && opts.attributeHook(name, v, context, opts);
-			if (hooked) {
+			if (hooked || hooked==='') {
 				s += hooked;
@@ -114,0 +114,0 @@ continue;

src/jsx.js

@@ -24,2 +24,4 @@ import './polyfills';
 function attributeHook(name, value, context, opts) {
+	if (value==null) return '';
+
 	let indentChar = typeof opts.pretty==='string' ? opts.pretty : '\t';
@@ -26,0 +28,0 @@ if (typeof value!=='string') {

test/jsx.js

@@ -73,2 +73,12 @@ import render from '../src/jsx';
 
+	it('should skip null and undefined attributes', () => {
+		expect(renderJsx(
+			<a b={null}>bar</a>
+		)).to.equal(`<a>bar</a>`);
+
+		expect(renderJsx(
+			<a b={undefined}>bar</a>
+		)).to.equal(`<a>bar</a>`);
+	});
+
 	it('should render attributes containing VNodes', () => {
@@ -75,0 +85,0 @@ expect(renderJsx(

No alert changes

Improved metrics

Total package byte prevSize

117172

increased by0.39%

Lines of code

1609

increased by0.63%

No dependency changes