prosemirror-view - npm Package Compare versions

Comparing version 1.5.0 to 1.5.1

CHANGELOG.md

@@ -0,1 +1,7 @@
+## 1.5.1 (2018-08-24)
+
+### Bug fixes
+
+Fix issue where some DOM selections would cause a non-editable view to crash when reading the selection.
+
 ## 1.5.0 (2018-08-21)
@@ -2,0 +8,0 @@

package.json

 {
   "name": "prosemirror-view",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "description": "ProseMirror's view component",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

src/selection.js

@@ -305,3 +305,4 @@ import {TextSelection, NodeSelection} from "prosemirror-state"
     // element.
-    return view.dom.contains(sel.anchorNode.nodeType == 3 ? sel.anchorNode.parentNode : sel.anchorNode)
+    return view.dom.contains(sel.anchorNode.nodeType == 3 ? sel.anchorNode.parentNode : sel.anchorNode) &&
+      (view.editable || view.dom.contains(sel.focusNode.nodeType == 3 ? sel.focusNode.parentNode : sel.focusNode))
   } catch(_) {
@@ -308,0 +309,0 @@ return false

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

735420

increased by0.09%

Lines of code

8318

increased by0.02%

No dependency changes