publication-server
Advanced tools
Comparing version 3.0.2 to 3.0.3
@@ -1,11 +0,70 @@ | ||
#### Changes Made | ||
<!-- Author/Reviewer expectations are described in the last comment --> | ||
#### Potential Risks | ||
<!--- What can go wrong with this change? How will these changes affect adjacent code/features? How will we handle any adverse issues? ---> | ||
> **Note** - Since this is a public repository, make sure that we're not publishing private data in the code, commit comments, or this PR. | ||
#### Test Plan | ||
<!--- How do we know this PR does what it's supposed to do? How do we ensure that adjacent code/features are still working? How do we evaluate the performance implications of this PR?---> | ||
> **Note for reviewers** - Please add a 2nd reviewer if the PR affects more than 15 files or 100 lines (not counting | ||
`package-lock.json`), if it incurs significant risk, or if it is going through a 2nd review+fix cycle. | ||
#### Checklist | ||
- [ ] I've increased test coverage | ||
- [ ] Since this is a public repository, I've checked I'm not publishing private data in the code, commit comments, or this PR. | ||
## 📚 Context/Description Behind The Change | ||
<!-- | ||
What changes have you made to the code, and why? | ||
As skilled engineers, we all know how to read and interpret code, so take this opportunity | ||
to be a bit more verbal about your changes. | ||
Giving the context behind your changes will make your PR review quicker, | ||
as the reviewer will not need to guess your intent. | ||
--> | ||
## 🚨 Potential Risks & What To Monitor After Deployment | ||
<!-- | ||
What can go wrong with this deploy? | ||
Does it touch any critical services? | ||
How will these changes affect adjacent code/features? | ||
How will we handle any adverse issues? | ||
If significant risks are identified, please request a 2nd reviewer as a first mitigation step. | ||
--> | ||
## 🧑🔬 How Has This Been Tested? | ||
<!-- | ||
Imagine: How do I (and the Reviewer): | ||
How do we know this PR does what it's supposed to do? | ||
How do we ensure that adjacent code/features are still working? | ||
How do we evaluate the performance implications of this PR? | ||
--> | ||
## 🚚 Release Plan | ||
<!-- | ||
Imagine: If you had to leave in a rush, what should the backup engineer do to deploy this? | ||
Add any tasks that need to be done before/during/after release (i.e, creating indices, deploying | ||
other services, bumping modules, notifying PM or other engineers, etc). | ||
--> | ||
<!-- | ||
## 🤝 Expectations | ||
When Opening/Reviewing a PR, please keep in mind: | ||
### As the PR Author | ||
- Provide all the necessary context on "Why" you have performed your changes | ||
- Assume that the reviewer has no previous knowledge about the codebase: would he/she be able to | ||
review it the way it is right now? | ||
- If changes are extensive, break them into smaller commits that tell a story, instead of 1 commit | ||
with 15 files changed. | ||
- Split Refactors and New-Code-Changes into different commits, ideally: different PRs. | ||
- Test your code before requesting review — unless some rare exceptions, we shouldn't ship any code | ||
without testing it before. | ||
- If your PR is UI related, consider adding screenshots/videos with the behavior and before/after. | ||
### As the PR Reviewer | ||
- Be kind. Don't nitpick. | ||
- Expect to have all the necessary context to review the PR on (or linked on) the PR itself. | ||
- When in doubt: ask. | ||
- Validate if the author's tests have any missing coverage points. Do not approve an untested PR. | ||
- Pay extra attention to the "Potential Risks" and "Release Plan" sections. | ||
- If the PR alters the product UI, consider checking out the branch to visually inspect it. | ||
--> |
@@ -0,1 +1,9 @@ | ||
## [3.0.3](https://github.com/mixmaxhq/publication-server/compare/v3.0.2...v3.0.3) (2024-01-03) | ||
### Bug Fixes | ||
* **deps:** update dependency @mixmaxhq/semantic-release-config to v3 ([519cd45](https://github.com/mixmaxhq/publication-server/commit/519cd459919350bfcd5ffd5f54c56fd6cc65cbd3)) | ||
* **deps:** update dependency @mixmaxhq/semantic-release-config to v3 ([51a81f1](https://github.com/mixmaxhq/publication-server/commit/51a81f17fffb90588028529bf971138d306a7a91)) | ||
## [3.0.2](https://github.com/mixmaxhq/publication-server/compare/v3.0.1...v3.0.2) (2022-11-11) | ||
@@ -2,0 +10,0 @@ |
{ | ||
"name": "publication-server", | ||
"version": "3.0.2", | ||
"version": "3.0.3", | ||
"description": "", | ||
@@ -33,3 +33,3 @@ "main": "src/index.js", | ||
"@mixmaxhq/prettier-config": "^1.1.0", | ||
"@mixmaxhq/semantic-release-config": "^2.0.3", | ||
"@mixmaxhq/semantic-release-config": "^3.0.2", | ||
"cz-conventional-changelog": "^3.3.0", | ||
@@ -57,3 +57,3 @@ "eslint": "^7.32.0", | ||
"release": { | ||
"extends": "@mixmaxhq/semantic-release-config" | ||
"extends": "@mixmaxhq/semantic-release-config/package/index.js" | ||
}, | ||
@@ -60,0 +60,0 @@ "publishConfig": { |
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
Native code
Supply chain riskContains native code (e.g., compiled binaries or shared libraries). Including native code can obscure malicious behavior.
Found 1 instance in 1 package
29
9604
2
378093