pubsub-js - npm Package Compare versions

Comparing version 1.4.0 to 1.4.1

bower.json

 {
   "name": "PubSubJS",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "main": "src/pubsub.js",
@@ -5,0 +5,0 @@ "ignore": [

package.json

 {
   "name": "pubsub-js",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "Dependency free publish/subscribe library",
@@ -5,0 +5,0 @@ "main": "./src/pubsub.js",

README.md

@@ -192,29 +192,6 @@ # PubSubJS
 
-## Development
+## Contributing to PubSubJS
 
-There are grunt tasks for helping with linting and testing the codebase.
+Please see [CONTRIBUTING.md](CONTRIBUTING.md)
 
-### Test setup
-
-The tests are implemented using [BusterJS](http://busterjs.org) and the excellent [Sinon.JS](http://cjohansen.no/sinon/). You will need to install BusterJS in order to run the tests.
-
-### Linting
-
-```bash
-$ grunt lint
-```
-
-### Testing with PhantomJS
-
-If you have PhantomJS installed on your system, you can run the Buster tests by running
-
-```bash
-$ grunt test
-```
-
-or by running
-```bash
-$ npm test
-```
-
 ## Future of PubSubJS
@@ -237,40 +214,5 @@
 ## Changelog
-* v1.3.9
-    * Add release number to bower.json, package.json, tests, readme
-* v1.3.8
-    * Fix issue 26
-* v1.3.7
-    * Fix issue #18 - Make publish method return false when all subscribers have been removed
-* v1.3.6
-    * Add [bower](http://bower.io) support
 
-* v1.3.5
-    * Fix package.json, add a "main" option, for easier use with node
+Please see [https://github.com/mroderick/PubSubJS/releases](https://github.com/mroderick/PubSubJS/releases)
 
-* v1.3.4
-    * Updating grunt to 0.4.0
-    * Tweaks for publication to npm.
-
-* v1.3.3
-    * Adding grunt.js for development tasks
-    * Adding package.json for distribution via npm
-    * Linting all source and test files with recent release of JSLint
-
-    This version should from an API perspective be exactly the same as v1.3.2. Changes were only made to make PubSubJS more suitable for distribution via npm.
-
-* v1.3.2
-    * Adding immediateExceptions configuration option to allow for development time debugging without loosing stack traces in Chrome dev tools
-* v1.3.1
-    * Fixing issue-13, where CommonJS detection mistook QUnit for CommonJS environment.
-* v1.3.0
-    * Added jQuery plugin via rake task
-* v1.2.2
-    * Fix issue 9, where a subscriber would not get notified, if there were no subscribers above it in hierarchy.
-* v1.2.0
-    * Remove all subscriptions for a function (@mrgnrdrck)
-* v1.1.0
-    * Hierarchical addressing of topics ("namespacing") (@jgauffin, @fideloper)
-* v1.0.3
-	* AMD / CommonJS module support (@fernandogmar)
-
 ## License
@@ -277,0 +219,0 @@

src/pubsub.js

@@ -96,3 +96,3 @@ /*
 		var topic = String( message ),
-			found = messages.hasOwnProperty( topic ),
+			found = messages.hasOwnProperty( topic ) && messages[topic].length,
 			position = topic.lastIndexOf( '.' );
@@ -102,7 +102,7 @@
 			topic = topic.substr( 0, position );
-			position = topic.lastIndexOf('.');
-			found = messages.hasOwnProperty( topic );
+			position = topic.lastIndexOf( '.' );
+			found = messages.hasOwnProperty( topic ) && messages[topic].length;
 		}
 
-		return found && messages[topic].length > 0;
+		return found;
 	}
@@ -109,0 +109,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

297863

increased by0.02%

Number of package files

27

increased by3.85%

Worsened metrics

Number of lines in readme file

227

decreased by-20.35%

No dependency changes