puppeteer-in-electron - npm Package Compare versions

Comparing version 3.0.1 to 3.0.2

bin/index.d.ts

@@ -26,8 +26,8 @@ /// <reference types="electron" />
  */
-export declare const getPage: (browser: import("puppeteer").Browser, window: Electron.BrowserWindow, allowBlankNavigate?: boolean) => Promise<import("puppeteer").Page>;
+export declare const getPage: (browser: import("puppeteer").Browser, window: Electron.BrowserView | Electron.BrowserWindow, allowBlankNavigate?: boolean) => Promise<import("puppeteer").Page>;
 declare const _default: {
     connect: (app: Electron.App, puppeteer: typeof import("puppeteer-core")) => Promise<import("puppeteer").Browser>;
-    getPage: (browser: import("puppeteer").Browser, window: Electron.BrowserWindow, allowBlankNavigate?: boolean) => Promise<import("puppeteer").Page>;
+    getPage: (browser: import("puppeteer").Browser, window: Electron.BrowserView | Electron.BrowserWindow, allowBlankNavigate?: boolean) => Promise<import("puppeteer").Page>;
     initialize: (app: Electron.App, port?: number) => Promise<void>;
 };
 export default _default;

bin/index.js

@@ -96,3 +96,3 @@ "use strict";
         if (allowBlankNavigate) {
-            await window.loadURL("about:blank");
+            await window.webContents.loadURL("about:blank");
         }
@@ -99,0 +99,0 @@ else {

index.ts

@@ -8,2 +8,3 @@ import getPort from "get-port";
 type BrowserWindow = import("electron").BrowserWindow;
+type BrowserView = import("electron").BrowserView;
 type puppeteer = typeof import("puppeteer-core");
@@ -115,3 +116,7 @@ type Browser = import("puppeteer-core").Browser;
  */
-export const getPage = async (browser: Browser, window: BrowserWindow, allowBlankNavigate: boolean = true) => {
+export const getPage = async (
+  browser: Browser,
+  window: BrowserWindow | BrowserView,
+  allowBlankNavigate: boolean = true
+) => {
   if (!browser) {
@@ -127,3 +132,3 @@ throw new Error("The parameter 'browser' was not passed in.");
     if (allowBlankNavigate) {
-      await window.loadURL("about:blank");
+      await window.webContents.loadURL("about:blank");
     } else {
@@ -130,0 +135,0 @@ throw new Error("In order to get the puppeteer Page, we must be able " +

package.json

 {
   "name": "puppeteer-in-electron",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "Run puppeteer within an electron app.",
@@ -5,0 +5,0 @@ "main": "./bin/index.js",

No alert changes

Improved metrics

Total package byte prevSize

27753

increased by0.57%

Lines of code

431

increased by1.17%

No dependency changes