react-ace - npm Package Compare versions

Comparing version 2.7.0 to 2.8.0

lib/ace.js

@@ -127,10 +127,29 @@ 'use strict';
   componentWillReceiveProps: function componentWillReceiveProps(nextProps) {
-    this.editor.getSession().setMode('ace/mode/' + nextProps.mode);
-    this.editor.setTheme('ace/theme/' + nextProps.theme);
-    this.editor.setFontSize(nextProps.fontSize);
-    this.editor.setOption('maxLines', nextProps.maxLines);
-    this.editor.setOption('readOnly', nextProps.readOnly);
-    this.editor.setOption('highlightActiveLine', nextProps.highlightActiveLine);
-    this.editor.setOption('tabSize', nextProps.tabSize);
-    this.editor.setShowPrintMargin(nextProps.showPrintMargin);
+    if (nextProps.mode !== this.props.mode) {
+      this.editor.getSession().setMode('ace/mode/' + nextProps.mode);
+    }
+    if (nextProps.theme !== this.props.theme) {
+      this.editor.setTheme('ace/theme/' + nextProps.theme);
+    }
+    if (nextProps.fontSize !== this.props.fontSize) {
+      this.editor.setFontSize(nextProps.fontSize);
+    }
+    if (nextProps.maxLines !== this.props.maxLines) {
+      this.editor.setOption('maxLines', nextProps.maxLines);
+    }
+    if (nextProps.readOnly !== this.props.readOnly) {
+      this.editor.setOption('readOnly', nextProps.readOnly);
+    }
+    if (nextProps.highlightActiveLine !== this.props.highlightActiveLine) {
+      this.editor.setOption('highlightActiveLine', nextProps.highlightActiveLine);
+    }
+    if (nextProps.tabSize !== this.props.tabSize) {
+      this.editor.setOption('tabSize', nextProps.tabSize);
+    }
+    if (nextProps.showPrintMargin !== this.props.showPrintMargin) {
+      this.editor.setShowPrintMargin(nextProps.showPrintMargin);
+    }
+    if (nextProps.showGutter !== this.props.showGutter) {
+      this.editor.renderer.setShowGutter(nextProps.showGutter);
+    }
     if (this.editor.getValue() !== nextProps.value) {
@@ -142,3 +161,2 @@ // editor.setValue is a synchronous function call, change event is emitted before setValue return.
     }
-    this.editor.renderer.setShowGutter(nextProps.showGutter);
   },
@@ -145,0 +163,0 @@

package.json

 {
   "name": "react-ace",
-  "version": "2.7.0",
+  "version": "2.8.0",
   "description": "A react component for Ace Editor",
@@ -5,0 +5,0 @@ "main": "lib/ace.js",

src/ace.jsx

@@ -125,10 +125,29 @@ var ace = require('brace');
   componentWillReceiveProps: function(nextProps) {
-    this.editor.getSession().setMode('ace/mode/' + nextProps.mode);
-    this.editor.setTheme('ace/theme/' + nextProps.theme);
-    this.editor.setFontSize(nextProps.fontSize);
-    this.editor.setOption('maxLines', nextProps.maxLines);
-    this.editor.setOption('readOnly', nextProps.readOnly);
-    this.editor.setOption('highlightActiveLine', nextProps.highlightActiveLine);
-    this.editor.setOption('tabSize', nextProps.tabSize);
-    this.editor.setShowPrintMargin(nextProps.showPrintMargin);
+    if (nextProps.mode !== this.props.mode) {
+      this.editor.getSession().setMode('ace/mode/' + nextProps.mode);
+    }
+    if (nextProps.theme !== this.props.theme) {
+      this.editor.setTheme('ace/theme/' + nextProps.theme);
+    }
+    if (nextProps.fontSize !== this.props.fontSize) {
+      this.editor.setFontSize(nextProps.fontSize);
+    }
+    if (nextProps.maxLines !== this.props.maxLines) {
+      this.editor.setOption('maxLines', nextProps.maxLines);
+    }
+    if (nextProps.readOnly !== this.props.readOnly) {
+      this.editor.setOption('readOnly', nextProps.readOnly);
+    }
+    if (nextProps.highlightActiveLine !== this.props.highlightActiveLine) {
+      this.editor.setOption('highlightActiveLine', nextProps.highlightActiveLine);
+    }
+    if (nextProps.tabSize !== this.props.tabSize) {
+      this.editor.setOption('tabSize', nextProps.tabSize);
+    }
+    if (nextProps.showPrintMargin !== this.props.showPrintMargin) {
+      this.editor.setShowPrintMargin(nextProps.showPrintMargin);
+    }
+    if (nextProps.showGutter !== this.props.showGutter) {
+      this.editor.renderer.setShowGutter(nextProps.showGutter);
+    }
     if (this.editor.getValue() !== nextProps.value) {
@@ -140,3 +159,2 @@ // editor.setValue is a synchronous function call, change event is emitted before setValue return.
     }
-    this.editor.renderer.setShowGutter(nextProps.showGutter);
   },
@@ -143,0 +161,0 @@

No alert changes

Improved metrics

Total package byte prevSize

3005641

increased by0.07%

Lines of code

69923

increased by0.08%

No dependency changes