react-ace - npm Package Compare versions

Comparing version 3.6.1 to 3.7.0

lib/ace.js

@@ -31,9 +31,7 @@ 'use strict';
 
-var _ace$acequire = _brace2.default.acequire('ace/range');
+var _ace$acequire = _brace2.default.acequire('ace/range'),
+    Range = _ace$acequire.Range;
 
-var Range = _ace$acequire.Range;
+var editorOptions = ['minLines', 'maxLines', 'readOnly', 'highlightActiveLine', 'tabSize', 'enableBasicAutocompletion', 'enableLiveAutocompletion', 'enableSnippets'];
 
-
-var editorOptions = ['minLines', 'maxLines', 'readOnly', 'highlightActiveLine', 'tabSize', 'enableBasicAutocompletion', 'enableLiveAutocompletion', 'enableSnippets '];
-
 var ReactAce = function (_Component) {
@@ -45,3 +43,3 @@ _inherits(ReactAce, _Component);
 
-    var _this = _possibleConstructorReturn(this, Object.getPrototypeOf(ReactAce).call(this, props));
+    var _this = _possibleConstructorReturn(this, (ReactAce.__proto__ || Object.getPrototypeOf(ReactAce)).call(this, props));
 
@@ -59,23 +57,23 @@ ['onChange', 'onFocus', 'onBlur', 'onCopy', 'onPaste', 'onScroll', 'handleOptions'].forEach(function (method) {
 
-      var _props = this.props;
-      var name = _props.name;
-      var className = _props.className;
-      var onBeforeLoad = _props.onBeforeLoad;
-      var mode = _props.mode;
-      var focus = _props.focus;
-      var theme = _props.theme;
-      var fontSize = _props.fontSize;
-      var value = _props.value;
-      var cursorStart = _props.cursorStart;
-      var showGutter = _props.showGutter;
-      var wrapEnabled = _props.wrapEnabled;
-      var showPrintMargin = _props.showPrintMargin;
-      var keyboardHandler = _props.keyboardHandler;
-      var onLoad = _props.onLoad;
-      var commands = _props.commands;
-      var annotations = _props.annotations;
-      var markers = _props.markers;
+      var _props = this.props,
+          name = _props.name,
+          className = _props.className,
+          onBeforeLoad = _props.onBeforeLoad,
+          mode = _props.mode,
+          focus = _props.focus,
+          theme = _props.theme,
+          fontSize = _props.fontSize,
+          value = _props.value,
+          cursorStart = _props.cursorStart,
+          showGutter = _props.showGutter,
+          wrapEnabled = _props.wrapEnabled,
+          showPrintMargin = _props.showPrintMargin,
+          keyboardHandler = _props.keyboardHandler,
+          onLoad = _props.onLoad,
+          commands = _props.commands,
+          annotations = _props.annotations,
+          markers = _props.markers;
 
 
-      this.editor = _brace2.default.edit(name);
+      this.editor = _brace2.default.edit(this.refs.editor);
 
@@ -294,10 +292,10 @@ if (onBeforeLoad) {
       markers.forEach(function (_ref) {
-        var startRow = _ref.startRow;
-        var startCol = _ref.startCol;
-        var endRow = _ref.endRow;
-        var endCol = _ref.endCol;
-        var className = _ref.className;
-        var type = _ref.type;
-        var _ref$inFront = _ref.inFront;
-        var inFront = _ref$inFront === undefined ? false : _ref$inFront;
+        var startRow = _ref.startRow,
+            startCol = _ref.startCol,
+            endRow = _ref.endRow,
+            endCol = _ref.endCol,
+            className = _ref.className,
+            type = _ref.type,
+            _ref$inFront = _ref.inFront,
+            inFront = _ref$inFront === undefined ? false : _ref$inFront;
 
@@ -311,7 +309,7 @@ var range = new Range(startRow, startCol, endRow, endCol);
     value: function render() {
-      var _props2 = this.props;
-      var name = _props2.name;
-      var width = _props2.width;
-      var height = _props2.height;
-      var style = _props2.style;
+      var _props2 = this.props,
+          name = _props2.name,
+          width = _props2.width,
+          height = _props2.height,
+          style = _props2.style;
 
@@ -318,0 +316,0 @@ var divStyle = _extends({ width: width, height: height }, style);

package.json

 {
   "name": "react-ace",
-  "version": "3.6.1",
+  "version": "3.7.0",
   "description": "A react component for Ace Editor",
@@ -19,3 +19,4 @@ "main": "lib/ace.js",
     "prepublish": "npm run clean && npm run build",
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "mocha --compilers js:babel-core/register --require tests/setup.js --recursive tests/**/*.spec.js",
+    "coverage": "nyc npm run test"
   },
@@ -40,2 +41,4 @@ "babel": {
     "babel-preset-react": "^6.5.0",
+    "chai": "^3.5.0",
+    "enzyme": "^2.4.1",
     "eslint": "^1.10.3",
@@ -45,3 +48,8 @@ "eslint-config-airbnb": "^2.1.1",
     "jest": "^0.1.37",
+    "jsdom": "^9.6.0",
+    "mocha": "^3.1.2",
+    "nyc": "^8.3.1",
+    "react-addons-test-utils": "^15.3.2",
     "rimraf": "^2.5.2",
+    "sinon": "^1.17.6",
     "webpack": "^1.12.14"
@@ -61,4 +69,20 @@ },
   "peerDependencies": {
-    "react": "^0.13.0 || ^0.14.0 || ^15.0.1"
+    "react": "^0.13.0 || ^0.14.0 || ^15.0.1",
+    "react-dom": "^0.13.0 || ^0.14.0 || ^15.0.1"
   },
+  "nyc": {
+    "exclude": [
+      "**/*.spec.js",
+      "node_modules"
+    ],
+    "extension": [
+      ".js",
+      ".jsx"
+    ],
+    "reporter": [
+      "lcov",
+      "text",
+      "html"
+    ]
+  },
   "repository": {
@@ -65,0 +89,0 @@ "type": "git",

src/ace.jsx

@@ -15,3 +15,3 @@ import ace from 'brace';
   'enableLiveAutocompletion',
-  'enableSnippets ',
+  'enableSnippets',
 ];
@@ -57,3 +57,3 @@
 
-    this.editor = ace.edit(name);
+    this.editor = ace.edit(this.refs.editor);
 
@@ -60,0 +60,0 @@ if (onBeforeLoad) {

New alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

No tests

Quality

Package does not have any tests. This is a strong signal of a poorly maintained or low quality package.

Found 1 instance in 1 package

Improved metrics

Number of package files

15

increased by7.14%

Number of low quality alerts

1

decreased by-50%

Worsened metrics

Total package byte prevSize

1286679

decreased by-58.68%

Dependency count

4

increased by33.33%

Dev dependency count

19

increased by58.33%

Lines of code

24421

decreased by-66.42%

No dependency changes