react-bootstrap-table-nextgen-filter - npm Package Compare versions

Comparing version 1.5.4 to 1.5.5

lib/index.d.ts

@@ -141,3 +141,2 @@ import PropTypes from "prop-types";
                 isEmitDataChange: boolean;
-                isReloadData: boolean;
                 componentDidMount(): void;
@@ -147,3 +146,3 @@ onFilter(column: any, filterType: any, initialize?: boolean): (filterVal: any) => void;
                 getFiltered(): any[];
-                componentDidUpdate(nextProps: import("./src/context").FilterProviderProps): void;
+                shouldComponentUpdate(nextProps: Readonly<import("./src/context").FilterProviderProps>, nextState: Readonly<{}>, nextContext: any): boolean;
                 doFilter(props: import("./src/context").FilterProviderProps, ignoreEmitDataChange?: boolean): void;
@@ -159,6 +158,6 @@ render(): import("react").JSX.Element;
                 };
-                shouldComponentUpdate?(nextProps: Readonly<import("./src/context").FilterProviderProps>, nextState: Readonly<{}>, nextContext: any): boolean;
                 componentWillUnmount?(): void;
                 componentDidCatch?(error: Error, errorInfo: import("react").ErrorInfo): void;
                 getSnapshotBeforeUpdate?(prevProps: Readonly<import("./src/context").FilterProviderProps>, prevState: Readonly<{}>): any;
+                componentDidUpdate?(prevProps: Readonly<import("./src/context").FilterProviderProps>, prevState: Readonly<{}>, snapshot?: any): void;
                 componentWillMount?(): void;
@@ -165,0 +164,0 @@ UNSAFE_componentWillMount?(): void;

lib/src/context.d.ts

@@ -21,3 +21,2 @@ import PropTypes from "prop-types";
             isEmitDataChange: boolean;
-            isReloadData: boolean;
             componentDidMount(): void;
@@ -27,3 +26,3 @@ onFilter(column: any, filterType: any, initialize?: boolean): (filterVal: any) => void;
             getFiltered(): any[];
-            componentDidUpdate(nextProps: FilterProviderProps): void;
+            shouldComponentUpdate(nextProps: Readonly<FilterProviderProps>, nextState: Readonly<{}>, nextContext: any): boolean;
             doFilter(props: FilterProviderProps, ignoreEmitDataChange?: boolean): void;
@@ -39,6 +38,6 @@ render(): React.JSX.Element;
             };
-            shouldComponentUpdate?(nextProps: Readonly<FilterProviderProps>, nextState: Readonly<{}>, nextContext: any): boolean;
             componentWillUnmount?(): void;
             componentDidCatch?(error: Error, errorInfo: React.ErrorInfo): void;
             getSnapshotBeforeUpdate?(prevProps: Readonly<FilterProviderProps>, prevState: Readonly<{}>): any;
+            componentDidUpdate?(prevProps: Readonly<FilterProviderProps>, prevState: Readonly<{}>, snapshot?: any): void;
             componentWillMount?(): void;
@@ -45,0 +44,0 @@ UNSAFE_componentWillMount?(): void;

lib/src/context.js

@@ -48,3 +48,2 @@ "use strict";
       _this.isEmitDataChange = false;
-      _this.isReloadData = false;
       return _this;
@@ -115,18 +114,10 @@ }
     }, {
-      key: "componentDidUpdate",
-      value: function componentDidUpdate(nextProps) {
+      key: "shouldComponentUpdate",
+      value: function shouldComponentUpdate(nextProps, nextState, nextContext) {
         if (!isRemoteFiltering() && !_.isEqual(nextProps.data, this.data)) {
-          if (nextProps.dataChangeListener && !this.isEmitDataChange) {
-            if (this.currFilters.name === undefined && this.currFilters.quality === undefined) {
-              nextProps.dataChangeListener.emit("filterChanged", nextProps.data.length);
-              this.data = nextProps.data;
-            } else if (this.isReloadData) {
-              this.doFilter(nextProps, false);
-              this.isReloadData = false;
-            } else {
-              this.isReloadData = true;
-            }
-          }
+          this.doFilter(nextProps, this.isEmitDataChange);
+        } else {
+          this.data = nextProps.data;
         }
-        this.isEmitDataChange = false;
+        return true;
       }
@@ -133,0 +124,0 @@ }, {

package.json

 {
   "name": "react-bootstrap-table-nextgen-filter",
-  "version": "1.5.4",
+  "version": "1.5.5",
   "description": "It's a column filter addon for react-bootstrap-table-nextgen",
@@ -5,0 +5,0 @@ "main": "./lib/index.js",

No alert changes

Worsened metrics

Total package byte prevSize

848208

decreased by-0.47%

Lines of code

3207

decreased by-0.47%

No dependency changes