react-calendar-timeline - npm Package Compare versions

Comparing version 0.15.8 to 0.15.9

CHANGELOG.md

@@ -12,2 +12,8 @@ # Change Log
 
+## 0.15.9
+
+### Fixed
+
+* header positioned incorrectly when not fixed/sticky - caused by #236
+
 ## 0.15.8
@@ -14,0 +20,0 @@

lib/lib/Timeline.js

@@ -707,3 +707,2 @@ 'use strict';
             },
-            this.header(canvasTimeStart, zoom, canvasTimeEnd, canvasWidth, minUnit, timeSteps, headerLabelGroupHeight, headerLabelHeight),
             _react2.default.createElement(
@@ -727,2 +726,3 @@ 'div',
               this.todayLine(canvasTimeStart, zoom, canvasTimeEnd, canvasWidth, minUnit, height, headerHeight),
+              this.header(canvasTimeStart, zoom, canvasTimeEnd, canvasWidth, minUnit, timeSteps, headerLabelGroupHeight, headerLabelHeight),
               mouseOverCanvas && showCursorLine ? this.cursorLine(cursorTime, canvasTimeStart, zoom, canvasTimeEnd, canvasWidth, minUnit, height, headerHeight) : null,
@@ -1506,2 +1506,9 @@ this.infoLabel(),
 
+
+    if (_this4.props.onCanvasDoubleClick == null || (0, _domHelpers.hasSomeParentTheClass)(e.target, 'rct-header')) {
+      // do nothing cuz either we don't have on CanvasdoubleClick or we clicked on header
+      // TODO: there has got to be a better way of handling this
+      return;
+    }
+
     var zoom = visibleTimeEnd - visibleTimeStart;
@@ -1508,0 +1515,0 @@ var canvasTimeEnd = canvasTimeStart + zoom * 3;

package.json

 {
   "name": "react-calendar-timeline",
-  "version": "0.15.8",
+  "version": "0.15.9",
   "description": "react calendar timeline",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

src/lib/Timeline.js

@@ -1387,2 +1387,12 @@ import PropTypes from 'prop-types'
     } = this.state
+
+    if (
+      this.props.onCanvasDoubleClick == null ||
+      hasSomeParentTheClass(e.target, 'rct-header')
+    ) {
+      // do nothing cuz either we don't have on CanvasdoubleClick or we clicked on header
+      // TODO: there has got to be a better way of handling this
+      return
+    }
+
     const zoom = visibleTimeEnd - visibleTimeStart
@@ -1592,12 +1602,2 @@ const canvasTimeEnd = canvasTimeStart + zoom * 3
           >
-            {this.header(
-              canvasTimeStart,
-              zoom,
-              canvasTimeEnd,
-              canvasWidth,
-              minUnit,
-              timeSteps,
-              headerLabelGroupHeight,
-              headerLabelHeight
-            )}
             <div
@@ -1643,2 +1643,12 @@ ref={el => (this.canvasComponent = el)}
               )}
+              {this.header(
+                canvasTimeStart,
+                zoom,
+                canvasTimeEnd,
+                canvasWidth,
+                minUnit,
+                timeSteps,
+                headerLabelGroupHeight,
+                headerLabelHeight
+              )}
               {mouseOverCanvas && showCursorLine
@@ -1645,0 +1655,0 @@ ? this.cursorLine(

No alert changes

Improved metrics

Total package byte prevSize

361691

increased by0.2%

Lines of code

8490

increased by0.15%

No dependency changes