react-edit-text - npm Package Compare versions

Comparing version 4.0.1 to 4.0.2

CHANGELOG.md

@@ -0,1 +1,8 @@
+## [4.0.2](https://github.com/bymi15/react-edit-text/compare/v4.0.1...v4.0.2) (2021-04-03)
+
+
+### Bug Fixes
+
+* setSelectionRange causing bugs for input types that are not text ([777fba9](https://github.com/bymi15/react-edit-text/commit/777fba9f5d401d4374b653e6ae4f7f39b2c2adca))
+
 ## [4.0.1](https://github.com/bymi15/react-edit-text/compare/v4.0.0...v4.0.1) (2021-03-09)
@@ -2,0 +9,0 @@

dist/index.js

@@ -1166,2 +1166,8 @@ function _interopDefault (ex) { return (ex && (typeof ex === 'object') && 'default' in ex) ? ex['default'] : ex; }
 
+    _this.handleFocus = function (e) {
+      if (_this.props.type === 'text') {
+        e.currentTarget.setSelectionRange(e.currentTarget.value.length, e.currentTarget.value.length);
+      }
+    };
+
     _this.state = {
@@ -1229,5 +1235,3 @@ previousValue: props.defaultValue || '',
           autoFocus: true,
-          onFocus: function onFocus(e) {
-            return e.currentTarget.setSelectionRange(e.currentTarget.value.length, e.currentTarget.value.length);
-          }
+          onFocus: this.handleFocus
         });
@@ -1248,5 +1252,3 @@ } else {
           autoFocus: true,
-          onFocus: function onFocus(e) {
-            return e.currentTarget.setSelectionRange(e.currentTarget.value.length, e.currentTarget.value.length);
-          }
+          onFocus: this.handleFocus
         });
@@ -1253,0 +1255,0 @@ }

dist/index.modern.js

@@ -1164,2 +1164,8 @@ import React from 'react';
 
+    _this.handleFocus = function (e) {
+      if (_this.props.type === 'text') {
+        e.currentTarget.setSelectionRange(e.currentTarget.value.length, e.currentTarget.value.length);
+      }
+    };
+
     _this.state = {
@@ -1227,5 +1233,3 @@ previousValue: props.defaultValue || '',
           autoFocus: true,
-          onFocus: function onFocus(e) {
-            return e.currentTarget.setSelectionRange(e.currentTarget.value.length, e.currentTarget.value.length);
-          }
+          onFocus: this.handleFocus
         });
@@ -1246,5 +1250,3 @@ } else {
           autoFocus: true,
-          onFocus: function onFocus(e) {
-            return e.currentTarget.setSelectionRange(e.currentTarget.value.length, e.currentTarget.value.length);
-          }
+          onFocus: this.handleFocus
         });
@@ -1251,0 +1253,0 @@ }

package.json

 {
   "name": "react-edit-text",
-  "version": "4.0.1",
+  "version": "4.0.2",
   "description": "Simple editable text component for React",
@@ -5,0 +5,0 @@ "author": "Brian Min <[e-mail]> (https://github.com/bymi15)",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

2750

increased by0.07%

Worsened metrics

Total package byte prevSize

307208

decreased by-0.08%

No dependency changes